[maps] fix geo line source not loaded unless maps application is opened #159432

nreese · 2023-06-10T12:44:47Z

PR consolidates source registry into a single file to ensure that all sources are registered when only map embeddable is loaded. To prevent regression, unit test added to ensure that all SOURCE_TYPES enum values are contained in registry.

…-ref HEAD~1..HEAD --fix'

nreese · 2023-06-10T13:50:31Z

@elasticmachine merge upstream

nreese · 2023-06-12T13:34:03Z

@elasticmachine merge upstream

elasticmachine · 2023-06-12T18:47:49Z

Pinging @elastic/kibana-presentation (Team:Presentation)

ThomThomson

Reproduced this with the instructions from the issue, then switched to your branch and it's fixed! This is also a nice cleanup, and I especially appreciate the test to cover the registry. I left a couple tiny nits but LGTM!

ThomThomson · 2023-06-12T19:45:24Z

x-pack/plugins/maps/public/connected_components/toolbar_overlay/toolbar_overlay.test.tsx

@@ -14,6 +14,13 @@ jest.mock('../../kibana_services', () => {
    getMapsCapabilities() {
      return { save: true };
    },
+    getEMSSettings() {


nit: I wonder if it's possible to have a common / default mock of the kibana_services so that you don't need to update so many files every time something new needs to be added.

I am not sure since you can not include variables inside mocked import scope.

Definitely not something to change in this PR (potentially not something to change at all), but we usually do it in Dashboard by providing a sensible default for the mock in jest_setup example. Then for any test that needs a variable injected we override the service with a jest.fn() example.

It works pretty well, but I'm not sure how easily that would be applicable to the maps service infrastructure.

x-pack/plugins/maps/public/classes/sources/setup_sources.ts

kibana-ci · 2023-06-12T22:03:02Z

💚 Build Succeeded

Buildkite Build
Commit: 0c632d8

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`maps`	981	983	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`maps`	2.7MB	2.7MB	+159.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	410	414	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	491	495	+4
total			+6

History

💔 Build #134547 failed cab3907
💚 Build #134498 succeeded eeb8373
💔 Build #134471 failed 04f69f1
💔 Build #134451 failed 46517ad
💔 Build #134411 failed 9510ef1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2023-06-12T22:13:47Z

💚 All backports created successfully

Status	Branch	Result
✅	8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ed (elastic#159432) closes elastic#159408 PR consolidates source registry into a single file to ensure that all sources are registered when only map embeddable is loaded. To prevent regression, unit test added to ensure that all SOURCE_TYPES enum values are contained in registry. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit cb7c5b3)

…ed (elastic#159432) closes elastic#159408 PR consolidates source registry into a single file to ensure that all sources are registered when only map embeddable is loaded. To prevent regression, unit test added to ensure that all SOURCE_TYPES enum values are contained in registry. --------- Co-authored-by: kibanamachine <[email protected]>

…s opened (elastic#159432)

nreese · 2023-06-12T23:13:53Z

8.8 backport #159532

…s opened (#159432) (#159532) Manual backport of #159432 Needed to remove ES_DISTANCE_SOURCE reference since ES_DISTANCE_SOURCE does not exist on 8.8 branch --------- Co-authored-by: kibanamachine <[email protected]>

* main: (199 commits) [Lens] Add custom formatter within the Lens editor (elastic#158468) [Uptime] Hide app if no data is available (elastic#159118) [CodeEditor] Add grok highlighting (elastic#159334) Expose decoded cloudId components from the cloud plugin's contract (elastic#159442) [Profiling] Use collector and symbolizer integrations in the add data page (elastic#159481) [Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (elastic#157011) [APM] Add feature flag for not available apm schema (elastic#158911) [Lens] Remove deprecated componentWillReceiveProps usage (elastic#159502) [api-docs] 2023-06-13 Daily api_docs build (elastic#159536) [data views] Use versioned router for REST routes (elastic#158608) [maps] fix geo line source not loaded unless maps application is opened (elastic#159432) [Enterprise Search][Search application]Fix Create Api key url (elastic#159519) [Security Solution] Increase timeout for indexing hosts (elastic#159518) dashboard Reset button disable (elastic#159430) [Security Solution] Unskip Endpoint API tests after package fix (elastic#159484) [Synthetics] adjust alert timing (elastic#159511) [ResponseOps][rule registry] Remove usages of `refresh: true` (elastic#159252) Revert "Remove unused package (elastic#158597)" [Serverless] Adding config to disable authentication on task manager background worker utilization API (elastic#159505) Remove unused package (elastic#158597) ...

[maps] fix geo line source not loaded unless maps application is opened

bbeb735

nreese added release_note:fix v8.9.0 v8.8.2 labels Jun 10, 2023

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

e1164f0

…-ref HEAD~1..HEAD --fix'

Merge branch 'main' into issue_159408

51e879d

kibanamachine and others added 5 commits June 12, 2023 09:34

Merge branch 'main' into issue_159408

534ec7b

fix jest test

9510ef1

fix map_embeddable jest test

46517ad

fix toc_entry test

04f69f1

more jest test fixes

eeb8373

nreese marked this pull request as ready for review June 12, 2023 18:47

nreese requested a review from a team as a code owner June 12, 2023 18:47

nreese requested a review from ThomThomson June 12, 2023 18:47

nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps labels Jun 12, 2023

ThomThomson approved these changes Jun 12, 2023

View reviewed changes

nreese added 2 commits June 12, 2023 14:00

set registered during setupSources execution

cab3907

tslint

0c632d8

nreese merged commit cb7c5b3 into elastic:main Jun 12, 2023

kibanamachine mentioned this pull request Jun 12, 2023

[8.8] [maps] fix geo line source not loaded unless maps application is opened (#159432) #159527

Closed

nreese added a commit to nreese/kibana that referenced this pull request Jun 12, 2023

[8.8] [maps] fix geo line source not loaded unless maps application i…

e0e4d73

…s opened (elastic#159432)

nreese mentioned this pull request Jun 12, 2023

[8.8] [maps] fix geo line source not loaded unless maps application is opened (#159432) #159532

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[maps] fix geo line source not loaded unless maps application is opened #159432

[maps] fix geo line source not loaded unless maps application is opened #159432

nreese commented Jun 10, 2023 •

edited by kibanamachine

Loading

nreese commented Jun 10, 2023

nreese commented Jun 12, 2023

elasticmachine commented Jun 12, 2023

ThomThomson left a comment

ThomThomson Jun 12, 2023

nreese Jun 12, 2023

ThomThomson Jun 12, 2023 •

edited

Loading

kibana-ci commented Jun 12, 2023

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented Jun 12, 2023

nreese commented Jun 12, 2023

[maps] fix geo line source not loaded unless maps application is opened #159432

[maps] fix geo line source not loaded unless maps application is opened #159432

Conversation

nreese commented Jun 10, 2023 • edited by kibanamachine Loading

nreese commented Jun 10, 2023

nreese commented Jun 12, 2023

elasticmachine commented Jun 12, 2023

ThomThomson left a comment

Choose a reason for hiding this comment

ThomThomson Jun 12, 2023

Choose a reason for hiding this comment

nreese Jun 12, 2023

Choose a reason for hiding this comment

ThomThomson Jun 12, 2023 • edited Loading

Choose a reason for hiding this comment

kibana-ci commented Jun 12, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented Jun 12, 2023

💚 All backports created successfully

Questions ?

nreese commented Jun 12, 2023

nreese commented Jun 10, 2023 •

edited by kibanamachine

Loading

ThomThomson Jun 12, 2023 •

edited

Loading