Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.8] [maps] fix geo line source not loaded unless maps application is opened (#159432) #159532

Merged
merged 2 commits into from
Jun 13, 2023
Merged

[8.8] [maps] fix geo line source not loaded unless maps application is opened (#159432) #159532

merged 2 commits into from
Jun 13, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jun 12, 2023

Manual backport of #159432

Needed to remove ES_DISTANCE_SOURCE reference since ES_DISTANCE_SOURCE does not exist on 8.8 branch

nreese and others added 2 commits June 12, 2023 17:09
@nreese @kibanamachine
[maps] fix geo line source not loaded unless maps application is open…
50b031b 
…ed (elastic#159432)

closes elastic#159408

PR consolidates source registry into a single file to ensure that all
sources are registered when only map embeddable is loaded. To prevent
regression, unit test added to ensure that all SOURCE_TYPES enum values
are contained in registry.

---------

Co-authored-by: kibanamachine <[email protected]>
@nreese
[8.8] [maps] fix geo line source not loaded unless maps application i…
e0e4d73 
…s opened (elastic#159432)
This was referenced Jun 12, 2023
Closed
Merged
@nreese nreese changed the title Backport 8 8 issue 159408 [8.8] [maps] fix geo line source not loaded unless maps application is opened (#159432) Jun 12, 2023
@nreese nreese marked this pull request as ready for review June 12, 2023 23:15
@nreese nreese added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jun 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 947 949 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.8MB 2.8MB +166.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 480 484 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 3168766 into elastic:8.8 Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nreese @elasticmachine @kibana-ci