-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Enable Serverless for exceptions/entry
and exceptions/rule_details_flow
Cypress tests
#169211
Merged
jpdjere
merged 8 commits into
elastic:main
from
jpdjere:flaky-test-runner-exceptions-entry-and_rule_details_flow
Oct 24, 2023
Merged
[Security Solution] Enable Serverless for exceptions/entry
and exceptions/rule_details_flow
Cypress tests
#169211
jpdjere
merged 8 commits into
elastic:main
from
jpdjere:flaky-test-runner-exceptions-entry-and_rule_details_flow
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2023
This was referenced Oct 19, 2023
jpdjere
changed the title
[Security Solution] Flaky test runner for
[Security Solution] Enable Serverless for Oct 23, 2023
exceptions/entry
and exceptions/rule_details_flow
Cypress testsexceptions/entry
and exceptions/rule_details_flow
Cypress tests
jpdjere
added
Team:Detections and Resp
Security Detection Response Team
Team:Detection Engine
Security Solution Detection Engine Area
v8.12.0
labels
Oct 23, 2023
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
jpdjere
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Oct 23, 2023
yctercero
approved these changes
Oct 23, 2023
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @jpdjere |
jpdjere
deleted the
flaky-test-runner-exceptions-entry-and_rule_details_flow
branch
October 24, 2023 16:04
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2023
…eptions/rule_details_flow` Cypress tests (elastic#169211) ## Summary Flaky test runner for Cypress tests in: - `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry` - `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow` ## Changes - `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/use_value_list.cy.ts` **enabled on Serverless** - `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/multiple_conditions.cy.ts` **enabled on Serverless** - `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/read_only_view.cy.ts` **removed from Serverless testing** ## Related failing-test issues ### `exceptions/entry` 1. elastic#165734 2. elastic#165652 3. elastic#165651 ### `exceptions/rule_details_flow` 4. elastic#165773 5. elastic#165742 6. elastic#165736 7. elastic#163923 8. elastic#164007 9. elastic#169382 **Unreported flaky test that was discovered when investigating these issues. Tagged as `legit-flake` and assigned to @elastic/security-detection-engine** 10. elastic#169274 **Flaky test reported by the Kibana machine while this investigation was taking place. Since the flaky test runner for the related tests detected flakiness for the same test file (though not same test), I'm marking this as legit-flake for it to be investigated.** ### Flaky test runner link - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3577 - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3621 [SERVERLESS TAGS ADJUSTED] (cherry picked from commit 9a73009)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 26, 2023
…nd `exceptions/rule_details_flow` Cypress tests (#169211) (#169679) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution] Enable Serverless for `exceptions/entry` and `exceptions/rule_details_flow` Cypress tests (#169211)](#169211) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Juan Pablo Djeredjian","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-24T16:04:12Z","message":"[Security Solution] Enable Serverless for `exceptions/entry` and `exceptions/rule_details_flow` Cypress tests (#169211)\n\n## Summary\r\n\r\nFlaky test runner for Cypress tests in:\r\n- `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry` \r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow`\r\n\r\n## Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/use_value_list.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/multiple_conditions.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/read_only_view.cy.ts`\r\n**removed from Serverless testing**\r\n\r\n## Related failing-test issues\r\n\r\n### `exceptions/entry`\r\n1. https://github.com/elastic/kibana/issues/165734\r\n2. https://github.com/elastic/kibana/issues/165652\r\n3. https://github.com/elastic/kibana/issues/165651\r\n\r\n### `exceptions/rule_details_flow`\r\n4. https://github.com/elastic/kibana/issues/165773\r\n5. https://github.com/elastic/kibana/issues/165742\r\n6. https://github.com/elastic/kibana/issues/165736\r\n7. https://github.com/elastic/kibana/issues/163923\r\n8. https://github.com/elastic/kibana/issues/164007\r\n9. https://github.com/elastic/kibana/issues/169382\r\n**Unreported flaky test that was discovered when investigating these\r\nissues. Tagged as `legit-flake` and assigned to\r\n@elastic/security-detection-engine**\r\n10. https://github.com/elastic/kibana/issues/169274\r\n**Flaky test reported by the Kibana machine while this investigation was\r\ntaking place.\r\nSince the flaky test runner for the related tests detected flakiness for\r\nthe same test file (though not same test), I'm marking this as\r\nlegit-flake for it to be investigated.**\r\n\r\n### Flaky test runner link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3577\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3621\r\n[SERVERLESS TAGS ADJUSTED]","sha":"9a73009c2b2effab436cae61735cccc79af1a21d","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team:Detection Engine","v8.11.0","v8.12.0"],"number":169211,"url":"https://github.com/elastic/kibana/pull/169211","mergeCommit":{"message":"[Security Solution] Enable Serverless for `exceptions/entry` and `exceptions/rule_details_flow` Cypress tests (#169211)\n\n## Summary\r\n\r\nFlaky test runner for Cypress tests in:\r\n- `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry` \r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow`\r\n\r\n## Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/use_value_list.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/multiple_conditions.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/read_only_view.cy.ts`\r\n**removed from Serverless testing**\r\n\r\n## Related failing-test issues\r\n\r\n### `exceptions/entry`\r\n1. https://github.com/elastic/kibana/issues/165734\r\n2. https://github.com/elastic/kibana/issues/165652\r\n3. https://github.com/elastic/kibana/issues/165651\r\n\r\n### `exceptions/rule_details_flow`\r\n4. https://github.com/elastic/kibana/issues/165773\r\n5. https://github.com/elastic/kibana/issues/165742\r\n6. https://github.com/elastic/kibana/issues/165736\r\n7. https://github.com/elastic/kibana/issues/163923\r\n8. https://github.com/elastic/kibana/issues/164007\r\n9. https://github.com/elastic/kibana/issues/169382\r\n**Unreported flaky test that was discovered when investigating these\r\nissues. Tagged as `legit-flake` and assigned to\r\n@elastic/security-detection-engine**\r\n10. https://github.com/elastic/kibana/issues/169274\r\n**Flaky test reported by the Kibana machine while this investigation was\r\ntaking place.\r\nSince the flaky test runner for the related tests detected flakiness for\r\nthe same test file (though not same test), I'm marking this as\r\nlegit-flake for it to be investigated.**\r\n\r\n### Flaky test runner link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3577\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3621\r\n[SERVERLESS TAGS ADJUSTED]","sha":"9a73009c2b2effab436cae61735cccc79af1a21d"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169211","number":169211,"mergeCommit":{"message":"[Security Solution] Enable Serverless for `exceptions/entry` and `exceptions/rule_details_flow` Cypress tests (#169211)\n\n## Summary\r\n\r\nFlaky test runner for Cypress tests in:\r\n- `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry` \r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow`\r\n\r\n## Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/use_value_list.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/multiple_conditions.cy.ts`\r\n**enabled on Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/read_only_view.cy.ts`\r\n**removed from Serverless testing**\r\n\r\n## Related failing-test issues\r\n\r\n### `exceptions/entry`\r\n1. https://github.com/elastic/kibana/issues/165734\r\n2. https://github.com/elastic/kibana/issues/165652\r\n3. https://github.com/elastic/kibana/issues/165651\r\n\r\n### `exceptions/rule_details_flow`\r\n4. https://github.com/elastic/kibana/issues/165773\r\n5. https://github.com/elastic/kibana/issues/165742\r\n6. https://github.com/elastic/kibana/issues/165736\r\n7. https://github.com/elastic/kibana/issues/163923\r\n8. https://github.com/elastic/kibana/issues/164007\r\n9. https://github.com/elastic/kibana/issues/169382\r\n**Unreported flaky test that was discovered when investigating these\r\nissues. Tagged as `legit-flake` and assigned to\r\n@elastic/security-detection-engine**\r\n10. https://github.com/elastic/kibana/issues/169274\r\n**Flaky test reported by the Kibana machine while this investigation was\r\ntaking place.\r\nSince the flaky test runner for the related tests detected flakiness for\r\nthe same test file (though not same test), I'm marking this as\r\nlegit-flake for it to be investigated.**\r\n\r\n### Flaky test runner link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3577\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3621\r\n[SERVERLESS TAGS ADJUSTED]","sha":"9a73009c2b2effab436cae61735cccc79af1a21d"}}]}] BACKPORT--> Co-authored-by: Juan Pablo Djeredjian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Detection Engine
Security Solution Detection Engine Area
Team:Detections and Resp
Security Detection Response Team
v8.11.0
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Flaky test runner for Cypress tests in:
x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry
x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow
Changes
x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/use_value_list.cy.ts
enabled on Serverlessx-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/multiple_conditions.cy.ts
enabled on Serverlessx-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/read_only_view.cy.ts
removed from Serverless testingRelated failing-test issues
exceptions/entry
exceptions/rule_details_flow
Unreported flaky test that was discovered when investigating these issues. Tagged as
legit-flake
and assigned to @elastic/security-detection-engineFlaky test reported by the Kibana machine while this investigation was taking place.
Since the flaky test runner for the related tests detected flakiness for the same test file (though not same test), I'm marking this as legit-flake for it to be investigated.
Flaky test runner link