Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/add_edit_exception_data_view.cy.ts - /Add exception using data views from rule details -- Creates an exception item and close all matching alerts #169382

Closed
jpdjere opened this issue Oct 19, 2023 · 1 comment
Assignees
Labels
bug Fixes for quality problems that affect the customer experience consider-next failed-test A test failure on a tracked branch, potentially flaky-test legit-flake Test was triaged and marked as an actual flake. Team:Detection Engine Security Solution Detection Engine Area

Comments

@jpdjere
Copy link
Contributor

jpdjere commented Oct 19, 2023

While investigating flaky tests in #169211

the following unreported test was detected as flaky:

Test file: x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/add_edit_exception_data_view.cy.ts
Test name: Add exception using data views from rule details -- Creates an exception item and close all matching alerts

Link to flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3577#018b4213-3310-4733-a00f-7002f63f7896

@jpdjere jpdjere added bug Fixes for quality problems that affect the customer experience failed-test A test failure on a tracked branch, potentially flaky-test Team:Detection Engine Security Solution Detection Engine Area legit-flake Test was triaged and marked as an actual flake. labels Oct 19, 2023
jpdjere added a commit that referenced this issue Oct 24, 2023
…eptions/rule_details_flow` Cypress tests (#169211)

## Summary

Flaky test runner for Cypress tests in:
- `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry` 
-
`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow`

## Changes

-
`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/use_value_list.cy.ts`
**enabled on Serverless**
-
`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/multiple_conditions.cy.ts`
**enabled on Serverless**
-
`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/read_only_view.cy.ts`
**removed from Serverless testing**

## Related failing-test issues

### `exceptions/entry`
1. #165734
2. #165652
3. #165651

### `exceptions/rule_details_flow`
4. #165773
5. #165742
6. #165736
7. #163923
8. #164007
9. #169382
**Unreported flaky test that was discovered when investigating these
issues. Tagged as `legit-flake` and assigned to
@elastic/security-detection-engine**
10. #169274
**Flaky test reported by the Kibana machine while this investigation was
taking place.
Since the flaky test runner for the related tests detected flakiness for
the same test file (though not same test), I'm marking this as
legit-flake for it to be investigated.**

### Flaky test runner link

-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3577
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3621
[SERVERLESS TAGS ADJUSTED]
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 24, 2023
…eptions/rule_details_flow` Cypress tests (elastic#169211)

## Summary

Flaky test runner for Cypress tests in:
- `x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry`
-
`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow`

## Changes

-
`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/use_value_list.cy.ts`
**enabled on Serverless**
-
`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/multiple_conditions.cy.ts`
**enabled on Serverless**
-
`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/read_only_view.cy.ts`
**removed from Serverless testing**

## Related failing-test issues

### `exceptions/entry`
1. elastic#165734
2. elastic#165652
3. elastic#165651

### `exceptions/rule_details_flow`
4. elastic#165773
5. elastic#165742
6. elastic#165736
7. elastic#163923
8. elastic#164007
9. elastic#169382
**Unreported flaky test that was discovered when investigating these
issues. Tagged as `legit-flake` and assigned to
@elastic/security-detection-engine**
10. elastic#169274
**Flaky test reported by the Kibana machine while this investigation was
taking place.
Since the flaky test runner for the related tests detected flakiness for
the same test file (though not same test), I'm marking this as
legit-flake for it to be investigated.**

### Flaky test runner link

-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3577
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3621
[SERVERLESS TAGS ADJUSTED]

(cherry picked from commit 9a73009)
kibanamachine referenced this issue Oct 26, 2023
…nd `exceptions/rule_details_flow` Cypress tests (#169211) (#169679)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solution] Enable Serverless for `exceptions/entry` and
`exceptions/rule_details_flow` Cypress tests
(#169211)](#169211)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Juan Pablo
Djeredjian","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-24T16:04:12Z","message":"[Security
Solution] Enable Serverless for `exceptions/entry` and
`exceptions/rule_details_flow` Cypress tests (#169211)\n\n##
Summary\r\n\r\nFlaky test runner for Cypress tests in:\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry`
\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow`\r\n\r\n##
Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/use_value_list.cy.ts`\r\n**enabled
on
Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/multiple_conditions.cy.ts`\r\n**enabled
on
Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/read_only_view.cy.ts`\r\n**removed
from Serverless testing**\r\n\r\n## Related failing-test
issues\r\n\r\n### `exceptions/entry`\r\n1.
https://github.com/elastic/kibana/issues/165734\r\n2.
https://github.com/elastic/kibana/issues/165652\r\n3.
https://github.com/elastic/kibana/issues/165651\r\n\r\n###
`exceptions/rule_details_flow`\r\n4.
https://github.com/elastic/kibana/issues/165773\r\n5.
https://github.com/elastic/kibana/issues/165742\r\n6.
https://github.com/elastic/kibana/issues/165736\r\n7.
https://github.com/elastic/kibana/issues/163923\r\n8.
https://github.com/elastic/kibana/issues/164007\r\n9.
https://github.com/elastic/kibana/issues/169382\r\n**Unreported flaky
test that was discovered when investigating these\r\nissues. Tagged as
`legit-flake` and assigned
to\r\n@elastic/security-detection-engine**\r\n10.
https://github.com/elastic/kibana/issues/169274\r\n**Flaky test reported
by the Kibana machine while this investigation was\r\ntaking
place.\r\nSince the flaky test runner for the related tests detected
flakiness for\r\nthe same test file (though not same test), I'm marking
this as\r\nlegit-flake for it to be investigated.**\r\n\r\n### Flaky
test runner
link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3577\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3621\r\n[SERVERLESS
TAGS
ADJUSTED]","sha":"9a73009c2b2effab436cae61735cccc79af1a21d","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Team:Detection
Engine","v8.11.0","v8.12.0"],"number":169211,"url":"https://github.com/elastic/kibana/pull/169211","mergeCommit":{"message":"[Security
Solution] Enable Serverless for `exceptions/entry` and
`exceptions/rule_details_flow` Cypress tests (#169211)\n\n##
Summary\r\n\r\nFlaky test runner for Cypress tests in:\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry`
\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow`\r\n\r\n##
Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/use_value_list.cy.ts`\r\n**enabled
on
Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/multiple_conditions.cy.ts`\r\n**enabled
on
Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/read_only_view.cy.ts`\r\n**removed
from Serverless testing**\r\n\r\n## Related failing-test
issues\r\n\r\n### `exceptions/entry`\r\n1.
https://github.com/elastic/kibana/issues/165734\r\n2.
https://github.com/elastic/kibana/issues/165652\r\n3.
https://github.com/elastic/kibana/issues/165651\r\n\r\n###
`exceptions/rule_details_flow`\r\n4.
https://github.com/elastic/kibana/issues/165773\r\n5.
https://github.com/elastic/kibana/issues/165742\r\n6.
https://github.com/elastic/kibana/issues/165736\r\n7.
https://github.com/elastic/kibana/issues/163923\r\n8.
https://github.com/elastic/kibana/issues/164007\r\n9.
https://github.com/elastic/kibana/issues/169382\r\n**Unreported flaky
test that was discovered when investigating these\r\nissues. Tagged as
`legit-flake` and assigned
to\r\n@elastic/security-detection-engine**\r\n10.
https://github.com/elastic/kibana/issues/169274\r\n**Flaky test reported
by the Kibana machine while this investigation was\r\ntaking
place.\r\nSince the flaky test runner for the related tests detected
flakiness for\r\nthe same test file (though not same test), I'm marking
this as\r\nlegit-flake for it to be investigated.**\r\n\r\n### Flaky
test runner
link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3577\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3621\r\n[SERVERLESS
TAGS
ADJUSTED]","sha":"9a73009c2b2effab436cae61735cccc79af1a21d"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169211","number":169211,"mergeCommit":{"message":"[Security
Solution] Enable Serverless for `exceptions/entry` and
`exceptions/rule_details_flow` Cypress tests (#169211)\n\n##
Summary\r\n\r\nFlaky test runner for Cypress tests in:\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry`
\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow`\r\n\r\n##
Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/use_value_list.cy.ts`\r\n**enabled
on
Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/entry/multiple_conditions.cy.ts`\r\n**enabled
on
Serverless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/read_only_view.cy.ts`\r\n**removed
from Serverless testing**\r\n\r\n## Related failing-test
issues\r\n\r\n### `exceptions/entry`\r\n1.
https://github.com/elastic/kibana/issues/165734\r\n2.
https://github.com/elastic/kibana/issues/165652\r\n3.
https://github.com/elastic/kibana/issues/165651\r\n\r\n###
`exceptions/rule_details_flow`\r\n4.
https://github.com/elastic/kibana/issues/165773\r\n5.
https://github.com/elastic/kibana/issues/165742\r\n6.
https://github.com/elastic/kibana/issues/165736\r\n7.
https://github.com/elastic/kibana/issues/163923\r\n8.
https://github.com/elastic/kibana/issues/164007\r\n9.
https://github.com/elastic/kibana/issues/169382\r\n**Unreported flaky
test that was discovered when investigating these\r\nissues. Tagged as
`legit-flake` and assigned
to\r\n@elastic/security-detection-engine**\r\n10.
https://github.com/elastic/kibana/issues/169274\r\n**Flaky test reported
by the Kibana machine while this investigation was\r\ntaking
place.\r\nSince the flaky test runner for the related tests detected
flakiness for\r\nthe same test file (though not same test), I'm marking
this as\r\nlegit-flake for it to be investigated.**\r\n\r\n### Flaky
test runner
link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3577\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3621\r\n[SERVERLESS
TAGS ADJUSTED]","sha":"9a73009c2b2effab436cae61735cccc79af1a21d"}}]}]
BACKPORT-->

Co-authored-by: Juan Pablo Djeredjian <[email protected]>
yctercero added a commit that referenced this issue Dec 4, 2023
…#171697)

## Summary

Addresses #169382,
#169274

Wasn't liking the 10s default rule interval in the test. Updated it to
`1m` that requires enabling/disabling to kick off a run.

---------

Co-authored-by: Kibana Machine <[email protected]>
@yctercero
Copy link
Contributor

Addressed in #171697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience consider-next failed-test A test failure on a tracked branch, potentially flaky-test legit-flake Test was triaged and marked as an actual flake. Team:Detection Engine Security Solution Detection Engine Area
Projects
None yet
Development

No branches or pull requests

2 participants