[Cypress][Flake][Detection Engine] Fix flakey add/edit exception test #171697
Conversation
yctercero
added
release_note:skip
|
@elasticmachine merge upstream |
| @@ -54,7 +54,7 @@ export function visitRuleDetailsPage(ruleId: string, options?: VisitRuleDetailsP | |||
| visit(ruleDetailsUrl(ruleId, options?.tab), { role: options?.role }); | |||
| } | |||
|
|
|||
| export const enablesRule = () => { | |||
| export const clickEnableDisableSwitch = () => { | |||
There was a problem hiding this comment.
Don't we need deterministic behavior here? If the rule was enabled for some reason this will disable it and the rest test logic won't be relevant. Should't some name like enableRuleViaSwitch() or just enableRule() should work better? On top of this the function should contain expectation that the switch in the right position.
There was a problem hiding this comment.
The name definitely is confusing. There's nothing about the existing util logic that's checking the actual status (enabled or disabled). I went ahead and separated it into two utils that check the status appropriately.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @yctercero |
Summary
Addresses #169382, #169274
Wasn't liking the 10s default rule interval in the test. Updated it to
1mthat requires enabling/disabling to kick off a run.