[Investigations] - Timeline tabs file cleanup #179832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
@elasticmachine merge upstream |
|
/ci |
|
A couple of suggestions to consider:
Side note: I know this PR isn't changing any code which is good, but every time I'm looking at the code in these tab files it makes me so depressed. There are so many usages of EUI flyout related components 😢 |
michaelolo24
force-pushed
the
timeline-cleanup
branch
from
27dea69 to
69a467f
Compare
|
@PhilippeOberti Thanks for the review! I updated the file names here: ec3b959
|
|
/ci |
|
@elasticmachine merge upstream |
|
/ci |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
PhilippeOberti
approved these changes
Apr 8, 2024
spong
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Reviewing on behalf of the Security Generative AI team -- just three file changes updating imports from the described file moves. LGTM! Thanks @michaelolo24!
michaelolo24
added a commit
that referenced
this pull request
Apr 26, 2024
## Summary This issue only affects 8.14. Some wrappers were added unnecessarily to the correlations tab in Timeline preventing users from scrolling in this PR: #179832 This PR fixes it by placing the structure more in line with how it was prior here: https://github.com/elastic/kibana/pull/179832/files#diff-a11ba69be2253bc1c3183eb6589e3f30b9ec6e77353364208e906526712562fe The fix: https://github.com/elastic/kibana/assets/17211684/fc288ab8-3cbf-4f4d-8303-4fb5e970dfcd
michaelolo24
added a commit
to michaelolo24/kibana
that referenced
this pull request
Apr 26, 2024
## Summary This issue only affects 8.14. Some wrappers were added unnecessarily to the correlations tab in Timeline preventing users from scrolling in this PR: elastic#179832 This PR fixes it by placing the structure more in line with how it was prior here: https://github.com/elastic/kibana/pull/179832/files#diff-a11ba69be2253bc1c3183eb6589e3f30b9ec6e77353364208e906526712562fe The fix: https://github.com/elastic/kibana/assets/17211684/fc288ab8-3cbf-4f4d-8303-4fb5e970dfcd (cherry picked from commit 11eb39b) # Conflicts: # x-pack/plugins/security_solution/public/timelines/components/timeline/tabs/eql/header/index.tsx # x-pack/plugins/security_solution/public/timelines/components/timeline/tabs/eql/index.tsx
michaelolo24
added a commit
that referenced
this pull request
Apr 26, 2024
# Backport This will backport the following commits from `main` to `8.14`: - [[Bug][Investigations] - Fix eql tab scrolling (#181763)](#181763) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Michael Olorunnisola","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-26T14:55:43Z","message":"[Bug][Investigations] - Fix eql tab scrolling (#181763)\n\n## Summary\r\n\r\nThis issue only affects 8.14.\r\n\r\nSome wrappers were added unnecessarily to the correlations tab in\r\nTimeline preventing users from scrolling in this PR:\r\nhttps://github.com//pull/179832\r\n\r\nThis PR fixes it by placing the structure more in line with how it was\r\nprior here:\r\nhttps://github.com//pull/179832/files#diff-a11ba69be2253bc1c3183eb6589e3f30b9ec6e77353364208e906526712562fe\r\n\r\nThe fix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17211684/fc288ab8-3cbf-4f4d-8303-4fb5e970dfcd","sha":"11eb39b4b6aa9eada1b7c3e63dc1490762d9d8ea","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat Hunting:Investigations","v8.14.0","v8.15.0"],"number":181763,"url":"https://github.com/elastic/kibana/pull/181763","mergeCommit":{"message":"[Bug][Investigations] - Fix eql tab scrolling (#181763)\n\n## Summary\r\n\r\nThis issue only affects 8.14.\r\n\r\nSome wrappers were added unnecessarily to the correlations tab in\r\nTimeline preventing users from scrolling in this PR:\r\nhttps://github.com//pull/179832\r\n\r\nThis PR fixes it by placing the structure more in line with how it was\r\nprior here:\r\nhttps://github.com//pull/179832/files#diff-a11ba69be2253bc1c3183eb6589e3f30b9ec6e77353364208e906526712562fe\r\n\r\nThe fix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17211684/fc288ab8-3cbf-4f4d-8303-4fb5e970dfcd","sha":"11eb39b4b6aa9eada1b7c3e63dc1490762d9d8ea"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181763","number":181763,"mergeCommit":{"message":"[Bug][Investigations] - Fix eql tab scrolling (#181763)\n\n## Summary\r\n\r\nThis issue only affects 8.14.\r\n\r\nSome wrappers were added unnecessarily to the correlations tab in\r\nTimeline preventing users from scrolling in this PR:\r\nhttps://github.com//pull/179832\r\n\r\nThis PR fixes it by placing the structure more in line with how it was\r\nprior here:\r\nhttps://github.com//pull/179832/files#diff-a11ba69be2253bc1c3183eb6589e3f30b9ec6e77353364208e906526712562fe\r\n\r\nThe fix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17211684/fc288ab8-3cbf-4f4d-8303-4fb5e970dfcd","sha":"11eb39b4b6aa9eada1b7c3e63dc1490762d9d8ea"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up a bit of the code around timeline tabs. It de-dupes the layout components and some of the shared functionality between the tabs. I would also like to move the tabs from using the
connectorpattern to usinguseSelector, but that'll be done in a follow up PR. The commit history unfortunately pulls in a bit from this pr, but the 2 commits for the actual files changed in this PR are as follows:(No code changes, just moving files) Moving the tabs into a nested tabs folder: 89fa2d8
(Actual Code Changes) De-duping the shared components: c6eecdb
(No code changes, moving filed and renaming) Removed the
_contentparts of the folder names, and moved thetabs_contentfiles into thetabsfolder: ec3b959