[Bug][Investigations] - Fix eql tab scrolling #181763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelolo24
added
bug
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
michaelolo24
commented
Apr 25, 2024
| </EuiFlexItem> | ||
| </EuiFlexGroup> | ||
| </TabHeaderContainer> | ||
| <EuiFlexGroup |
There was a problem hiding this comment.
Only change was moving the TabHeaderContainer to wrap only the EqlQueryBar
michaelolo24
commented
Apr 25, 2024
| @@ -213,62 +213,58 @@ export const EqlTabContentComponent: React.FC<Props> = ({ | |||
| /> | |||
| <FullWidthFlexGroup> | |||
| <ScrollableFlexItem grow={2}> | |||
| <EuiFlexGroup gutterSize="s" direction="column"> | |||
There was a problem hiding this comment.
Removed unnecessary EuiFlexGroup and EuiFlexItem
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
PhilippeOberti
approved these changes
Apr 26, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
michaelolo24
added a commit
to michaelolo24/kibana
that referenced
this pull request
Apr 26, 2024
## Summary This issue only affects 8.14. Some wrappers were added unnecessarily to the correlations tab in Timeline preventing users from scrolling in this PR: elastic#179832 This PR fixes it by placing the structure more in line with how it was prior here: https://github.com/elastic/kibana/pull/179832/files#diff-a11ba69be2253bc1c3183eb6589e3f30b9ec6e77353364208e906526712562fe The fix: https://github.com/elastic/kibana/assets/17211684/fc288ab8-3cbf-4f4d-8303-4fb5e970dfcd (cherry picked from commit 11eb39b) # Conflicts: # x-pack/plugins/security_solution/public/timelines/components/timeline/tabs/eql/header/index.tsx # x-pack/plugins/security_solution/public/timelines/components/timeline/tabs/eql/index.tsx
michaelolo24
added a commit
that referenced
this pull request
Apr 26, 2024
# Backport This will backport the following commits from `main` to `8.14`: - [[Bug][Investigations] - Fix eql tab scrolling (#181763)](#181763) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Michael Olorunnisola","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-26T14:55:43Z","message":"[Bug][Investigations] - Fix eql tab scrolling (#181763)\n\n## Summary\r\n\r\nThis issue only affects 8.14.\r\n\r\nSome wrappers were added unnecessarily to the correlations tab in\r\nTimeline preventing users from scrolling in this PR:\r\nhttps://github.com//pull/179832\r\n\r\nThis PR fixes it by placing the structure more in line with how it was\r\nprior here:\r\nhttps://github.com//pull/179832/files#diff-a11ba69be2253bc1c3183eb6589e3f30b9ec6e77353364208e906526712562fe\r\n\r\nThe fix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17211684/fc288ab8-3cbf-4f4d-8303-4fb5e970dfcd","sha":"11eb39b4b6aa9eada1b7c3e63dc1490762d9d8ea","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat Hunting:Investigations","v8.14.0","v8.15.0"],"number":181763,"url":"https://github.com/elastic/kibana/pull/181763","mergeCommit":{"message":"[Bug][Investigations] - Fix eql tab scrolling (#181763)\n\n## Summary\r\n\r\nThis issue only affects 8.14.\r\n\r\nSome wrappers were added unnecessarily to the correlations tab in\r\nTimeline preventing users from scrolling in this PR:\r\nhttps://github.com//pull/179832\r\n\r\nThis PR fixes it by placing the structure more in line with how it was\r\nprior here:\r\nhttps://github.com//pull/179832/files#diff-a11ba69be2253bc1c3183eb6589e3f30b9ec6e77353364208e906526712562fe\r\n\r\nThe fix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17211684/fc288ab8-3cbf-4f4d-8303-4fb5e970dfcd","sha":"11eb39b4b6aa9eada1b7c3e63dc1490762d9d8ea"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181763","number":181763,"mergeCommit":{"message":"[Bug][Investigations] - Fix eql tab scrolling (#181763)\n\n## Summary\r\n\r\nThis issue only affects 8.14.\r\n\r\nSome wrappers were added unnecessarily to the correlations tab in\r\nTimeline preventing users from scrolling in this PR:\r\nhttps://github.com//pull/179832\r\n\r\nThis PR fixes it by placing the structure more in line with how it was\r\nprior here:\r\nhttps://github.com//pull/179832/files#diff-a11ba69be2253bc1c3183eb6589e3f30b9ec6e77353364208e906526712562fe\r\n\r\nThe fix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17211684/fc288ab8-3cbf-4f4d-8303-4fb5e970dfcd","sha":"11eb39b4b6aa9eada1b7c3e63dc1490762d9d8ea"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This issue only affects 8.14.
Some wrappers were added unnecessarily to the correlations tab in Timeline preventing users from scrolling in this PR: #179832
This PR fixes it by placing the structure more in line with how it was prior here: https://github.com/elastic/kibana/pull/179832/files#diff-a11ba69be2253bc1c3183eb6589e3f30b9ec6e77353364208e906526712562fe
The fix:
Screen.Recording.2024-04-25.at.2.34.33.PM.mov