Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] Fix create runtime field functional test on MKI #181101

Merged
merged 7 commits into from
Apr 23, 2024
Merged

[data views] Fix create runtime field functional test on MKI #181101

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d7807d1
better way to set field value
mattkime Apr 18, 2024
0faa6c4
fix selecting composite
mattkime Apr 18, 2024
5c1438f
Merge branch 'main' into fix_create_runtime_field_test_on_mki
mattkime Apr 19, 2024
ab5dc59
simplify code, add retry
mattkime Apr 19, 2024
7518212
Merge branch 'main' into fix_create_runtime_field_test_on_mki
mattkime Apr 21, 2024
aca34ca
place retry logic into setFieldType fn
mattkime Apr 22, 2024
f55b604
Merge branch 'main' into fix_create_runtime_field_test_on_mki
mattkime Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions test/functional/page_objects/settings_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,7 @@ export class SettingsPageObject extends FtrService {
) {
await this.clickAddField();
await this.setFieldName(name);
await this.setFieldTypeComposite();
await this.setFieldType('Composite');
await this.setCompositeScript(script);
if (subfieldCount > 0) {
await this.testSubjects.find(`typeField_${subfieldCount - 1}`);
Expand Down Expand Up @@ -874,14 +874,13 @@ export class SettingsPageObject extends FtrService {
}

async setFieldType(type: string) {
const typeFieldDataTestSubj = 'typeField';
this.log.debug('set type = ' + type);
await this.comboBox.set('typeField', type);
}

async setFieldTypeComposite() {
this.log.debug('set type = Composite');
await this.testSubjects.setValue('typeField', 'Composite');
await this.browser.pressKeys(this.browser.keys.RETURN);
await this.retry.try(async () => {
await this.comboBox.set(typeFieldDataTestSubj, type);
const comboBox = await this.testSubjects.find(typeFieldDataTestSubj);
expect(await this.comboBox.isOptionSelected(comboBox, type)).to.be(true);
});
}

async setFieldScript(script: string) {
Expand Down