Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] Fix create runtime field functional test on MKI #181101

Merged
merged 7 commits into from
Apr 23, 2024

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Apr 18, 2024

Summary

Addresses flaky test that fails to set the runtime field type to composite. Passed a 50x run on the flaky test runner - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5724

Attempts to avoid this happening -
image (4)

@mattkime mattkime changed the title better way to set field value [data views] Fix create runtime field functional test on MKI Apr 18, 2024
@mattkime mattkime self-assigned this Apr 19, 2024
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. release_note:skip Skip the PR/issue when compiling release notes labels Apr 19, 2024
@mattkime mattkime marked this pull request as ready for review April 19, 2024 22:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Comment on lines 791 to 795
await this.retry.try(async () => {
await this.setFieldType('Composite');
const comboBox = await this.testSubjects.find('typeField');
expect(await this.comboBox.isOptionSelected(comboBox, 'Composite')).to.be(true);
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about moving this check and retry logic into the this.setFieldType method? That way the stability fix would apply to all field type selections and not just to Composite.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mattkime

@mattkime mattkime merged commit 67bc795 into elastic:main Apr 23, 2024
17 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants