-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data views] Fix create runtime field functional test on MKI #181101
[data views] Fix create runtime field functional test on MKI #181101
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
await this.retry.try(async () => { | ||
await this.setFieldType('Composite'); | ||
const comboBox = await this.testSubjects.find('typeField'); | ||
expect(await this.comboBox.isOptionSelected(comboBox, 'Composite')).to.be(true); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about moving this check and retry logic into the this.setFieldType
method? That way the stability fix would apply to all field type selections and not just to Composite
.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @mattkime |
Summary
Addresses flaky test that fails to set the runtime field type to composite. Passed a 50x run on the flaky test runner - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5724
Attempts to avoid this happening -