Minimize shared-common everywhere

[afharo]

Summary

At the moment, our package generator creates all packages with the type shared-common. This means that we cannot enforce boundaries between server-side-only code and the browser, and vice-versa.

• I started fixing packages/core/*
• It took me to fixing src/core/ type to be identified by the plugin pattern (public and server directories) vs. a package (either common, or single-scoped)
• Unsurprisingly, this extended to packages importing core packages hitting the boundaries eslint rules. And other packages importing the latter.
• Also a bunch of common logic that shouldn't be so common 🙃

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[afharo]

/ci

[afharo]

/ci

[afharo]

/ci

[elasticmachine]

💔 Build Failed

• Buildkite Build
• Commit: afabd06

Failed CI Steps

• Quick Checks

History

• 💔 Build #222235 failed 9592b321179d7c96a061c5a5831f314b8d879cc2

cc @afharo

[afharo]

/ci

[tiansivive]

LGTM from Security Entity Analytics

[dmlemeshko]

appex-qa changes LGTM

[MadameSheema]

Thanks!! :)

[afharo]

Thank you all for approving!

Updating from main (hopefully) one last time! And enabling auto-merge.

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 1d5c572

Failed CI Steps

• Jest Integration Tests #2
• Jest Integration Tests #6

Test Failures

• [job] [logs] Jest Integration Tests #6 / telemetry tasks endpoint-meta-telemetry should execute when scheduled

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
esUiShared	238	241	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/server-route-repository-utils	-	5	+5
@kbn/synthetics-e2e	-	32	+32
total			+37

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
@kbn/synthetics-e2e	-	2	+2

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
synthetics	0	1	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
esUiShared	158.1KB	158.9KB	+799.0B

Unknown metric groups

API count

id	before	after	diff
@kbn/server-route-repository-utils	-	5	+5
@kbn/synthetics-e2e	-	32	+32
total			+37

ESLint disabled in files

id	before	after	diff
@kbn/apm-ftr-e2e	-	2	+2
@kbn/synthetics-e2e	-	1	+1
@kbn/test-suites-serverless	-	1	+1
@kbn/test-suites-src	-	6	+6
@kbn/test-suites-xpack	-	23	+23
apm	14	12	-2
synthetics	7	6	-1
total			+30

ESLint disabled line counts

id	before	after	diff
@kbn/apm-ftr-e2e	-	3	+3
@kbn/observability-onboarding-e2e	-	3	+3
@kbn/synthetics-e2e	-	20	+20
@kbn/test-suites-serverless	-	2	+2
@kbn/test-suites-src	-	43	+43
@kbn/test-suites-xpack	-	705	+705
@kbn/test-suites-xpack-performance	-	2	+2
apm	73	70	-3
observabilityOnboarding	15	12	-3
synthetics	84	64	-20
total			+752

References to deprecated APIs

id	before	after	diff
@kbn/test-suites-xpack	-	2	+2

Total ESLint disabled count

id	before	after	diff
@kbn/apm-ftr-e2e	-	5	+5
@kbn/observability-onboarding-e2e	-	3	+3
@kbn/synthetics-e2e	-	21	+21
@kbn/test-suites-serverless	-	3	+3
@kbn/test-suites-src	-	49	+49
@kbn/test-suites-xpack	-	728	+728
@kbn/test-suites-xpack-performance	-	2	+2
apm	87	82	-5
observabilityOnboarding	19	16	-3
synthetics	91	70	-21
total			+782

History

• 💚 Build #224393 succeeded 313612a
• 💔 Build #224303 failed a5854ae
• 💔 Build #224222 failed 3746376
• 💔 Build #224144 failed bbf3750
• 💔 Build #224056 failed 89d46ae
• 💔 Build #223916 failed 4f0d7d4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

[TinaHeiligers]

LGTM