Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize shared-common everywhere #188606

Merged
merged 21 commits into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ae1b8ec
Minimize `shared-common` everywhere
afharo Jul 17, 2024
92c704b
Fix packages types
afharo Jul 18, 2024
2f2c69f
Fix more packages and plugins
afharo Jul 18, 2024
0ed5298
Missing `case core`
afharo Jul 18, 2024
afabd06
Fix tsconfig.json
afharo Jul 18, 2024
73842e9
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Jul 18, 2024
73b151c
Merge branch 'main' of github.com:elastic/kibana into shared-common-e…
afharo Jul 22, 2024
1496bc6
Merge branch 'main' of github.com:elastic/kibana into shared-common-e…
afharo Jul 22, 2024
10f4b1f
Flag FTR packages and suites as `test-helper`
afharo Jul 25, 2024
e151903
Merge branch 'main' of github.com:elastic/kibana into shared-common-e…
afharo Jul 25, 2024
cdfaf19
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Jul 25, 2024
4f0d7d4
Fix CI errors
afharo Jul 25, 2024
9b97f3b
Convert `e2e` dirs to packages
afharo Jul 26, 2024
89d46ae
Merge branch 'main' of github.com:elastic/kibana into shared-common-e…
afharo Jul 26, 2024
6acbde0
Fix types
afharo Jul 26, 2024
c80f20b
Merge branch 'main' of github.com:elastic/kibana into shared-common-e…
afharo Jul 26, 2024
bbf3750
[CI] Auto-commit changed files from 'yarn openapi:bundle:endpoint-man…
kibanamachine Jul 26, 2024
3746376
Merge branch 'main' of github.com:elastic/kibana into shared-common-e…
afharo Jul 27, 2024
a5854ae
Merge branch 'main' into shared-common-everywhere
afharo Jul 29, 2024
313612a
Merge branch 'main' of github.com:elastic/kibana into shared-common-e…
afharo Jul 29, 2024
1d5c572
Merge branch 'main' into shared-common-everywhere
afharo Jul 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 8 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ test/analytics/plugins/analytics_plugin_a @elastic/kibana-core
packages/kbn-apm-config-loader @elastic/kibana-core @vigneshshanmugam
x-pack/plugins/observability_solution/apm_data_access @elastic/obs-knowledge-team @elastic/obs-ux-infra_services-team
packages/kbn-apm-data-view @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/apm/ftr_e2e @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/apm @elastic/obs-ux-infra_services-team
packages/kbn-apm-synthtrace @elastic/obs-ux-infra_services-team @elastic/obs-ux-logs-team
packages/kbn-apm-synthtrace-client @elastic/obs-ux-infra_services-team @elastic/obs-ux-logs-team
Expand Down Expand Up @@ -622,6 +623,7 @@ x-pack/packages/observability/alerting_test_data @elastic/obs-ux-management-team
x-pack/test/cases_api_integration/common/plugins/observability @elastic/response-ops
x-pack/packages/observability/get_padded_alert_time_range_util @elastic/obs-ux-management-team
x-pack/plugins/observability_solution/observability_logs_explorer @elastic/obs-ux-logs-team
x-pack/plugins/observability_solution/observability_onboarding/e2e @elastic/obs-ux-logs-team @elastic/obs-ux-onboarding-team
x-pack/plugins/observability_solution/observability_onboarding @elastic/obs-ux-logs-team @elastic/obs-ux-onboarding-team
x-pack/plugins/observability_solution/observability @elastic/obs-ux-management-team
x-pack/plugins/observability_solution/observability_shared @elastic/observability-ui
Expand Down Expand Up @@ -772,6 +774,7 @@ packages/kbn-securitysolution-t-grid @elastic/security-detection-engine
packages/kbn-securitysolution-utils @elastic/security-detection-engine
packages/kbn-server-http-tools @elastic/kibana-core
packages/kbn-server-route-repository @elastic/obs-knowledge-team
packages/kbn-server-route-repository-utils @elastic/obs-knowledge-team
x-pack/plugins/serverless @elastic/appex-sharedux
packages/serverless/settings/common @elastic/appex-sharedux @elastic/kibana-management
x-pack/plugins/serverless_observability @elastic/obs-ux-management-team
Expand Down Expand Up @@ -855,6 +858,7 @@ test/server_integration/plugins/status_plugin_b @elastic/kibana-core
packages/kbn-std @elastic/kibana-core
packages/kbn-stdio-dev-helpers @elastic/kibana-operations
packages/kbn-storybook @elastic/kibana-operations
x-pack/plugins/observability_solution/synthetics/e2e @elastic/obs-ux-management-team
x-pack/plugins/observability_solution/synthetics @elastic/obs-ux-management-team
x-pack/test/alerting_api_integration/common/plugins/task_manager_fixture @elastic/response-ops
x-pack/test/plugin_api_perf/plugins/task_manager_performance @elastic/response-ops
Expand All @@ -870,6 +874,10 @@ packages/kbn-test-eui-helpers @elastic/kibana-visualizations
x-pack/test/licensing_plugin/plugins/test_feature_usage @elastic/kibana-security
packages/kbn-test-jest-helpers @elastic/kibana-operations @elastic/appex-qa
packages/kbn-test-subj-selector @elastic/kibana-operations @elastic/appex-qa
x-pack/test_serverless @elastic/appex-qa
test @elastic/appex-qa
x-pack/test @elastic/appex-qa
x-pack/performance @elastic/appex-qa
x-pack/examples/testing_embedded_lens @elastic/kibana-visualizations
packages/kbn-text-based-editor @elastic/kibana-esql
x-pack/examples/third_party_lens_navigation_prompt @elastic/kibana-visualizations
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
PanelPackage,
PresentationContainer,
} from '@kbn/presentation-containers';
import { Reference } from '@kbn/content-management-utils';
import type { Reference } from '@kbn/content-management-utils';
import { BehaviorSubject, first, merge } from 'rxjs';
import { PublishingSubject } from '@kbn/presentation-publishing';
import { omit } from 'lodash';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import { EuiFlexGroup, EuiFlexItem } from '@elastic/eui';
import { css } from '@emotion/react';
import { Reference } from '@kbn/content-management-utils';
import type { Reference } from '@kbn/content-management-utils';
import { CoreStart } from '@kbn/core-lifecycle-browser';
import { DataView } from '@kbn/data-views-plugin/common';
import { DATA_VIEW_SAVED_OBJECT_TYPE } from '@kbn/data-views-plugin/public';
Expand Down
8 changes: 8 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -787,6 +787,7 @@
"@kbn/securitysolution-utils": "link:packages/kbn-securitysolution-utils",
"@kbn/server-http-tools": "link:packages/kbn-server-http-tools",
"@kbn/server-route-repository": "link:packages/kbn-server-route-repository",
"@kbn/server-route-repository-utils": "link:packages/kbn-server-route-repository-utils",
"@kbn/serverless": "link:x-pack/plugins/serverless",
"@kbn/serverless-common-settings": "link:packages/serverless/settings/common",
"@kbn/serverless-observability": "link:x-pack/plugins/serverless_observability",
Expand Down Expand Up @@ -1278,6 +1279,7 @@
"@kbn/ambient-ftr-types": "link:packages/kbn-ambient-ftr-types",
"@kbn/ambient-storybook-types": "link:packages/kbn-ambient-storybook-types",
"@kbn/ambient-ui-types": "link:packages/kbn-ambient-ui-types",
"@kbn/apm-ftr-e2e": "link:x-pack/plugins/observability_solution/apm/ftr_e2e",
"@kbn/apm-synthtrace": "link:packages/kbn-apm-synthtrace",
"@kbn/apm-synthtrace-client": "link:packages/kbn-apm-synthtrace-client",
"@kbn/axe-config": "link:packages/kbn-axe-config",
Expand Down Expand Up @@ -1383,6 +1385,7 @@
"@kbn/management-storybook-config": "link:packages/kbn-management/storybook/config",
"@kbn/mock-idp-plugin": "link:packages/kbn-mock-idp-plugin",
"@kbn/mock-idp-utils": "link:packages/kbn-mock-idp-utils",
"@kbn/observability-onboarding-e2e": "link:x-pack/plugins/observability_solution/observability_onboarding/e2e",
"@kbn/openapi-bundler": "link:packages/kbn-openapi-bundler",
"@kbn/openapi-generator": "link:packages/kbn-openapi-generator",
"@kbn/optimizer": "link:packages/kbn-optimizer",
Expand All @@ -1405,11 +1408,16 @@
"@kbn/spec-to-console": "link:packages/kbn-spec-to-console",
"@kbn/stdio-dev-helpers": "link:packages/kbn-stdio-dev-helpers",
"@kbn/storybook": "link:packages/kbn-storybook",
"@kbn/synthetics-e2e": "link:x-pack/plugins/observability_solution/synthetics/e2e",
"@kbn/telemetry-tools": "link:packages/kbn-telemetry-tools",
"@kbn/test": "link:packages/kbn-test",
"@kbn/test-eui-helpers": "link:packages/kbn-test-eui-helpers",
"@kbn/test-jest-helpers": "link:packages/kbn-test-jest-helpers",
"@kbn/test-subj-selector": "link:packages/kbn-test-subj-selector",
"@kbn/test-suites-serverless": "link:x-pack/test_serverless",
"@kbn/test-suites-src": "link:test",
"@kbn/test-suites-xpack": "link:x-pack/test",
"@kbn/test-suites-xpack-performance": "link:x-pack/performance",
"@kbn/tooling-log": "link:packages/kbn-tooling-log",
"@kbn/ts-projects": "link:packages/kbn-ts-projects",
"@kbn/ts-type-check-cli": "link:packages/kbn-ts-type-check-cli",
Expand Down
2 changes: 1 addition & 1 deletion packages/content-management/content_editor/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/content-management-content-editor",
"owner": "@elastic/appex-sharedux",
}
2 changes: 1 addition & 1 deletion packages/content-management/user_profiles/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/content-management-user-profiles",
"owner": "@elastic/appex-sharedux"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-analytics-browser-internal",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-analytics-browser-mocks",
"devOnly": true,
"owner": "@elastic/kibana-core"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-analytics-browser",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-analytics-server-internal",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-analytics-server-mocks",
"devOnly": true,
"owner": "@elastic/kibana-core"
Expand Down
2 changes: 1 addition & 1 deletion packages/core/analytics/core-analytics-server/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-analytics-server",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-application-browser-internal",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-application-browser-mocks",
"devOnly": true,
"owner": "@elastic/kibana-core"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-application-browser",
"owner": "@elastic/kibana-core"
}
2 changes: 1 addition & 1 deletion packages/core/apps/core-apps-browser-internal/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-apps-browser-internal",
"owner": "@elastic/kibana-core"
}
2 changes: 1 addition & 1 deletion packages/core/apps/core-apps-browser-mocks/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-apps-browser-mocks",
"devOnly": true,
"owner": "@elastic/kibana-core"
Expand Down
2 changes: 1 addition & 1 deletion packages/core/apps/core-apps-server-internal/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-apps-server-internal",
"owner": "@elastic/kibana-core"
}
2 changes: 1 addition & 1 deletion packages/core/base/core-base-browser-internal/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-base-browser-internal",
"owner": "@elastic/kibana-core"
}
2 changes: 1 addition & 1 deletion packages/core/base/core-base-browser-mocks/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-base-browser-mocks",
"devOnly": true,
"owner": "@elastic/kibana-core"
Expand Down
2 changes: 1 addition & 1 deletion packages/core/base/core-base-server-internal/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-base-server-internal",
"owner": "@elastic/kibana-core"
}
2 changes: 1 addition & 1 deletion packages/core/base/core-base-server-mocks/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-base-server-mocks",
"devOnly": true,
"owner": "@elastic/kibana-core"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-capabilities-browser-internal",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-capabilities-browser-mocks",
"devOnly": true,
"owner": "@elastic/kibana-core"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-capabilities-server-internal",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-capabilities-server-mocks",
"devOnly": true,
"owner": "@elastic/kibana-core"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-capabilities-server",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-chrome-browser-internal",
"owner": "@elastic/appex-sharedux"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-chrome-browser-mocks",
"devOnly": true,
"owner": "@elastic/appex-sharedux"
Expand Down
2 changes: 1 addition & 1 deletion packages/core/chrome/core-chrome-browser/kibana.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-chrome-browser",
"owner": "@elastic/appex-sharedux"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-config-server-internal",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-custom-branding-browser-internal",
"owner": "@elastic/appex-sharedux",
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-custom-branding-browser-mocks",
"owner": "@elastic/appex-sharedux",
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-custom-branding-browser",
"owner": "@elastic/appex-sharedux",
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-custom-branding-server-internal",
"owner": "@elastic/appex-sharedux",
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-custom-branding-server-mocks",
"owner": "@elastic/appex-sharedux",
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-custom-branding-server",
"owner": "@elastic/appex-sharedux",
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-deprecations-browser-internal",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-deprecations-browser-mocks",
"devOnly": true,
"owner": "@elastic/kibana-core"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-deprecations-browser",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-deprecations-server-internal",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-deprecations-server-mocks",
"devOnly": true,
"owner": "@elastic/kibana-core"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-server",
"id": "@kbn/core-deprecations-server",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-doc-links-browser-internal",
"owner": "@elastic/kibana-core"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-doc-links-browser-mocks",
"devOnly": true,
"owner": "@elastic/kibana-core"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "shared-common",
"type": "shared-browser",
"id": "@kbn/core-doc-links-browser",
"owner": "@elastic/kibana-core"
}
Loading