Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Set DataTable row density to expanded #191138

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented Aug 22, 2024

Summary

Due to a recent change on the UnifiedDataTable component, the density was set to default to compact. This PR overrides this property to expanded in order to keep consistency with the Design specs.

Screenshot

Before PR changes:

image

After PR changes:

image

Design spec

image

@opauloh opauloh requested a review from a team as a code owner August 22, 2024 20:41
@opauloh opauloh added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.16.0 labels Aug 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #20 / console app console vector tiles response validation "before all" hook for "should validate response"
  • [job] [logs] FTR Configs #48 / lens app - group 2 lens fields list tests form-based datasource should show stats for a keyword runtime field
  • [job] [logs] FTR Configs #88 / Visualizations - Group 3 lens app - TSVB Open in Lens Dashboard to TSVB to Lens should convert a by reference TSVB viz to a Lens viz

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 480.2KB 480.2KB +25.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@opauloh opauloh merged commit c95f01b into elastic:main Aug 23, 2024
24 checks passed
@opauloh opauloh deleted the quick-wins/csp-datatable-row-density branch August 23, 2024 01:17
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants