[FTR][Ownership] Assign guided_onboarding, etc #198044
Conversation
…anch 'main' of github.com:elastic/kibana
Assigned guided_onboarding due to https://github.com/elastic/kibana/blob/main/api_docs/guided_onboarding.mdx#L18 - It says "Contact @elastic/appex-sharedux for questions regarding this plugin." Assigned shared_ux due to the name Assigned telemetry due to https://github.com/elastic/kibana/blob/main/api_docs/telemetry.mdx#L18 - It says "Contact @elastic/kibana-core for questions regarding this plugin." Assigned response_stream due to https://github.com/elastic/kibana/blob/main/examples/response_stream/kibana.jsonc#L4 Assigned advanced_settings due to https://github.com/elastic/kibana/blob/main/api_docs/advanced_settings.mdx#L18 - It says "Contact @elastic/appex-sharedux for questions regarding this plugin." Assigned upgrade_assistant due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/upgrade_assistant/kibana.jsonc#L4 Assigned functional_cors due to https://github.com/elastic/kibana/blob/main/x-pack/test/functional_cors/plugins/kibana_cors_test/kibana.jsonc#L4 Assigned x-pack/test/functional_cors due to https://github.com/elastic/kibana/blob/main/x-pack/test/functional_cors/plugins/kibana_cors_test/kibana.jsonc#L4 Assigned ingest_pipelines due to https://github.com/elastic/kibana/blob/main/api_docs/ingest_pipelines.mdx#L18 - It says "Contact @elastic/kibana-management for questions regarding this plugin." Assigned disable_ems due to git blame Assigned cross_cluster_replication due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/cross_cluster_replication/kibana.jsonc#L5 Contributes to: elastic#192979
wayneseymour
added
release_note:skip
.github/CODEOWNERS
Outdated
| @@ -1988,6 +1994,9 @@ x-pack/test/profiling_api_integration @elastic/obs-ux-infra_services-team | |||
| x-pack/plugins/observability_solution/observability_shared/public/components/profiling @elastic/obs-ux-infra_services-team | |||
|
|
|||
| # Shared UX | |||
| /test/api_integration/apis/guided_onboarding @elastic/appex-sharedux | |||
| /test/plugin_functional/test_suites/shared_ux @elastic/appex-sharedux | |||
| /x-pack/test/functional/apps/advanced_settings @elastic/appex-sharedux | |||
There was a problem hiding this comment.
You could also add @elastic/kibana-management here as we co-own the Advanced settings plugin along with SharedUX (see src/plugins/advanced_settings/kibana.jsonc).
.github/CODEOWNERS
Outdated
| @@ -1438,7 +1440,7 @@ x-pack/test/**/deployment_agnostic/ @elastic/appex-qa #temporarily to monitor te | |||
| # AppEx Platform Services Security | |||
| //x-pack/test_serverless/api_integration/test_suites/common/security_response_headers.ts @elastic/kibana-security | |||
| /x-pack/test/api_integration/apis/es @elastic/kibana-security | |||
|
|
|||
| /x-pack/test/functional_cors @elastic/kibana-security | |||
There was a problem hiding this comment.
It looks like the Core team created these tests (#84316). @elastic/kibana-core would you prefer to retain ownership or transfer ownership to us? We're fine taking ownership if that is your preference.
@wayneseymour there is an existing directive for x-pack/test/functional_cors/plugins/kibana_cors_test that is assigned to us, which should be removed, as the directive you're adding is broader scope. FWIW we're not sure how we got ownership of this one.
This brings up the point that directives will override each other and there is no feasible way to test for this. So when adding new directives, it's important to check for any overlapping directives to remove redundancies or unwanted overrides.
There was a problem hiding this comment.
Great point kind sir, great point. I'll do my best to double check!
There was a problem hiding this comment.
we're not sure how we got ownership of this one.
Looks like it was assigned here: #148130
There are too many files in that pr to hunt down without proper provocation.
That said, if that all checks out, this means that x-pack/test/functional_cors/plugins/kibana_cors_test @elastic/kibana-security is a default assignment.
IIRC that means this is a default assignment (assigned via a kibana.jsonc with kbn-generate), that can be overriden by re-assigning lower in the codeowners file.
There was a problem hiding this comment.
Dropping the disputed line for now. Will follow up in another pr later
There was a problem hiding this comment.
We own the implementation and the jest tests https://github.com/elastic/kibana/blob/dont-migrate-partial-docs/packages/core/http/core-http-server-internal/src/http_config.test.ts#L430 so I think it makes sense for Core to own this E2E test too.
|
@elasticmachine merge upstream |
wayneseymour
dismissed
jeramysoucy’s stale review
Dropping the disputed line for now. Will follow up in another pr later
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
|
@elasticmachine merge upstream |
Assignment Reasons
Assigned guided_onboarding due to https://github.com/elastic/kibana/blob/main/api_docs/guided_onboarding.mdx#L18
Assigned shared_ux due to the name
Assigned telemetry due to https://github.com/elastic/kibana/blob/main/api_docs/telemetry.mdx#L18
Assigned response_stream due to https://github.com/elastic/kibana/blob/main/examples/response_stream/kibana.jsonc#L4
Assigned advanced_settings due to https://github.com/elastic/kibana/blob/main/api_docs/advanced_settings.mdx#L18
Assigned upgrade_assistant due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/upgrade_assistant/kibana.jsonc#L4
Assigned functional_cors due to https://github.com/elastic/kibana/blob/main/x-pack/test/functional_cors/plugins/kibana_cors_test/kibana.jsonc#L4
Assigned x-pack/test/functional_cors due to https://github.com/elastic/kibana/blob/main/x-pack/test/functional_cors/plugins/kibana_cors_test/kibana.jsonc#L4
Assigned ingest_pipelines due to https://github.com/elastic/kibana/blob/main/api_docs/ingest_pipelines.mdx#L18
Assigned disable_ems due to git blame
Assigned cross_cluster_replication due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/cross_cluster_replication/kibana.jsonc#L5
Contributes to: #192979