Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTR][Ownership] Assign guided_onboarding, etc #198044

Merged
merged 14 commits into from
Nov 5, 2024
Merged

[FTR][Ownership] Assign guided_onboarding, etc #198044

Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
14468f3
Code owners check - match files and directories
pheyos Oct 25, 2024
63e1fc5
Merge branch 'adjust_co_check_script' of github.com:pheyos/kibana; br…
wayneseymour Oct 25, 2024
ddc568f
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 25, 2024
d0ee568
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 25, 2024
53d066b
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 28, 2024
c5f5d67
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 28, 2024
78742b9
Merge branch 'main' of github.com:elastic/kibana
wayneseymour Oct 28, 2024
e9b9006
Merge branch 'main' of github.com:elastic/kibana into assign-guided-o…
wayneseymour Oct 28, 2024
f179f58
[FTR][Ownership] Assign guided_onboarding, etc
wayneseymour Oct 28, 2024
3362d8d
Merge branch 'main' of github.com:elastic/kibana into assign-guided-o…
wayneseymour Oct 31, 2024
88cbe04
add entry per cr
wayneseymour Oct 31, 2024
e0f7eee
Merge branch 'main' into assign-guided-onboarding-etc
elasticmachine Nov 4, 2024
d484448
drop disputed for now
wayneseymour Nov 4, 2024
aa2281d
Merge branch 'main' into assign-guided-onboarding-etc
elasticmachine Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -1291,6 +1291,7 @@ x-pack/test_serverless/**/test_suites/observability/ai_assistant @elastic/obs-ai
### END Observability Plugins

# Presentation
/x-pack/test/disable_ems @elastic/kibana-presentation
/x-pack/test/functional/apps/dashboard @elastic/kibana-presentation
/x-pack/test/accessibility/apps/group3/maps.ts @elastic/kibana-presentation
/x-pack/test/accessibility/apps/group1/dashboard_panel_options.ts @elastic/kibana-presentation
Expand Down Expand Up @@ -1325,6 +1326,7 @@ x-pack/test_serverless/**/test_suites/observability/ai_assistant @elastic/obs-ai
/x-pack/test/api_integration/services/ml.ts @elastic/ml-ui

# Additional plugins and packages maintained by the ML team.
/test/examples/response_stream @elastic/ml-ui
/x-pack/test/accessibility/apps/group2/transform.ts @elastic/ml-ui
/x-pack/test/api_integration/apis/aiops/ @elastic/ml-ui
/x-pack/test/api_integration/apis/transform/ @elastic/ml-ui
Expand Down Expand Up @@ -1455,7 +1457,7 @@ x-pack/test/**/deployment_agnostic/ @elastic/appex-qa #temporarily to monitor te
# AppEx Platform Services Security
//x-pack/test_serverless/api_integration/test_suites/common/security_response_headers.ts @elastic/kibana-security
/x-pack/test/api_integration/apis/es @elastic/kibana-security

/x-pack/test/functional_cors @elastic/kibana-security
Copy link
Contributor

@jeramysoucy jeramysoucy Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the Core team created these tests (#84316). @elastic/kibana-core would you prefer to retain ownership or transfer ownership to us? We're fine taking ownership if that is your preference.

@wayneseymour there is an existing directive for x-pack/test/functional_cors/plugins/kibana_cors_test that is assigned to us, which should be removed, as the directive you're adding is broader scope. FWIW we're not sure how we got ownership of this one.

This brings up the point that directives will override each other and there is no feasible way to test for this. So when adding new directives, it's important to check for any overlapping directives to remove redundancies or unwanted overrides.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point kind sir, great point. I'll do my best to double check!

Copy link
Member Author

@wayneseymour wayneseymour Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're not sure how we got ownership of this one.

Looks like it was assigned here: #148130
There are too many files in that pr to hunt down without proper provocation.
That said, if that all checks out, this means that x-pack/test/functional_cors/plugins/kibana_cors_test @elastic/kibana-security is a default assignment.
IIRC that means this is a default assignment (assigned via a kibana.jsonc with kbn-generate), that can be overriden by re-assigning lower in the codeowners file.

Copy link
Member Author

@wayneseymour wayneseymour Nov 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the disputed line for now. Will follow up in another pr later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We own the implementation and the jest tests https://github.com/elastic/kibana/blob/dont-migrate-partial-docs/packages/core/http/core-http-server-internal/src/http_config.test.ts#L430 so I think it makes sense for Core to own this E2E test too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rudolf!

/x-pack/test/api_integration/apis/features @elastic/kibana-security

# Kibana Telemetry
Expand Down Expand Up @@ -1569,14 +1571,18 @@ x-pack/test/api_integration/apis/management/index_management/inference_endpoints
/x-pack/test/functional_search/ @elastic/search-kibana

# Management Experience - Deployment Management
/x-pack/test/api_integration/services/index_management.ts @elastic/kibana-management
/x-pack/test/functional/apps/license_management @elastic/kibana-management
/x-pack/test/functional/apps/painless_lab @elastic/kibana-management
/x-pack/test/functional/apps/management @elastic/kibana-management
/x-pack/test/api_integration/services/index_management.ts @elastic/kibana-management
/x-pack/test/functional/services/grok_debugger.js @elastic/kibana-management
/x-pack/test/functional/apps/cross_cluster_replication @elastic/kibana-management
/x-pack/test/functional/apps/grok_debugger @elastic/kibana-management
/x-pack/test/functional/apps/index_lifecycle_management @elastic/kibana-management
/x-pack/test/functional/apps/index_management @elastic/kibana-management
/x-pack/test/functional/apps/ingest_pipelines @elastic/kibana-management
/x-pack/test/functional/apps/upgrade_assistant @elastic/kibana-management
/x-pack/test/api_integration/services/ingest_pipelines @elastic/kibana-management
/x-pack/test/functional/apps/watcher @elastic/kibana-management
/x-pack/test/api_integration/apis/watcher @elastic/kibana-management
Expand Down Expand Up @@ -2013,6 +2019,9 @@ x-pack/test/profiling_api_integration @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/observability_shared/public/components/profiling @elastic/obs-ux-infra_services-team

# Shared UX
/test/api_integration/apis/guided_onboarding @elastic/appex-sharedux
/test/plugin_functional/test_suites/shared_ux @elastic/appex-sharedux
/x-pack/test/functional/apps/advanced_settings @elastic/appex-sharedux @elastic/kibana-management
/test/examples/content_management @elastic/appex-sharedux
/test/plugin_functional/plugins/kbn_sample_panel_action @elastic/appex-sharedux
/test/functional/apps/kibana_overview @elastic/appex-sharedux
Expand Down