Clean code related to savedObjectClientContrat that wasn't being used #200629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesuswr
added
Feature:Saved Objects
release_note:skip
TinaHeiligers
approved these changes
Nov 18, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
cc @jesuswr |
jesuswr
added
the
Team:SharedUX
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11911408070 |
jesuswr
deleted the
remove-not-used-code-saved-object-client-contract
branch
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
jesuswr
removed
the
backport:prev-minor
jesuswr
added
backport:prev-minor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11917156176 |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11917156169 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
jesuswr
removed
the
backport:prev-minor
jesuswr
added
the
backport:prev-minor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11917306887 |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11917306793 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jesuswr
added a commit
to jesuswr/kibana
that referenced
this pull request
Nov 20, 2024
…elastic#200629) ## Summary Resolves: elastic#197216 Removed all code that wasn't being used in https://github.com/elastic/kibana/tree/main/src/plugins/saved_objects/public. Didn't remove the actual client since it's still being used here: https://github.com/elastic/kibana/blob/dbab2214e9451d3a262007660cc0b7cdcea5307c/src/plugins/home/public/application/kibana_services.ts#L46-L48 Checked everything with `node scripts/type_check` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit d900299) # Conflicts: # x-pack/plugins/translations/translations/zh-CN.json
jesuswr
added a commit
that referenced
this pull request
Nov 20, 2024
…g used (#200629) (#200859) # Backport This will backport the following commits from `main` to `8.x`: - [Clean code related to savedObjectClientContrat that wasn't being used (#200629)](#200629) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jesus Wahrman","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-19T10:46:18Z","message":"Clean code related to savedObjectClientContrat that wasn't being used (#200629)\n\n## Summary\r\n\r\nResolves: https://github.com/elastic/kibana/issues/197216\r\n\r\nRemoved all code that wasn't being used in\r\nhttps://github.com/elastic/kibana/tree/main/src/plugins/saved_objects/public.\r\nDidn't remove the actual client since it's still being used here:\r\nhttps://github.com/elastic/kibana/blob/dbab2214e9451d3a262007660cc0b7cdcea5307c/src/plugins/home/public/application/kibana_services.ts#L46-L48\r\n\r\nChecked everything with `node scripts/type_check`\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"d900299e731fccaca5c70889371a2760da794da1","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Saved Objects","release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor"],"number":200629,"url":"https://github.com/elastic/kibana/pull/200629","mergeCommit":{"message":"Clean code related to savedObjectClientContrat that wasn't being used (#200629)\n\n## Summary\r\n\r\nResolves: https://github.com/elastic/kibana/issues/197216\r\n\r\nRemoved all code that wasn't being used in\r\nhttps://github.com/elastic/kibana/tree/main/src/plugins/saved_objects/public.\r\nDidn't remove the actual client since it's still being used here:\r\nhttps://github.com/elastic/kibana/blob/dbab2214e9451d3a262007660cc0b7cdcea5307c/src/plugins/home/public/application/kibana_services.ts#L46-L48\r\n\r\nChecked everything with `node scripts/type_check`\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"d900299e731fccaca5c70889371a2760da794da1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200629","number":200629,"mergeCommit":{"message":"Clean code related to savedObjectClientContrat that wasn't being used (#200629)\n\n## Summary\r\n\r\nResolves: https://github.com/elastic/kibana/issues/197216\r\n\r\nRemoved all code that wasn't being used in\r\nhttps://github.com/elastic/kibana/tree/main/src/plugins/saved_objects/public.\r\nDidn't remove the actual client since it's still being used here:\r\nhttps://github.com/elastic/kibana/blob/dbab2214e9451d3a262007660cc0b7cdcea5307c/src/plugins/home/public/application/kibana_services.ts#L46-L48\r\n\r\nChecked everything with `node scripts/type_check`\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_node:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"d900299e731fccaca5c70889371a2760da794da1"}}]}] BACKPORT-->
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…elastic#200629) ## Summary Resolves: elastic#197216 Removed all code that wasn't being used in https://github.com/elastic/kibana/tree/main/src/plugins/saved_objects/public. Didn't remove the actual client since it's still being used here: https://github.com/elastic/kibana/blob/dbab2214e9451d3a262007660cc0b7cdcea5307c/src/plugins/home/public/application/kibana_services.ts#L46-L48 Checked everything with `node scripts/type_check` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…elastic#200629) ## Summary Resolves: elastic#197216 Removed all code that wasn't being used in https://github.com/elastic/kibana/tree/main/src/plugins/saved_objects/public. Didn't remove the actual client since it's still being used here: https://github.com/elastic/kibana/blob/dbab2214e9451d3a262007660cc0b7cdcea5307c/src/plugins/home/public/application/kibana_services.ts#L46-L48 Checked everything with `node scripts/type_check` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #197216
Removed all code that wasn't being used in https://github.com/elastic/kibana/tree/main/src/plugins/saved_objects/public.
Didn't remove the actual client since it's still being used here:
kibana/src/plugins/home/public/application/kibana_services.ts
Lines 46 to 48 in dbab221
Checked everything with
node scripts/type_checkChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_node:*label is applied per the guidelines