-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inventory] Remove open in Discover button #200574
Merged
jennypavlova
merged 4 commits into
elastic:main
from
jennypavlova:199964-obsux-inventory-remove-open-in-discover-button
Nov 18, 2024
Merged
[Inventory] Remove open in Discover button #200574
jennypavlova
merged 4 commits into
elastic:main
from
jennypavlova:199964-obsux-inventory-remove-open-in-discover-button
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
v9.0.0
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
v8.17.0
labels
Nov 18, 2024
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
Create an Observability project
label
Nov 18, 2024
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
rmyz
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/jennypavlova/kibana into 199964-obsux-inventory-remove-open-in-discover-button
⏳ Build in-progress
History
|
jesuswr
pushed a commit
to jesuswr/kibana
that referenced
this pull request
Nov 18, 2024
Closes elastic#199964 This PR removes the `open in discover` button from the inventory search bar section. | Before | After | | ------- | ----- | | <img width="1911" alt="image" src="https://github.com/user-attachments/assets/627ebfa0-77c9-4ff1-8a38-3623bf1b7e32"> | <img width="1915" alt="image" src="https://github.com/user-attachments/assets/2dace203-7203-4bda-8cee-0186e022e373"> |
This was referenced Nov 18, 2024
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jennypavlova
added a commit
to jennypavlova/kibana
that referenced
this pull request
Nov 19, 2024
Closes elastic#199964 This PR removes the `open in discover` button from the inventory search bar section. | Before | After | | ------- | ----- | | <img width="1911" alt="image" src="https://github.com/user-attachments/assets/627ebfa0-77c9-4ff1-8a38-3623bf1b7e32"> | <img width="1915" alt="image" src="https://github.com/user-attachments/assets/2dace203-7203-4bda-8cee-0186e022e373"> | (cherry picked from commit 1607803)
jennypavlova
added a commit
that referenced
this pull request
Nov 19, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Inventory] Remove open in Discover button (#200574)](#200574) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T16:27:32Z","message":"[Inventory] Remove open in Discover button (#200574)\n\nCloses #199964 \r\n\r\nThis PR removes the `open in discover` button from the inventory search\r\nbar section.\r\n\r\n| Before | After |\r\n| ------- | ----- |\r\n| <img width=\"1911\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/627ebfa0-77c9-4ff1-8a38-3623bf1b7e32\">\r\n| <img width=\"1915\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2dace203-7203-4bda-8cee-0186e022e373\">\r\n|","sha":"1607803f610cbbc97883b78578723fa8400c7b4a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.17.0"],"number":200574,"url":"https://github.com/elastic/kibana/pull/200574","mergeCommit":{"message":"[Inventory] Remove open in Discover button (#200574)\n\nCloses #199964 \r\n\r\nThis PR removes the `open in discover` button from the inventory search\r\nbar section.\r\n\r\n| Before | After |\r\n| ------- | ----- |\r\n| <img width=\"1911\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/627ebfa0-77c9-4ff1-8a38-3623bf1b7e32\">\r\n| <img width=\"1915\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2dace203-7203-4bda-8cee-0186e022e373\">\r\n|","sha":"1607803f610cbbc97883b78578723fa8400c7b4a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200574","number":200574,"mergeCommit":{"message":"[Inventory] Remove open in Discover button (#200574)\n\nCloses #199964 \r\n\r\nThis PR removes the `open in discover` button from the inventory search\r\nbar section.\r\n\r\n| Before | After |\r\n| ------- | ----- |\r\n| <img width=\"1911\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/627ebfa0-77c9-4ff1-8a38-3623bf1b7e32\">\r\n| <img width=\"1915\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2dace203-7203-4bda-8cee-0186e022e373\">\r\n|","sha":"1607803f610cbbc97883b78578723fa8400c7b4a"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Closes elastic#199964 This PR removes the `open in discover` button from the inventory search bar section. | Before | After | | ------- | ----- | | <img width="1911" alt="image" src="https://github.com/user-attachments/assets/627ebfa0-77c9-4ff1-8a38-3623bf1b7e32"> | <img width="1915" alt="image" src="https://github.com/user-attachments/assets/2dace203-7203-4bda-8cee-0186e022e373"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
ci:project-deploy-observability
Create an Observability project
release_note:skip
Skip the PR/issue when compiling release notes
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
v8.17.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199964
This PR removes the
open in discover
button from the inventory search bar section.