Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Inventory] Remove open in Discover button (#200574) #200729

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[8.x] [Inventory] Remove open in Discover button (#200574) #200729

merged 1 commit into from
Nov 19, 2024

Conversation

jennypavlova
Copy link
Member

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@jennypavlova
[Inventory] Remove open in Discover button (elastic#200574)
0840540 
Closes elastic#199964

This PR removes the `open in discover` button from the inventory search
bar section.

| Before | After |
| ------- | ----- |
| <img width="1911" alt="image"
src="https://github.com/user-attachments/assets/627ebfa0-77c9-4ff1-8a38-3623bf1b7e32">
| <img width="1915" alt="image"
src="https://github.com/user-attachments/assets/2dace203-7203-4bda-8cee-0186e022e373">
|

(cherry picked from commit 1607803)
@jennypavlova jennypavlova enabled auto-merge (squash) November 19, 2024 13:19
@jennypavlova jennypavlova mentioned this pull request Nov 19, 2024
Merged
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

cauemarcondes
cauemarcondes approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennypavlova jennypavlova merged commit 74d2099 into elastic:8.x Nov 19, 2024
29 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 278 277 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 236.5KB 236.0KB -490.0B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennypavlova @elasticmachine @cauemarcondes