Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-core
#201653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
requested review from
a team,
shahinakmal and
vigneshshanmugam
as code owners
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
gsoldevila
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
2 tasks
gsoldevila
force-pushed
the
kbn-team-1309-move-core-packages-1-10
branch
from
aadc120 to
deb5701
Compare
Ikuni17
approved these changes
Nov 26, 2024
afharo
added a commit
that referenced
this pull request
Nov 27, 2024
## Summary Since we are moving code around, the schema extractor now needs to adapt to the new directories. This PR adds new per-solution schemas to the `.telemetryrc.json` files and adapts FTRs accordingly. Related #201653 ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 27, 2024
## Summary Since we are moving code around, the schema extractor now needs to adapt to the new directories. This PR adds new per-solution schemas to the `.telemetryrc.json` files and adapts FTRs accordingly. Related elastic#201653 ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit dac87ef)
gsoldevila
force-pushed
the
kbn-team-1309-move-core-packages-1-10
branch
from
deb5701 to
c2af66e
Compare
dokmic
force-pushed
the
kbn-team-1309-move-core-packages-1-10
branch
2 times, most recently
from
2c0a66d to
47ad664
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing exports
Unknown metric groupsReferences to deprecated APIs
Unreferenced deprecated APIs
History
|
dokmic
requested review from
sebelga and
a team
and removed request for
sebelga
tsullivan
approved these changes
Jan 4, 2025
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12612900449 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dokmic
added a commit
that referenced
this pull request
Jan 5, 2025
…c/kibana-core` (#201653) (#205563) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-core` (#201653)](#201653) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-04T18:47:24Z","message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-core` (#201653)\n\n## Summary\n\nStart relocating Kibana modules (packages and plugins) to the new folder\nstructure, according to the _Kibana Sustainable Architecture_\ninitiative.\n#### 16 plugin(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/cloud-chat-plugin` |\n`x-pack/platform/plugins/private/cloud_integrations/cloud_chat` |\n| `@kbn/cloud-experiments-plugin` |\n`x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments` |\n| `@kbn/cloud-full-story-plugin` |\n`x-pack/platform/plugins/private/cloud_integrations/cloud_full_story` |\n| `@kbn/cloud-links-plugin` |\n`x-pack/platform/plugins/private/cloud_integrations/cloud_links` |\n| `@kbn/cloud-plugin` | `x-pack/platform/plugins/shared/cloud` |\n| `@kbn/features-plugin` | `x-pack/platform/plugins/shared/features` |\n| `@kbn/ftr-apis-plugin` | `src/platform/plugins/private/ftr_apis` |\n| `@kbn/kibana-usage-collection-plugin` |\n`src/platform/plugins/private/kibana_usage_collection` |\n| `@kbn/licensing-plugin` | `x-pack/platform/plugins/shared/licensing` |\n| `@kbn/newsfeed-plugin` | `src/platform/plugins/shared/newsfeed` |\n| `@kbn/saved-objects-management-plugin` |\n`src/platform/plugins/shared/saved_objects_management` |\n| `@kbn/telemetry-collection-manager-plugin` |\n`src/platform/plugins/shared/telemetry_collection_manager` |\n| `@kbn/telemetry-collection-xpack-plugin` |\n`x-pack/platform/plugins/private/telemetry_collection_xpack` |\n| `@kbn/telemetry-management-section-plugin` |\n`src/platform/plugins/shared/telemetry_management_section` |\n| `@kbn/telemetry-plugin` | `src/platform/plugins/shared/telemetry` |\n| `@kbn/usage-collection-plugin` |\n`src/platform/plugins/shared/usage_collection` |\n\n#### 22 package(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/analytics` | `src/platform/packages/shared/kbn-analytics` |\n| `@kbn/analytics-collection-utils` |\n`src/platform/packages/private/analytics/utils/analytics_collection_utils`\n|\n| `@kbn/apm-config-loader` |\n`src/platform/packages/private/kbn-apm-config-loader` |\n| `@kbn/cloud` | `src/platform/packages/shared/cloud` |\n| `@kbn/config` | `src/platform/packages/shared/kbn-config` |\n| `@kbn/config-mocks` | `src/platform/packages/private/kbn-config-mocks`\n|\n| `@kbn/config-schema` |\n`src/platform/packages/shared/kbn-config-schema` |\n| `@kbn/crypto-browser` |\n`src/platform/packages/shared/kbn-crypto-browser` |\n| `@kbn/ebt-tools` | `src/platform/packages/shared/kbn-ebt-tools` |\n| `@kbn/es-errors` | `src/platform/packages/shared/kbn-es-errors` |\n| `@kbn/es-types` | `src/platform/packages/shared/kbn-es-types` |\n| `@kbn/hapi-mocks` | `src/platform/packages/private/kbn-hapi-mocks` |\n| `@kbn/health-gateway-server` |\n`src/platform/packages/private/kbn-health-gateway-server` |\n| `@kbn/i18n` | `src/platform/packages/shared/kbn-i18n` |\n| `@kbn/i18n-react` | `src/platform/packages/shared/kbn-i18n-react` |\n| `@kbn/logging` | `src/platform/packages/shared/kbn-logging` |\n| `@kbn/logging-mocks` |\n`src/platform/packages/shared/kbn-logging-mocks` |\n| `@kbn/router-to-openapispec` |\n`src/platform/packages/shared/kbn-router-to-openapispec` |\n| `@kbn/server-http-tools` |\n`src/platform/packages/shared/kbn-server-http-tools` |\n| `@kbn/std` | `src/platform/packages/shared/kbn-std` |\n| `@kbn/utility-types` |\n`src/platform/packages/shared/kbn-utility-types` |\n| `@kbn/zod` | `src/platform/packages/shared/kbn-zod` |\n\n---------\n\nCo-authored-by: Alejandro Fernández Haro <[email protected]>\nCo-authored-by: kibanamachine <[email protected]>","sha":"6049493e4a2372ea22986b231ad2bd59584fe9b8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","plugin groups"],"number":201653,"url":"https://github.com/elastic/kibana/pull/201653","mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-core` (#201653)\n\n## Summary\n\nStart relocating Kibana modules (packages and plugins) to the new folder\nstructure, according to the _Kibana Sustainable Architecture_\ninitiative.\n#### 16 plugin(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/cloud-chat-plugin` |\n`x-pack/platform/plugins/private/cloud_integrations/cloud_chat` |\n| `@kbn/cloud-experiments-plugin` |\n`x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments` |\n| `@kbn/cloud-full-story-plugin` |\n`x-pack/platform/plugins/private/cloud_integrations/cloud_full_story` |\n| `@kbn/cloud-links-plugin` |\n`x-pack/platform/plugins/private/cloud_integrations/cloud_links` |\n| `@kbn/cloud-plugin` | `x-pack/platform/plugins/shared/cloud` |\n| `@kbn/features-plugin` | `x-pack/platform/plugins/shared/features` |\n| `@kbn/ftr-apis-plugin` | `src/platform/plugins/private/ftr_apis` |\n| `@kbn/kibana-usage-collection-plugin` |\n`src/platform/plugins/private/kibana_usage_collection` |\n| `@kbn/licensing-plugin` | `x-pack/platform/plugins/shared/licensing` |\n| `@kbn/newsfeed-plugin` | `src/platform/plugins/shared/newsfeed` |\n| `@kbn/saved-objects-management-plugin` |\n`src/platform/plugins/shared/saved_objects_management` |\n| `@kbn/telemetry-collection-manager-plugin` |\n`src/platform/plugins/shared/telemetry_collection_manager` |\n| `@kbn/telemetry-collection-xpack-plugin` |\n`x-pack/platform/plugins/private/telemetry_collection_xpack` |\n| `@kbn/telemetry-management-section-plugin` |\n`src/platform/plugins/shared/telemetry_management_section` |\n| `@kbn/telemetry-plugin` | `src/platform/plugins/shared/telemetry` |\n| `@kbn/usage-collection-plugin` |\n`src/platform/plugins/shared/usage_collection` |\n\n#### 22 package(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/analytics` | `src/platform/packages/shared/kbn-analytics` |\n| `@kbn/analytics-collection-utils` |\n`src/platform/packages/private/analytics/utils/analytics_collection_utils`\n|\n| `@kbn/apm-config-loader` |\n`src/platform/packages/private/kbn-apm-config-loader` |\n| `@kbn/cloud` | `src/platform/packages/shared/cloud` |\n| `@kbn/config` | `src/platform/packages/shared/kbn-config` |\n| `@kbn/config-mocks` | `src/platform/packages/private/kbn-config-mocks`\n|\n| `@kbn/config-schema` |\n`src/platform/packages/shared/kbn-config-schema` |\n| `@kbn/crypto-browser` |\n`src/platform/packages/shared/kbn-crypto-browser` |\n| `@kbn/ebt-tools` | `src/platform/packages/shared/kbn-ebt-tools` |\n| `@kbn/es-errors` | `src/platform/packages/shared/kbn-es-errors` |\n| `@kbn/es-types` | `src/platform/packages/shared/kbn-es-types` |\n| `@kbn/hapi-mocks` | `src/platform/packages/private/kbn-hapi-mocks` |\n| `@kbn/health-gateway-server` |\n`src/platform/packages/private/kbn-health-gateway-server` |\n| `@kbn/i18n` | `src/platform/packages/shared/kbn-i18n` |\n| `@kbn/i18n-react` | `src/platform/packages/shared/kbn-i18n-react` |\n| `@kbn/logging` | `src/platform/packages/shared/kbn-logging` |\n| `@kbn/logging-mocks` |\n`src/platform/packages/shared/kbn-logging-mocks` |\n| `@kbn/router-to-openapispec` |\n`src/platform/packages/shared/kbn-router-to-openapispec` |\n| `@kbn/server-http-tools` |\n`src/platform/packages/shared/kbn-server-http-tools` |\n| `@kbn/std` | `src/platform/packages/shared/kbn-std` |\n| `@kbn/utility-types` |\n`src/platform/packages/shared/kbn-utility-types` |\n| `@kbn/zod` | `src/platform/packages/shared/kbn-zod` |\n\n---------\n\nCo-authored-by: Alejandro Fernández Haro <[email protected]>\nCo-authored-by: kibanamachine <[email protected]>","sha":"6049493e4a2372ea22986b231ad2bd59584fe9b8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201653","number":201653,"mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-core` (#201653)\n\n## Summary\n\nStart relocating Kibana modules (packages and plugins) to the new folder\nstructure, according to the _Kibana Sustainable Architecture_\ninitiative.\n#### 16 plugin(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/cloud-chat-plugin` |\n`x-pack/platform/plugins/private/cloud_integrations/cloud_chat` |\n| `@kbn/cloud-experiments-plugin` |\n`x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments` |\n| `@kbn/cloud-full-story-plugin` |\n`x-pack/platform/plugins/private/cloud_integrations/cloud_full_story` |\n| `@kbn/cloud-links-plugin` |\n`x-pack/platform/plugins/private/cloud_integrations/cloud_links` |\n| `@kbn/cloud-plugin` | `x-pack/platform/plugins/shared/cloud` |\n| `@kbn/features-plugin` | `x-pack/platform/plugins/shared/features` |\n| `@kbn/ftr-apis-plugin` | `src/platform/plugins/private/ftr_apis` |\n| `@kbn/kibana-usage-collection-plugin` |\n`src/platform/plugins/private/kibana_usage_collection` |\n| `@kbn/licensing-plugin` | `x-pack/platform/plugins/shared/licensing` |\n| `@kbn/newsfeed-plugin` | `src/platform/plugins/shared/newsfeed` |\n| `@kbn/saved-objects-management-plugin` |\n`src/platform/plugins/shared/saved_objects_management` |\n| `@kbn/telemetry-collection-manager-plugin` |\n`src/platform/plugins/shared/telemetry_collection_manager` |\n| `@kbn/telemetry-collection-xpack-plugin` |\n`x-pack/platform/plugins/private/telemetry_collection_xpack` |\n| `@kbn/telemetry-management-section-plugin` |\n`src/platform/plugins/shared/telemetry_management_section` |\n| `@kbn/telemetry-plugin` | `src/platform/plugins/shared/telemetry` |\n| `@kbn/usage-collection-plugin` |\n`src/platform/plugins/shared/usage_collection` |\n\n#### 22 package(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/analytics` | `src/platform/packages/shared/kbn-analytics` |\n| `@kbn/analytics-collection-utils` |\n`src/platform/packages/private/analytics/utils/analytics_collection_utils`\n|\n| `@kbn/apm-config-loader` |\n`src/platform/packages/private/kbn-apm-config-loader` |\n| `@kbn/cloud` | `src/platform/packages/shared/cloud` |\n| `@kbn/config` | `src/platform/packages/shared/kbn-config` |\n| `@kbn/config-mocks` | `src/platform/packages/private/kbn-config-mocks`\n|\n| `@kbn/config-schema` |\n`src/platform/packages/shared/kbn-config-schema` |\n| `@kbn/crypto-browser` |\n`src/platform/packages/shared/kbn-crypto-browser` |\n| `@kbn/ebt-tools` | `src/platform/packages/shared/kbn-ebt-tools` |\n| `@kbn/es-errors` | `src/platform/packages/shared/kbn-es-errors` |\n| `@kbn/es-types` | `src/platform/packages/shared/kbn-es-types` |\n| `@kbn/hapi-mocks` | `src/platform/packages/private/kbn-hapi-mocks` |\n| `@kbn/health-gateway-server` |\n`src/platform/packages/private/kbn-health-gateway-server` |\n| `@kbn/i18n` | `src/platform/packages/shared/kbn-i18n` |\n| `@kbn/i18n-react` | `src/platform/packages/shared/kbn-i18n-react` |\n| `@kbn/logging` | `src/platform/packages/shared/kbn-logging` |\n| `@kbn/logging-mocks` |\n`src/platform/packages/shared/kbn-logging-mocks` |\n| `@kbn/router-to-openapispec` |\n`src/platform/packages/shared/kbn-router-to-openapispec` |\n| `@kbn/server-http-tools` |\n`src/platform/packages/shared/kbn-server-http-tools` |\n| `@kbn/std` | `src/platform/packages/shared/kbn-std` |\n| `@kbn/utility-types` |\n`src/platform/packages/shared/kbn-utility-types` |\n| `@kbn/zod` | `src/platform/packages/shared/kbn-zod` |\n\n---------\n\nCo-authored-by: Alejandro Fernández Haro <[email protected]>\nCo-authored-by: kibanamachine <[email protected]>","sha":"6049493e4a2372ea22986b231ad2bd59584fe9b8"}}]}] BACKPORT--> --------- Co-authored-by: Gerard Soldevila <[email protected]>
dokmic
added a commit
that referenced
this pull request
Jan 6, 2025
After merging #202748, #204959, and #201653, all of the properties in some telemetry schemas were moved completely, but `node scripts/telemetry_check --fix` didn't update the `properties` object correctly. Also, in #202748 and #201653, the relocation script changed some paths, confusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 6, 2025
…#205613) After merging elastic#202748, elastic#204959, and elastic#201653, all of the properties in some telemetry schemas were moved completely, but `node scripts/telemetry_check --fix` didn't update the `properties` object correctly. Also, in elastic#202748 and elastic#201653, the relocation script changed some paths, confusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`. (cherry picked from commit 5409631)
kibanamachine
added a commit
that referenced
this pull request
Jan 6, 2025
…205613) (#205641) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Fix after-relocation issues (#205613)](#205613) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Michael Dokolin","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-06T18:02:36Z","message":"Sustainable Kibana Architecture: Fix after-relocation issues (#205613)\n\nAfter merging #202748, #204959, and #201653, all of the properties in\nsome telemetry schemas were moved completely, but `node\nscripts/telemetry_check --fix` didn't update the `properties` object\ncorrectly.\n\nAlso, in #202748 and #201653, the relocation script changed some paths,\nconfusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.","sha":"540963148dc671b02655ced8285dbbd817d9d5c9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:version","v8.18.0","plugin groups"],"title":"Sustainable Kibana Architecture: Fix after-relocation issues","number":205613,"url":"https://github.com/elastic/kibana/pull/205613","mergeCommit":{"message":"Sustainable Kibana Architecture: Fix after-relocation issues (#205613)\n\nAfter merging #202748, #204959, and #201653, all of the properties in\nsome telemetry schemas were moved completely, but `node\nscripts/telemetry_check --fix` didn't update the `properties` object\ncorrectly.\n\nAlso, in #202748 and #201653, the relocation script changed some paths,\nconfusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.","sha":"540963148dc671b02655ced8285dbbd817d9d5c9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205613","number":205613,"mergeCommit":{"message":"Sustainable Kibana Architecture: Fix after-relocation issues (#205613)\n\nAfter merging #202748, #204959, and #201653, all of the properties in\nsome telemetry schemas were moved completely, but `node\nscripts/telemetry_check --fix` didn't update the `properties` object\ncorrectly.\n\nAlso, in #202748 and #201653, the relocation script changed some paths,\nconfusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.","sha":"540963148dc671b02655ced8285dbbd817d9d5c9"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Michael Dokolin <[email protected]>
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
…na-core` (elastic#201653) ## Summary Start relocating Kibana modules (packages and plugins) to the new folder structure, according to the _Kibana Sustainable Architecture_ initiative. #### 16 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/cloud-chat-plugin` | `x-pack/platform/plugins/private/cloud_integrations/cloud_chat` | | `@kbn/cloud-experiments-plugin` | `x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments` | | `@kbn/cloud-full-story-plugin` | `x-pack/platform/plugins/private/cloud_integrations/cloud_full_story` | | `@kbn/cloud-links-plugin` | `x-pack/platform/plugins/private/cloud_integrations/cloud_links` | | `@kbn/cloud-plugin` | `x-pack/platform/plugins/shared/cloud` | | `@kbn/features-plugin` | `x-pack/platform/plugins/shared/features` | | `@kbn/ftr-apis-plugin` | `src/platform/plugins/private/ftr_apis` | | `@kbn/kibana-usage-collection-plugin` | `src/platform/plugins/private/kibana_usage_collection` | | `@kbn/licensing-plugin` | `x-pack/platform/plugins/shared/licensing` | | `@kbn/newsfeed-plugin` | `src/platform/plugins/shared/newsfeed` | | `@kbn/saved-objects-management-plugin` | `src/platform/plugins/shared/saved_objects_management` | | `@kbn/telemetry-collection-manager-plugin` | `src/platform/plugins/shared/telemetry_collection_manager` | | `@kbn/telemetry-collection-xpack-plugin` | `x-pack/platform/plugins/private/telemetry_collection_xpack` | | `@kbn/telemetry-management-section-plugin` | `src/platform/plugins/shared/telemetry_management_section` | | `@kbn/telemetry-plugin` | `src/platform/plugins/shared/telemetry` | | `@kbn/usage-collection-plugin` | `src/platform/plugins/shared/usage_collection` | #### 22 package(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/analytics` | `src/platform/packages/shared/kbn-analytics` | | `@kbn/analytics-collection-utils` | `src/platform/packages/private/analytics/utils/analytics_collection_utils` | | `@kbn/apm-config-loader` | `src/platform/packages/private/kbn-apm-config-loader` | | `@kbn/cloud` | `src/platform/packages/shared/cloud` | | `@kbn/config` | `src/platform/packages/shared/kbn-config` | | `@kbn/config-mocks` | `src/platform/packages/private/kbn-config-mocks` | | `@kbn/config-schema` | `src/platform/packages/shared/kbn-config-schema` | | `@kbn/crypto-browser` | `src/platform/packages/shared/kbn-crypto-browser` | | `@kbn/ebt-tools` | `src/platform/packages/shared/kbn-ebt-tools` | | `@kbn/es-errors` | `src/platform/packages/shared/kbn-es-errors` | | `@kbn/es-types` | `src/platform/packages/shared/kbn-es-types` | | `@kbn/hapi-mocks` | `src/platform/packages/private/kbn-hapi-mocks` | | `@kbn/health-gateway-server` | `src/platform/packages/private/kbn-health-gateway-server` | | `@kbn/i18n` | `src/platform/packages/shared/kbn-i18n` | | `@kbn/i18n-react` | `src/platform/packages/shared/kbn-i18n-react` | | `@kbn/logging` | `src/platform/packages/shared/kbn-logging` | | `@kbn/logging-mocks` | `src/platform/packages/shared/kbn-logging-mocks` | | `@kbn/router-to-openapispec` | `src/platform/packages/shared/kbn-router-to-openapispec` | | `@kbn/server-http-tools` | `src/platform/packages/shared/kbn-server-http-tools` | | `@kbn/std` | `src/platform/packages/shared/kbn-std` | | `@kbn/utility-types` | `src/platform/packages/shared/kbn-utility-types` | | `@kbn/zod` | `src/platform/packages/shared/kbn-zod` | --------- Co-authored-by: Alejandro Fernández Haro <[email protected]> Co-authored-by: kibanamachine <[email protected]>
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
…#205613) After merging elastic#202748, elastic#204959, and elastic#201653, all of the properties in some telemetry schemas were moved completely, but `node scripts/telemetry_check --fix` didn't update the `properties` object correctly. Also, in elastic#202748 and elastic#201653, the relocation script changed some paths, confusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…na-core` (elastic#201653) ## Summary Start relocating Kibana modules (packages and plugins) to the new folder structure, according to the _Kibana Sustainable Architecture_ initiative. #### 16 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/cloud-chat-plugin` | `x-pack/platform/plugins/private/cloud_integrations/cloud_chat` | | `@kbn/cloud-experiments-plugin` | `x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments` | | `@kbn/cloud-full-story-plugin` | `x-pack/platform/plugins/private/cloud_integrations/cloud_full_story` | | `@kbn/cloud-links-plugin` | `x-pack/platform/plugins/private/cloud_integrations/cloud_links` | | `@kbn/cloud-plugin` | `x-pack/platform/plugins/shared/cloud` | | `@kbn/features-plugin` | `x-pack/platform/plugins/shared/features` | | `@kbn/ftr-apis-plugin` | `src/platform/plugins/private/ftr_apis` | | `@kbn/kibana-usage-collection-plugin` | `src/platform/plugins/private/kibana_usage_collection` | | `@kbn/licensing-plugin` | `x-pack/platform/plugins/shared/licensing` | | `@kbn/newsfeed-plugin` | `src/platform/plugins/shared/newsfeed` | | `@kbn/saved-objects-management-plugin` | `src/platform/plugins/shared/saved_objects_management` | | `@kbn/telemetry-collection-manager-plugin` | `src/platform/plugins/shared/telemetry_collection_manager` | | `@kbn/telemetry-collection-xpack-plugin` | `x-pack/platform/plugins/private/telemetry_collection_xpack` | | `@kbn/telemetry-management-section-plugin` | `src/platform/plugins/shared/telemetry_management_section` | | `@kbn/telemetry-plugin` | `src/platform/plugins/shared/telemetry` | | `@kbn/usage-collection-plugin` | `src/platform/plugins/shared/usage_collection` | #### 22 package(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/analytics` | `src/platform/packages/shared/kbn-analytics` | | `@kbn/analytics-collection-utils` | `src/platform/packages/private/analytics/utils/analytics_collection_utils` | | `@kbn/apm-config-loader` | `src/platform/packages/private/kbn-apm-config-loader` | | `@kbn/cloud` | `src/platform/packages/shared/cloud` | | `@kbn/config` | `src/platform/packages/shared/kbn-config` | | `@kbn/config-mocks` | `src/platform/packages/private/kbn-config-mocks` | | `@kbn/config-schema` | `src/platform/packages/shared/kbn-config-schema` | | `@kbn/crypto-browser` | `src/platform/packages/shared/kbn-crypto-browser` | | `@kbn/ebt-tools` | `src/platform/packages/shared/kbn-ebt-tools` | | `@kbn/es-errors` | `src/platform/packages/shared/kbn-es-errors` | | `@kbn/es-types` | `src/platform/packages/shared/kbn-es-types` | | `@kbn/hapi-mocks` | `src/platform/packages/private/kbn-hapi-mocks` | | `@kbn/health-gateway-server` | `src/platform/packages/private/kbn-health-gateway-server` | | `@kbn/i18n` | `src/platform/packages/shared/kbn-i18n` | | `@kbn/i18n-react` | `src/platform/packages/shared/kbn-i18n-react` | | `@kbn/logging` | `src/platform/packages/shared/kbn-logging` | | `@kbn/logging-mocks` | `src/platform/packages/shared/kbn-logging-mocks` | | `@kbn/router-to-openapispec` | `src/platform/packages/shared/kbn-router-to-openapispec` | | `@kbn/server-http-tools` | `src/platform/packages/shared/kbn-server-http-tools` | | `@kbn/std` | `src/platform/packages/shared/kbn-std` | | `@kbn/utility-types` | `src/platform/packages/shared/kbn-utility-types` | | `@kbn/zod` | `src/platform/packages/shared/kbn-zod` | --------- Co-authored-by: Alejandro Fernández Haro <[email protected]> Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…#205613) After merging elastic#202748, elastic#204959, and elastic#201653, all of the properties in some telemetry schemas were moved completely, but `node scripts/telemetry_check --fix` didn't update the `properties` object correctly. Also, in elastic#202748 and elastic#201653, the relocation script changed some paths, confusing them with `@kbn/security-plugin` and `@kbn/cloud-plugin`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]andplugins[\/\\]patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.tsto ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.tsand.jsfiles listed in the sections below, as some of them contain relative paths that have been updated.Note
Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.
17 plugin(s) are going to be relocated:
@kbn/cloud-chat-pluginx-pack/platform/plugins/private/cloud_integrations/cloud_chat@kbn/cloud-experiments-pluginx-pack/platform/plugins/shared/cloud_integrations/cloud_experiments@kbn/cloud-full-story-pluginx-pack/platform/plugins/private/cloud_integrations/cloud_full_story@kbn/cloud-links-pluginx-pack/platform/plugins/private/cloud_integrations/cloud_links@kbn/cloud-pluginx-pack/platform/plugins/shared/cloud@kbn/features-pluginx-pack/platform/plugins/shared/features@kbn/ftr-apis-pluginsrc/platform/plugins/private/ftr_apis@kbn/kibana-usage-collection-pluginsrc/platform/plugins/private/kibana_usage_collection@kbn/licensing-pluginx-pack/platform/plugins/shared/licensing@kbn/newsfeed-pluginsrc/platform/plugins/shared/newsfeed@kbn/saved-objects-management-pluginsrc/platform/plugins/shared/saved_objects_management@kbn/telemetry-collection-manager-pluginsrc/platform/plugins/shared/telemetry_collection_manager@kbn/telemetry-collection-xpack-pluginx-pack/platform/plugins/private/telemetry_collection_xpack@kbn/telemetry-management-section-pluginsrc/platform/plugins/shared/telemetry_management_section@kbn/telemetry-pluginsrc/platform/plugins/shared/telemetry@kbn/upgrade-assistant-pluginx-pack/platform/plugins/private/upgrade_assistant@kbn/usage-collection-pluginsrc/platform/plugins/shared/usage_collection145 packages(s) are going to be relocated:
@kbn/analyticssrc/platform/packages/shared/kbn-analytics@kbn/analytics-collection-utilssrc/platform/packages/private/analytics/utils/analytics_collection_utils@kbn/apm-config-loadersrc/platform/packages/private/kbn-apm-config-loader@kbn/cloudsrc/platform/packages/shared/cloud@kbn/configsrc/platform/packages/shared/kbn-config@kbn/config-mockssrc/platform/packages/private/kbn-config-mocks@kbn/config-schemasrc/platform/packages/shared/kbn-config-schema@kbn/core-base-common-internalsrc/core/packages/base/common-internal@kbn/core-base-server-internalsrc/core/packages/base/server-internal@kbn/core-capabilities-browser-internalsrc/core/packages/capabilities/browser-internal@kbn/core-capabilities-commonsrc/core/packages/capabilities/common@kbn/core-capabilities-serversrc/core/packages/capabilities/server@kbn/core-capabilities-server-internalsrc/core/packages/capabilities/server-internal@kbn/core-config-server-internalsrc/core/packages/config/server-internal@kbn/core-deprecations-browsersrc/core/packages/deprecations/browser@kbn/core-deprecations-browser-internalsrc/core/packages/deprecations/browser-internal@kbn/core-deprecations-commonsrc/core/packages/deprecations/common@kbn/core-deprecations-serversrc/core/packages/deprecations/server@kbn/core-deprecations-server-internalsrc/core/packages/deprecations/server-internal@kbn/core-doc-links-browsersrc/core/packages/doc-links/browser@kbn/core-doc-links-browser-internalsrc/core/packages/doc-links/browser-internal@kbn/core-doc-links-serversrc/core/packages/doc-links/server@kbn/core-doc-links-server-internalsrc/core/packages/doc-links/server-internal@kbn/core-elasticsearch-client-server-internalsrc/core/packages/elasticsearch/client-server-internal@kbn/core-elasticsearch-serversrc/core/packages/elasticsearch/server@kbn/core-elasticsearch-server-internalsrc/core/packages/elasticsearch/server-internal@kbn/core-environment-server-internalsrc/core/packages/environment/server-internal@kbn/core-execution-context-browsersrc/core/packages/execution-context/browser@kbn/core-execution-context-browser-internalsrc/core/packages/execution-context/browser-internal@kbn/core-execution-context-commonsrc/core/packages/execution-context/common@kbn/core-execution-context-serversrc/core/packages/execution-context/server@kbn/core-execution-context-server-internalsrc/core/packages/execution-context/server-internal@kbn/core-fatal-errors-browsersrc/core/packages/fatal-errors/browser@kbn/core-fatal-errors-browser-internalsrc/core/packages/fatal-errors/browser-internal@kbn/core-feature-flags-browsersrc/core/packages/feature-flags/browser@kbn/core-feature-flags-browser-internalsrc/core/packages/feature-flags/browser-internal@kbn/core-feature-flags-browser-mockssrc/core/packages/feature-flags/browser-mocks@kbn/core-feature-flags-serversrc/core/packages/feature-flags/server@kbn/core-feature-flags-server-internalsrc/core/packages/feature-flags/server-internal@kbn/core-feature-flags-server-mockssrc/core/packages/feature-flags/server-mocks@kbn/core-http-browsersrc/core/packages/http/browser@kbn/core-http-browser-internalsrc/core/packages/http/browser-internal@kbn/core-http-commonsrc/core/packages/http/common@kbn/core-http-context-server-internalsrc/core/packages/http/context-server-internal@kbn/core-http-request-handler-context-serversrc/core/packages/http/request-handler-context-server@kbn/core-http-request-handler-context-server-internalsrc/core/packages/http/request-handler-context-server-internal@kbn/core-http-resources-serversrc/core/packages/http/resources-server@kbn/core-http-resources-server-internalsrc/core/packages/http/resources-server-internal@kbn/core-http-router-server-internalsrc/core/packages/http/router-server-internal@kbn/core-http-serversrc/core/packages/http/server@kbn/core-http-server-internalsrc/core/packages/http/server-internal@kbn/core-http-server-utilssrc/core/packages/http/server-utils@kbn/core-i18n-browsersrc/core/packages/i18n/browser@kbn/core-i18n-browser-internalsrc/core/packages/i18n/browser-internal@kbn/core-i18n-serversrc/core/packages/i18n/server@kbn/core-i18n-server-internalsrc/core/packages/i18n/server-internal@kbn/core-injected-metadata-browser-internalsrc/core/packages/injected-metadata/browser-internal@kbn/core-injected-metadata-common-internalsrc/core/packages/injected-metadata/common-internal@kbn/core-integrations-browser-internalsrc/core/packages/integrations/browser-internal@kbn/core-lifecycle-browsersrc/core/packages/lifecycle/browser@kbn/core-lifecycle-browser-internalsrc/core/packages/lifecycle/browser-internal@kbn/core-lifecycle-serversrc/core/packages/lifecycle/server@kbn/core-lifecycle-server-internalsrc/core/packages/lifecycle/server-internal@kbn/core-logging-browser-internalsrc/core/packages/logging/browser-internal@kbn/core-logging-common-internalsrc/core/packages/logging/common-internal@kbn/core-logging-serversrc/core/packages/logging/server@kbn/core-logging-server-internalsrc/core/packages/logging/server-internal@kbn/core-metrics-collectors-server-internalsrc/core/packages/metrics/collectors-server-internal@kbn/core-metrics-serversrc/core/packages/metrics/server@kbn/core-metrics-server-internalsrc/core/packages/metrics/server-internal@kbn/core-mount-utils-browsersrc/core/packages/mount-utils/browser@kbn/core-mount-utils-browser-internalsrc/core/packages/mount-utils/browser-internal@kbn/core-node-serversrc/core/packages/node/server@kbn/core-node-server-internalsrc/core/packages/node/server-internal@kbn/core-notifications-browsersrc/core/packages/notifications/browser@kbn/core-notifications-browser-internalsrc/core/packages/notifications/browser-internal@kbn/core-overlays-browsersrc/core/packages/overlays/browser@kbn/core-overlays-browser-internalsrc/core/packages/overlays/browser-internal@kbn/core-plugins-base-server-internalsrc/core/packages/plugins/base-server-internal@kbn/core-plugins-browsersrc/core/packages/plugins/browser@kbn/core-plugins-browser-internalsrc/core/packages/plugins/browser-internal@kbn/core-plugins-contracts-browsersrc/core/packages/plugins/contracts-browser@kbn/core-plugins-contracts-serversrc/core/packages/plugins/contracts-server@kbn/core-plugins-serversrc/core/packages/plugins/server@kbn/core-plugins-server-internalsrc/core/packages/plugins/server-internal@kbn/core-preboot-serversrc/core/packages/preboot/server@kbn/core-preboot-server-internalsrc/core/packages/preboot/server-internal@kbn/core-rendering-browsersrc/core/packages/rendering/browser@kbn/core-rendering-browser-internalsrc/core/packages/rendering/browser-internal@kbn/core-rendering-server-internalsrc/core/packages/rendering/server-internal@kbn/core-root-browser-internalsrc/core/packages/root/browser-internal@kbn/core-root-server-internalsrc/core/packages/root/server-internal@kbn/core-saved-objects-api-browsersrc/core/packages/saved-objects/api-browser@kbn/core-saved-objects-api-serversrc/core/packages/saved-objects/api-server@kbn/core-saved-objects-api-server-internalsrc/core/packages/saved-objects/api-server-internal@kbn/core-saved-objects-base-server-internalsrc/core/packages/saved-objects/base-server-internal@kbn/core-saved-objects-browsersrc/core/packages/saved-objects/browser@kbn/core-saved-objects-browser-internalsrc/core/packages/saved-objects/browser-internal@kbn/core-saved-objects-commonsrc/core/packages/saved-objects/common@kbn/core-saved-objects-import-export-server-internalsrc/core/packages/saved-objects/import-export-server-internal@kbn/core-saved-objects-migration-server-internalsrc/core/packages/saved-objects/migration-server-internal@kbn/core-saved-objects-serversrc/core/packages/saved-objects/server@kbn/core-saved-objects-server-internalsrc/core/packages/saved-objects/server-internal@kbn/core-saved-objects-utils-serversrc/core/packages/saved-objects/utils-server@kbn/core-security-browsersrc/core/packages/security/browser@kbn/core-security-browser-internalsrc/core/packages/security/browser-internal@kbn/core-security-browser-mockssrc/core/packages/security/browser-mocks@kbn/core-security-commonsrc/core/packages/security/common@kbn/core-security-serversrc/core/packages/security/server@kbn/core-security-server-internalsrc/core/packages/security/server-internal@kbn/core-security-server-mockssrc/core/packages/security/server-mocks@kbn/core-status-commonsrc/core/packages/status/common@kbn/core-status-serversrc/core/packages/status/server@kbn/core-status-server-internalsrc/core/packages/status/server-internal@kbn/core-test-helpers-deprecations-getterssrc/core/packages/test-helpers/deprecations-getters@kbn/core-test-helpers-http-setup-browsersrc/core/packages/test-helpers/http-setup-browser@kbn/core-test-helpers-so-type-serializersrc/core/packages/test-helpers/so-type-serializer@kbn/core-test-helpers-test-utilssrc/core/packages/test-helpers/test-utils@kbn/core-theme-browsersrc/core/packages/theme/browser@kbn/core-theme-browser-internalsrc/core/packages/theme/browser-internal@kbn/core-usage-data-base-server-internalsrc/core/packages/usage-data/base-server-internal@kbn/core-usage-data-serversrc/core/packages/usage-data/server@kbn/core-usage-data-server-internalsrc/core/packages/usage-data/server-internal@kbn/core-user-profile-browsersrc/core/packages/user-profile/browser@kbn/core-user-profile-browser-internalsrc/core/packages/user-profile/browser-internal@kbn/core-user-profile-browser-mockssrc/core/packages/user-profile/browser-mocks@kbn/core-user-profile-commonsrc/core/packages/user-profile/common@kbn/core-user-profile-serversrc/core/packages/user-profile/server@kbn/core-user-profile-server-internalsrc/core/packages/user-profile/server-internal@kbn/core-user-profile-server-mockssrc/core/packages/user-profile/server-mocks@kbn/crypto-browsersrc/platform/packages/shared/kbn-crypto-browser@kbn/ebt-toolssrc/platform/packages/shared/kbn-ebt-tools@kbn/es-errorssrc/platform/packages/shared/kbn-es-errors@kbn/es-typessrc/platform/packages/shared/kbn-es-types@kbn/hapi-mockssrc/platform/packages/private/kbn-hapi-mocks@kbn/health-gateway-serversrc/platform/packages/private/kbn-health-gateway-server@kbn/i18nsrc/platform/packages/shared/kbn-i18n@kbn/i18n-reactsrc/platform/packages/shared/kbn-i18n-react@kbn/loggingsrc/platform/packages/shared/kbn-logging@kbn/logging-mockssrc/platform/packages/shared/kbn-logging-mocks@kbn/router-to-openapispecsrc/platform/packages/shared/kbn-router-to-openapispec@kbn/server-http-toolssrc/platform/packages/shared/kbn-server-http-tools@kbn/stdsrc/platform/packages/shared/kbn-std@kbn/utility-typessrc/platform/packages/shared/kbn-utility-types@kbn/zodsrc/platform/packages/shared/kbn-zodUpdated references
Updated relative paths