Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKA: Move packages under packages/core #204831

Closed
wants to merge 141 commits into from
Closed

SKA: Move packages under packages/core #204831

wants to merge 141 commits into from

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Dec 18, 2024 •
edited
Loading

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

  • We kindly ask you to:
    • Manually fix the errors in the error section below (if there are any).
    • Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
    • Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
    • Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
    • Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
      • customised eslint rules
      • docs pointing to source code

Note

  • This PR has been auto-generated.
  • Any manual contributions will be lost if the 'relocate' script is re-run.
  • Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
  • Please use #sustainable_kibana_architecture Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.

140 packages(s) are going to be relocated:

Id Target folder
@kbn/core-base-common-internal src/core/packages/base/common-internal
@kbn/core-base-server-internal src/core/packages/base/server-internal
@kbn/core-capabilities-browser-internal src/core/packages/capabilities/browser-internal
@kbn/core-capabilities-common src/core/packages/capabilities/common
@kbn/core-capabilities-server src/core/packages/capabilities/server
@kbn/core-capabilities-server-internal src/core/packages/capabilities/server-internal
@kbn/core-chrome-browser src/core/packages/chrome/browser
@kbn/core-chrome-browser-internal src/core/packages/chrome/browser-internal
@kbn/core-config-server-internal src/core/packages/config/server-internal
@kbn/core-custom-branding-browser src/core/packages/custom-branding/browser
@kbn/core-custom-branding-browser-internal src/core/packages/custom-branding/browser-internal
@kbn/core-custom-branding-browser-mocks src/core/packages/custom-branding/browser-mocks
@kbn/core-custom-branding-common src/core/packages/custom-branding/common
@kbn/core-custom-branding-server src/core/packages/custom-branding/server
@kbn/core-custom-branding-server-internal src/core/packages/custom-branding/server-internal
@kbn/core-custom-branding-server-mocks src/core/packages/custom-branding/server-mocks
@kbn/core-deprecations-browser src/core/packages/deprecations/browser
@kbn/core-deprecations-browser-internal src/core/packages/deprecations/browser-internal
@kbn/core-deprecations-common src/core/packages/deprecations/common
@kbn/core-deprecations-server src/core/packages/deprecations/server
@kbn/core-deprecations-server-internal src/core/packages/deprecations/server-internal
@kbn/core-doc-links-browser src/core/packages/doc-links/browser
@kbn/core-doc-links-browser-internal src/core/packages/doc-links/browser-internal
@kbn/core-doc-links-server src/core/packages/doc-links/server
@kbn/core-doc-links-server-internal src/core/packages/doc-links/server-internal
@kbn/core-elasticsearch-client-server-internal src/core/packages/elasticsearch/client-server-internal
@kbn/core-elasticsearch-server src/core/packages/elasticsearch/server
@kbn/core-elasticsearch-server-internal src/core/packages/elasticsearch/server-internal
@kbn/core-environment-server-internal src/core/packages/environment/server-internal
@kbn/core-execution-context-browser src/core/packages/execution-context/browser
@kbn/core-execution-context-browser-internal src/core/packages/execution-context/browser-internal
@kbn/core-execution-context-common src/core/packages/execution-context/common
@kbn/core-execution-context-server src/core/packages/execution-context/server
@kbn/core-execution-context-server-internal src/core/packages/execution-context/server-internal
@kbn/core-fatal-errors-browser src/core/packages/fatal-errors/browser
@kbn/core-fatal-errors-browser-internal src/core/packages/fatal-errors/browser-internal
@kbn/core-feature-flags-browser src/core/packages/feature-flags/browser
@kbn/core-feature-flags-browser-internal src/core/packages/feature-flags/browser-internal
@kbn/core-feature-flags-browser-mocks src/core/packages/feature-flags/browser-mocks
@kbn/core-feature-flags-server src/core/packages/feature-flags/server
@kbn/core-feature-flags-server-internal src/core/packages/feature-flags/server-internal
@kbn/core-feature-flags-server-mocks src/core/packages/feature-flags/server-mocks
@kbn/core-http-browser src/core/packages/http/browser
@kbn/core-http-browser-internal src/core/packages/http/browser-internal
@kbn/core-http-common src/core/packages/http/common
@kbn/core-http-context-server-internal src/core/packages/http/context-server-internal
@kbn/core-http-request-handler-context-server src/core/packages/http/request-handler-context-server
@kbn/core-http-request-handler-context-server-internal src/core/packages/http/request-handler-context-server-internal
@kbn/core-http-resources-server src/core/packages/http/resources-server
@kbn/core-http-resources-server-internal src/core/packages/http/resources-server-internal
@kbn/core-http-router-server-internal src/core/packages/http/router-server-internal
@kbn/core-http-server src/core/packages/http/server
@kbn/core-http-server-internal src/core/packages/http/server-internal
@kbn/core-http-server-utils src/core/packages/http/server-utils
@kbn/core-i18n-browser src/core/packages/i18n/browser
@kbn/core-i18n-browser-internal src/core/packages/i18n/browser-internal
@kbn/core-i18n-server src/core/packages/i18n/server
@kbn/core-i18n-server-internal src/core/packages/i18n/server-internal
@kbn/core-injected-metadata-browser-internal src/core/packages/injected-metadata/browser-internal
@kbn/core-injected-metadata-common-internal src/core/packages/injected-metadata/common-internal
@kbn/core-integrations-browser-internal src/core/packages/integrations/browser-internal
@kbn/core-lifecycle-browser src/core/packages/lifecycle/browser
@kbn/core-lifecycle-browser-internal src/core/packages/lifecycle/browser-internal
@kbn/core-lifecycle-server src/core/packages/lifecycle/server
@kbn/core-lifecycle-server-internal src/core/packages/lifecycle/server-internal
@kbn/core-logging-browser-internal src/core/packages/logging/browser-internal
@kbn/core-logging-common-internal src/core/packages/logging/common-internal
@kbn/core-logging-server src/core/packages/logging/server
@kbn/core-logging-server-internal src/core/packages/logging/server-internal
@kbn/core-metrics-collectors-server-internal src/core/packages/metrics/collectors-server-internal
@kbn/core-metrics-server src/core/packages/metrics/server
@kbn/core-metrics-server-internal src/core/packages/metrics/server-internal
@kbn/core-mount-utils-browser src/core/packages/mount-utils/browser
@kbn/core-mount-utils-browser-internal src/core/packages/mount-utils/browser-internal
@kbn/core-node-server src/core/packages/node/server
@kbn/core-node-server-internal src/core/packages/node/server-internal
@kbn/core-notifications-browser src/core/packages/notifications/browser
@kbn/core-notifications-browser-internal src/core/packages/notifications/browser-internal
@kbn/core-overlays-browser src/core/packages/overlays/browser
@kbn/core-overlays-browser-internal src/core/packages/overlays/browser-internal
@kbn/core-plugins-base-server-internal src/core/packages/plugins/base-server-internal
@kbn/core-plugins-browser src/core/packages/plugins/browser
@kbn/core-plugins-browser-internal src/core/packages/plugins/browser-internal
@kbn/core-plugins-contracts-browser src/core/packages/plugins/contracts-browser
@kbn/core-plugins-contracts-server src/core/packages/plugins/contracts-server
@kbn/core-plugins-server src/core/packages/plugins/server
@kbn/core-plugins-server-internal src/core/packages/plugins/server-internal
@kbn/core-preboot-server src/core/packages/preboot/server
@kbn/core-preboot-server-internal src/core/packages/preboot/server-internal
@kbn/core-rendering-browser src/core/packages/rendering/browser
@kbn/core-rendering-browser-internal src/core/packages/rendering/browser-internal
@kbn/core-rendering-server-internal src/core/packages/rendering/server-internal
@kbn/core-root-browser-internal src/core/packages/root/browser-internal
@kbn/core-root-server-internal src/core/packages/root/server-internal
@kbn/core-saved-objects-api-browser src/core/packages/saved-objects/api-browser
@kbn/core-saved-objects-api-server src/core/packages/saved-objects/api-server
@kbn/core-saved-objects-api-server-internal src/core/packages/saved-objects/api-server-internal
@kbn/core-saved-objects-base-server-internal src/core/packages/saved-objects/base-server-internal
@kbn/core-saved-objects-browser src/core/packages/saved-objects/browser
@kbn/core-saved-objects-browser-internal src/core/packages/saved-objects/browser-internal
@kbn/core-saved-objects-common src/core/packages/saved-objects/common
@kbn/core-saved-objects-import-export-server-internal src/core/packages/saved-objects/import-export-server-internal
@kbn/core-saved-objects-migration-server-internal src/core/packages/saved-objects/migration-server-internal
@kbn/core-saved-objects-server src/core/packages/saved-objects/server
@kbn/core-saved-objects-server-internal src/core/packages/saved-objects/server-internal
@kbn/core-saved-objects-utils-server src/core/packages/saved-objects/utils-server
@kbn/core-security-browser src/core/packages/security/browser
@kbn/core-security-browser-internal src/core/packages/security/browser-internal
@kbn/core-security-browser-mocks src/core/packages/security/browser-mocks
@kbn/core-security-common src/core/packages/security/common
@kbn/core-security-server src/core/packages/security/server
@kbn/core-security-server-internal src/core/packages/security/server-internal
@kbn/core-security-server-mocks src/core/packages/security/server-mocks
@kbn/core-status-common src/core/packages/status/common
@kbn/core-status-server src/core/packages/status/server
@kbn/core-status-server-internal src/core/packages/status/server-internal
@kbn/core-test-helpers-deprecations-getters src/core/packages/test-helpers/deprecations-getters
@kbn/core-test-helpers-http-setup-browser src/core/packages/test-helpers/http-setup-browser
@kbn/core-test-helpers-so-type-serializer src/core/packages/test-helpers/so-type-serializer
@kbn/core-test-helpers-test-utils src/core/packages/test-helpers/test-utils
@kbn/core-theme-browser src/core/packages/theme/browser
@kbn/core-theme-browser-internal src/core/packages/theme/browser-internal
@kbn/core-ui-settings-browser src/core/packages/ui-settings/browser
@kbn/core-ui-settings-browser-internal src/core/packages/ui-settings/browser-internal
@kbn/core-ui-settings-common src/core/packages/ui-settings/common
@kbn/core-ui-settings-server src/core/packages/ui-settings/server
@kbn/core-ui-settings-server-internal src/core/packages/ui-settings/server-internal
@kbn/core-usage-data-base-server-internal src/core/packages/usage-data/base-server-internal
@kbn/core-usage-data-server src/core/packages/usage-data/server
@kbn/core-usage-data-server-internal src/core/packages/usage-data/server-internal
@kbn/core-user-profile-browser src/core/packages/user-profile/browser
@kbn/core-user-profile-browser-internal src/core/packages/user-profile/browser-internal
@kbn/core-user-profile-browser-mocks src/core/packages/user-profile/browser-mocks
@kbn/core-user-profile-common src/core/packages/user-profile/common
@kbn/core-user-profile-server src/core/packages/user-profile/server
@kbn/core-user-profile-server-internal src/core/packages/user-profile/server-internal
@kbn/core-user-profile-server-mocks src/core/packages/user-profile/server-mocks
@kbn/core-user-settings-server src/core/packages/user-settings/server
@kbn/core-user-settings-server-internal src/core/packages/user-settings/server-internal
@kbn/core-user-settings-server-mocks src/core/packages/user-settings/server-mocks
Updated references 
./docs/developer/advanced/sharing-saved-objects.asciidoc
./docs/developer/architecture/core/http-service.asciidoc
./docs/developer/architecture/core/patterns-scoped-services.asciidoc
./docs/developer/architecture/core/saved-objects-service.asciidoc
./docs/developer/architecture/core/uisettings-service.asciidoc
./docs/developer/architecture/kibana-platform-plugin-api.asciidoc
./docs/developer/best-practices/navigation.asciidoc
./package.json
./packages/core/custom-branding/core-custom-branding-common/index.ts
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./src/core/packages/apps/server-internal/assets/legacy_theme.js
./src/core/packages/base/common-internal/jest.config.js
./src/core/packages/base/server-internal/jest.config.js
./src/core/packages/capabilities/browser-internal/jest.config.js
./src/core/packages/capabilities/common/jest.config.js
./src/core/packages/capabilities/server-internal/jest.config.js
./src/core/packages/capabilities/server/jest.config.js
./src/core/packages/chrome/browser-internal/jest.config.js
./src/core/packages/chrome/browser/jest.config.js
./src/core/packages/config/server-internal/jest.config.js
./src/core/packages/custom-branding/browser-internal/jest.config.js
./src/core/packages/custom-branding/browser-mocks/jest.config.js
./src/core/packages/custom-branding/server-internal/jest.config.js
./src/core/packages/custom-branding/server-mocks/jest.config.js
./src/core/packages/deprecations/browser-internal/jest.config.js
./src/core/packages/deprecations/browser/jest.config.js
./src/core/packages/deprecations/common/jest.config.js
./src/core/packages/deprecations/server-internal/jest.config.js
./src/core/packages/deprecations/server/jest.config.js
./src/core/packages/doc-links/browser-internal/jest.config.js
./src/core/packages/doc-links/browser/jest.config.js
./src/core/packages/doc-links/server-internal/jest.config.js
./src/core/packages/doc-links/server/jest.config.js
./src/core/packages/elasticsearch/client-server-internal/jest.config.js
./src/core/packages/elasticsearch/server-internal/jest.config.js
./src/core/packages/elasticsearch/server/jest.config.js
./src/core/packages/environment/server-internal/jest.config.js
./src/core/packages/execution-context/browser-internal/jest.config.js
./src/core/packages/execution-context/browser/jest.config.js
./src/core/packages/execution-context/common/jest.config.js
./src/core/packages/execution-context/server-internal/jest.config.js
./src/core/packages/execution-context/server/jest.config.js
./src/core/packages/fatal-errors/browser-internal/jest.config.js
./src/core/packages/fatal-errors/browser/jest.config.js
./src/core/packages/feature-flags/browser-internal/jest.config.js
./src/core/packages/feature-flags/browser-mocks/jest.config.js
./src/core/packages/feature-flags/server-internal/jest.config.js
./src/core/packages/feature-flags/server-mocks/jest.config.js
./src/core/packages/http/browser-internal/jest.config.js
./src/core/packages/http/browser/jest.config.js
./src/core/packages/http/common/jest.config.js
./src/core/packages/http/context-server-internal/jest.config.js
./src/core/packages/http/request-handler-context-server-internal/jest.config.js
./src/core/packages/http/request-handler-context-server/jest.config.js
./src/core/packages/http/resources-server-internal/jest.config.js
./src/core/packages/http/resources-server/jest.config.js
./src/core/packages/http/router-server-internal/jest.config.js
./src/core/packages/http/server-internal/jest.config.js
./src/core/packages/http/server-utils/jest.config.js
./src/core/packages/http/server/jest.config.js
./src/core/packages/i18n/browser-internal/jest.config.js
./src/core/packages/i18n/browser/jest.config.js
./src/core/packages/i18n/server-internal/jest.config.js
./src/core/packages/i18n/server/jest.config.js
./src/core/packages/injected-metadata/browser-internal/jest.config.js
./src/core/packages/injected-metadata/common-internal/jest.config.js
./src/core/packages/integrations/browser-internal/jest.config.js
./src/core/packages/lifecycle/browser-internal/jest.config.js
./src/core/packages/lifecycle/browser/jest.config.js
./src/core/packages/lifecycle/server-internal/jest.config.js
./src/core/packages/lifecycle/server/jest.config.js
./src/core/packages/logging/browser-internal/jest.config.js
./src/core/packages/logging/common-internal/jest.config.js
./src/core/packages/logging/server-internal/jest.config.js
./src/core/packages/logging/server/jest.config.js
./src/core/packages/metrics/collectors-server-internal/jest.config.js
./src/core/packages/metrics/server-internal/jest.config.js
./src/core/packages/metrics/server/jest.config.js
./src/core/packages/mount-utils/browser-internal/jest.config.js
./src/core/packages/mount-utils/browser/jest.config.js
./src/core/packages/node/server-internal/jest.config.js
./src/core/packages/node/server/jest.config.js
./src/core/packages/notifications/browser-internal/jest.config.js
./src/core/packages/notifications/browser/jest.config.js
./src/core/packages/overlays/browser-internal/jest.config.js
./src/core/packages/overlays/browser/jest.config.js
./src/core/packages/plugins/base-server-internal/jest.config.js
./src/core/packages/plugins/browser-internal/jest.config.js
./src/core/packages/plugins/browser/jest.config.js
./src/core/packages/plugins/contracts-browser/jest.config.js
./src/core/packages/plugins/contracts-server/jest.config.js
./src/core/packages/plugins/server-internal/jest.config.js
./src/core/packages/plugins/server/jest.config.js
./src/core/packages/preboot/server-internal/jest.config.js
./src/core/packages/preboot/server/jest.config.js
./src/core/packages/rendering/browser-internal/jest.config.js
./src/core/packages/rendering/browser/jest.config.js
./src/core/packages/rendering/server-internal/jest.config.js
./src/core/packages/root/browser-internal/jest.config.js
./src/core/packages/root/server-internal/jest.config.js
./src/core/packages/saved-objects/api-browser/jest.config.js
./src/core/packages/saved-objects/api-server-internal/jest.config.js
./src/core/packages/saved-objects/api-server/jest.config.js
./src/core/packages/saved-objects/base-server-internal/jest.config.js
./src/core/packages/saved-objects/browser-internal/jest.config.js
./src/core/packages/saved-objects/browser/jest.config.js
./src/core/packages/saved-objects/common/jest.config.js
./src/core/packages/saved-objects/import-export-server-internal/jest.config.js
./src/core/packages/saved-objects/migration-server-internal/jest.config.js
./src/core/packages/saved-objects/server-internal/jest.config.js
./src/core/packages/saved-objects/server/docs/model_versions.md
./src/core/packages/saved-objects/server/jest.config.js
./src/core/packages/saved-objects/utils-server/jest.config.js
./src/core/packages/security/browser-internal/jest.config.js
./src/core/packages/security/browser-mocks/jest.config.js
./src/core/packages/security/browser/jest.config.js
./src/core/packages/security/common/jest.config.js
./src/core/packages/security/server-internal/jest.config.js
./src/core/packages/security/server-mocks/jest.config.js
./src/core/packages/security/server/jest.config.js
./src/core/packages/status/common/jest.config.js
./src/core/packages/status/server-internal/jest.config.js
./src/core/packages/status/server/jest.config.js
./src/core/packages/test-helpers/deprecations-getters/jest.config.js
./src/core/packages/test-helpers/http-setup-browser/jest.config.js
./src/core/packages/test-helpers/so-type-serializer/jest.config.js
./src/core/packages/test-helpers/test-utils/jest.config.js
./src/core/packages/theme/browser-internal/jest.config.js
./src/core/packages/theme/browser/jest.config.js
./src/core/packages/ui-settings/browser-internal/jest.config.js
./src/core/packages/ui-settings/browser/jest.config.js
./src/core/packages/ui-settings/common/jest.config.js
./src/core/packages/ui-settings/server-internal/jest.config.js
./src/core/packages/ui-settings/server/jest.config.js
./src/core/packages/usage-data/base-server-internal/jest.config.js
./src/core/packages/usage-data/server-internal/jest.config.js
./src/core/packages/usage-data/server/jest.config.js
./src/core/packages/user-profile/browser-internal/jest.config.js
./src/core/packages/user-profile/browser-mocks/jest.config.js
./src/core/packages/user-profile/browser/jest.config.js
./src/core/packages/user-profile/common/jest.config.js
./src/core/packages/user-profile/server-internal/jest.config.js
./src/core/packages/user-profile/server-mocks/jest.config.js
./src/core/packages/user-profile/server/jest.config.js
./src/core/packages/user-settings/server-internal/jest.config.js
./src/core/packages/user-settings/server-mocks/jest.config.js
./src/plugins/usage_collection/common/types/stats/core_metrics.ts
./tsconfig.base.json
./x-pack/platform/plugins/private/transform/public/app/common/time_zone_utils.ts
./x-pack/plugins/cases/server/connectors/cases/retry_service.ts
./x-pack/plugins/encrypted_saved_objects/server/create_model_version.ts
./x-pack/plugins/fleet/server/services/debug/index.ts
./x-pack/solutions/security/plugins/security_solution/docs/rfcs/detection_response/prebuilt_rules_customization.md
./yarn.lock
.github/CODEOWNERS
Updated relative paths 
src/core/packages/base/common-internal/jest.config.js:12
src/core/packages/base/common-internal/tsconfig.json:2
src/core/packages/base/server-internal/jest.config.js:12
src/core/packages/base/server-internal/tsconfig.json:2
src/core/packages/capabilities/browser-internal/jest.config.js:12
src/core/packages/capabilities/browser-internal/tsconfig.json:2
src/core/packages/capabilities/common/jest.config.js:12
src/core/packages/capabilities/common/tsconfig.json:2
src/core/packages/capabilities/server-internal/jest.config.js:12
src/core/packages/capabilities/server-internal/tsconfig.json:2
src/core/packages/capabilities/server/jest.config.js:12
src/core/packages/capabilities/server/tsconfig.json:2
src/core/packages/chrome/browser-internal/jest.config.js:12
src/core/packages/chrome/browser-internal/tsconfig.json:2
src/core/packages/chrome/browser/jest.config.js:12
src/core/packages/chrome/browser/tsconfig.json:2
src/core/packages/config/server-internal/jest.config.js:12
src/core/packages/config/server-internal/tsconfig.json:2
src/core/packages/custom-branding/browser-internal/jest.config.js:12
src/core/packages/custom-branding/browser-internal/tsconfig.json:2
src/core/packages/custom-branding/browser-mocks/jest.config.js:12
src/core/packages/custom-branding/browser-mocks/tsconfig.json:2
src/core/packages/custom-branding/browser/tsconfig.json:2
src/core/packages/custom-branding/common/tsconfig.json:2
src/core/packages/custom-branding/server-internal/jest.config.js:12
src/core/packages/custom-branding/server-internal/tsconfig.json:2
src/core/packages/custom-branding/server-mocks/jest.config.js:12
src/core/packages/custom-branding/server-mocks/tsconfig.json:2
src/core/packages/custom-branding/server/tsconfig.json:2
src/core/packages/deprecations/browser-internal/jest.config.js:12
src/core/packages/deprecations/browser-internal/tsconfig.json:2
src/core/packages/deprecations/browser/jest.config.js:12
src/core/packages/deprecations/browser/tsconfig.json:2
src/core/packages/deprecations/common/jest.config.js:12
src/core/packages/deprecations/common/tsconfig.json:2
src/core/packages/deprecations/server-internal/jest.config.js:12
src/core/packages/deprecations/server-internal/tsconfig.json:2
src/core/packages/deprecations/server/jest.config.js:12
src/core/packages/deprecations/server/tsconfig.json:2
src/core/packages/doc-links/browser-internal/jest.config.js:12
src/core/packages/doc-links/browser-internal/tsconfig.json:2
src/core/packages/doc-links/browser/jest.config.js:12
src/core/packages/doc-links/browser/tsconfig.json:2
src/core/packages/doc-links/server-internal/jest.config.js:12
src/core/packages/doc-links/server-internal/tsconfig.json:2
src/core/packages/doc-links/server/jest.config.js:12
src/core/packages/doc-links/server/tsconfig.json:2
src/core/packages/elasticsearch/client-server-internal/jest.config.js:12
src/core/packages/elasticsearch/client-server-internal/tsconfig.json:2
src/core/packages/elasticsearch/server-internal/jest.config.js:12
src/core/packages/elasticsearch/server-internal/tsconfig.json:2
src/core/packages/elasticsearch/server/jest.config.js:12
src/core/packages/elasticsearch/server/tsconfig.json:2
src/core/packages/environment/server-internal/jest.config.js:12
src/core/packages/environment/server-internal/tsconfig.json:2
src/core/packages/execution-context/browser-internal/jest.config.js:12
src/core/packages/execution-context/browser-internal/tsconfig.json:2
src/core/packages/execution-context/browser/jest.config.js:12
src/core/packages/execution-context/browser/tsconfig.json:2
src/core/packages/execution-context/common/jest.config.js:12
src/core/packages/execution-context/common/tsconfig.json:2
src/core/packages/execution-context/server-internal/jest.config.js:12
src/core/packages/execution-context/server-internal/tsconfig.json:2
src/core/packages/execution-context/server/jest.config.js:12
src/core/packages/execution-context/server/tsconfig.json:2
src/core/packages/fatal-errors/browser-internal/jest.config.js:12
src/core/packages/fatal-errors/browser-internal/tsconfig.json:2
src/core/packages/fatal-errors/browser/jest.config.js:12
src/core/packages/fatal-errors/browser/tsconfig.json:2
src/core/packages/feature-flags/browser-internal/jest.config.js:12
src/core/packages/feature-flags/browser-internal/tsconfig.json:2
src/core/packages/feature-flags/browser-mocks/jest.config.js:12
src/core/packages/feature-flags/browser-mocks/tsconfig.json:2
src/core/packages/feature-flags/browser/tsconfig.json:2
src/core/packages/feature-flags/server-internal/jest.config.js:12
src/core/packages/feature-flags/server-internal/tsconfig.json:2
src/core/packages/feature-flags/server-mocks/jest.config.js:12
src/core/packages/feature-flags/server-mocks/tsconfig.json:2
src/core/packages/feature-flags/server/tsconfig.json:2
src/core/packages/http/browser-internal/jest.config.js:12
src/core/packages/http/browser-internal/src/external_url_service.test.ts:132
src/core/packages/http/browser-internal/src/external_url_service.test.ts:158
src/core/packages/http/browser-internal/src/external_url_service.test.ts:199
src/core/packages/http/browser-internal/tsconfig.json:2
src/core/packages/http/browser/jest.config.js:12
src/core/packages/http/browser/tsconfig.json:2
src/core/packages/http/common/jest.config.js:12
src/core/packages/http/common/tsconfig.json:2
src/core/packages/http/context-server-internal/jest.config.js:12
src/core/packages/http/context-server-internal/tsconfig.json:2
src/core/packages/http/request-handler-context-server-internal/jest.config.js:12
src/core/packages/http/request-handler-context-server-internal/tsconfig.json:2
src/core/packages/http/request-handler-context-server/jest.config.js:12
src/core/packages/http/request-handler-context-server/tsconfig.json:2
src/core/packages/http/resources-server-internal/jest.config.js:12
src/core/packages/http/resources-server-internal/tsconfig.json:2
src/core/packages/http/resources-server/jest.config.js:12
src/core/packages/http/resources-server/tsconfig.json:2
src/core/packages/http/router-server-internal/jest.config.js:12
src/core/packages/http/router-server-internal/tsconfig.json:2
src/core/packages/http/server-internal/jest.config.js:12
src/core/packages/http/server-internal/tsconfig.json:2
src/core/packages/http/server-utils/jest.config.js:12
src/core/packages/http/server-utils/tsconfig.json:2
src/core/packages/http/server/jest.config.js:12
src/core/packages/http/server/tsconfig.json:2
src/core/packages/i18n/browser-internal/jest.config.js:12
src/core/packages/i18n/browser-internal/tsconfig.json:2
src/core/packages/i18n/browser/jest.config.js:12
src/core/packages/i18n/browser/tsconfig.json:2
src/core/packages/i18n/server-internal/jest.config.js:12
src/core/packages/i18n/server-internal/tsconfig.json:2
src/core/packages/i18n/server/jest.config.js:12
src/core/packages/i18n/server/tsconfig.json:2
src/core/packages/injected-metadata/browser-internal/jest.config.js:12
src/core/packages/injected-metadata/browser-internal/tsconfig.json:2
src/core/packages/injected-metadata/common-internal/jest.config.js:12
src/core/packages/injected-metadata/common-internal/tsconfig.json:2
src/core/packages/integrations/browser-internal/jest.config.js:12
src/core/packages/integrations/browser-internal/tsconfig.json:2
src/core/packages/lifecycle/browser-internal/jest.config.js:12
src/core/packages/lifecycle/browser-internal/tsconfig.json:2
src/core/packages/lifecycle/browser/jest.config.js:12
src/core/packages/lifecycle/browser/tsconfig.json:2
src/core/packages/lifecycle/server-internal/jest.config.js:12
src/core/packages/lifecycle/server-internal/tsconfig.json:2
src/core/packages/lifecycle/server/jest.config.js:12
src/core/packages/lifecycle/server/tsconfig.json:2
src/core/packages/logging/browser-internal/jest.config.js:12
src/core/packages/logging/browser-internal/tsconfig.json:2
src/core/packages/logging/common-internal/jest.config.js:12
src/core/packages/logging/common-internal/tsconfig.json:2
src/core/packages/logging/server-internal/jest.config.js:12
src/core/packages/logging/server-internal/tsconfig.json:2
src/core/packages/logging/server/jest.config.js:12
src/core/packages/logging/server/tsconfig.json:2
src/core/packages/metrics/collectors-server-internal/jest.config.js:12
src/core/packages/metrics/collectors-server-internal/tsconfig.json:2
src/core/packages/metrics/server-internal/jest.config.js:12
src/core/packages/metrics/server-internal/tsconfig.json:2
src/core/packages/metrics/server/jest.config.js:12
src/core/packages/metrics/server/tsconfig.json:2
src/core/packages/mount-utils/browser-internal/jest.config.js:12
src/core/packages/mount-utils/browser-internal/tsconfig.json:2
src/core/packages/mount-utils/browser/jest.config.js:12
src/core/packages/mount-utils/browser/tsconfig.json:2
src/core/packages/node/server-internal/jest.config.js:12
src/core/packages/node/server-internal/tsconfig.json:2
src/core/packages/node/server/jest.config.js:12
src/core/packages/node/server/tsconfig.json:2
src/core/packages/notifications/browser-internal/jest.config.js:12
src/core/packages/notifications/browser-internal/tsconfig.json:2
src/core/packages/notifications/browser/jest.config.js:12
src/core/packages/notifications/browser/tsconfig.json:2
src/core/packages/overlays/browser-internal/jest.config.js:12
src/core/packages/overlays/browser-internal/tsconfig.json:15
src/core/packages/overlays/browser-internal/tsconfig.json:2
src/core/packages/overlays/browser/jest.config.js:12
src/core/packages/overlays/browser/tsconfig.json:2
src/core/packages/plugins/base-server-internal/jest.config.js:12
src/core/packages/plugins/base-server-internal/tsconfig.json:2
src/core/packages/plugins/browser-internal/jest.config.js:12
src/core/packages/plugins/browser-internal/tsconfig.json:2
src/core/packages/plugins/browser/jest.config.js:12
src/core/packages/plugins/browser/tsconfig.json:2
src/core/packages/plugins/contracts-browser/jest.config.js:12
src/core/packages/plugins/contracts-browser/tsconfig.json:2
src/core/packages/plugins/contracts-server/jest.config.js:12
src/core/packages/plugins/contracts-server/tsconfig.json:2
src/core/packages/plugins/server-internal/jest.config.js:12
src/core/packages/plugins/server-internal/tsconfig.json:2
src/core/packages/plugins/server/jest.config.js:12
src/core/packages/plugins/server/tsconfig.json:2
src/core/packages/preboot/server-internal/jest.config.js:12
src/core/packages/preboot/server-internal/tsconfig.json:2
src/core/packages/preboot/server/jest.config.js:12
src/core/packages/preboot/server/tsconfig.json:2
src/core/packages/rendering/browser-internal/jest.config.js:12
src/core/packages/rendering/browser-internal/tsconfig.json:2
src/core/packages/rendering/browser/jest.config.js:12
src/core/packages/rendering/browser/tsconfig.json:2
src/core/packages/rendering/server-internal/jest.config.js:12
src/core/packages/rendering/server-internal/tsconfig.json:2
src/core/packages/root/browser-internal/jest.config.js:12
src/core/packages/root/browser-internal/tsconfig.json:2
src/core/packages/root/server-internal/jest.config.js:12
src/core/packages/root/server-internal/tsconfig.json:2
src/core/packages/saved-objects/api-browser/jest.config.js:12
src/core/packages/saved-objects/api-browser/tsconfig.json:2
src/core/packages/saved-objects/api-server-internal/jest.config.js:12
src/core/packages/saved-objects/api-server-internal/tsconfig.json:2
src/core/packages/saved-objects/api-server/jest.config.js:12
src/core/packages/saved-objects/api-server/tsconfig.json:2
src/core/packages/saved-objects/base-server-internal/jest.config.js:12
src/core/packages/saved-objects/base-server-internal/tsconfig.json:2
src/core/packages/saved-objects/browser-internal/jest.config.js:12
src/core/packages/saved-objects/browser-internal/tsconfig.json:2
src/core/packages/saved-objects/browser/jest.config.js:12
src/core/packages/saved-objects/browser/tsconfig.json:2
src/core/packages/saved-objects/common/jest.config.js:12
src/core/packages/saved-objects/common/tsconfig.json:2
src/core/packages/saved-objects/import-export-server-internal/jest.config.js:12
src/core/packages/saved-objects/import-export-server-internal/tsconfig.json:2
src/core/packages/saved-objects/migration-server-internal/jest.config.js:12
src/core/packages/saved-objects/migration-server-internal/tsconfig.json:2
src/core/packages/saved-objects/server-internal/jest.config.js:12
src/core/packages/saved-objects/server-internal/tsconfig.json:2
src/core/packages/saved-objects/server/jest.config.js:12
src/core/packages/saved-objects/server/tsconfig.json:2
src/core/packages/saved-objects/utils-server/jest.config.js:12
src/core/packages/saved-objects/utils-server/tsconfig.json:2
src/core/packages/security/browser-internal/jest.config.js:12
src/core/packages/security/browser-internal/tsconfig.json:2
src/core/packages/security/browser-mocks/jest.config.js:12
src/core/packages/security/browser-mocks/tsconfig.json:2
src/core/packages/security/browser/jest.config.js:12
src/core/packages/security/browser/tsconfig.json:2
src/core/packages/security/common/jest.config.js:12
src/core/packages/security/common/tsconfig.json:2
src/core/packages/security/server-internal/jest.config.js:12
src/core/packages/security/server-internal/tsconfig.json:2
src/core/packages/security/server-mocks/jest.config.js:12
src/core/packages/security/server-mocks/tsconfig.json:2
src/core/packages/security/server/jest.config.js:12
src/core/packages/security/server/tsconfig.json:2
src/core/packages/status/common/jest.config.js:12
src/core/packages/status/common/tsconfig.json:2
src/core/packages/status/server-internal/jest.config.js:12
src/core/packages/status/server-internal/tsconfig.json:2
src/core/packages/status/server/jest.config.js:12
src/core/packages/status/server/tsconfig.json:2
src/core/packages/test-helpers/deprecations-getters/jest.config.js:12
src/core/packages/test-helpers/deprecations-getters/tsconfig.json:2
src/core/packages/test-helpers/http-setup-browser/jest.config.js:12
src/core/packages/test-helpers/http-setup-browser/tsconfig.json:2
src/core/packages/test-helpers/so-type-serializer/jest.config.js:12
src/core/packages/test-helpers/so-type-serializer/tsconfig.json:2
src/core/packages/test-helpers/test-utils/jest.config.js:12
src/core/packages/test-helpers/test-utils/tsconfig.json:2
src/core/packages/theme/browser-internal/jest.config.js:12
src/core/packages/theme/browser-internal/tsconfig.json:2
src/core/packages/theme/browser/jest.config.js:12
src/core/packages/theme/browser/tsconfig.json:2
src/core/packages/ui-settings/browser-internal/jest.config.js:12
src/core/packages/ui-settings/browser-internal/tsconfig.json:2
src/core/packages/ui-settings/browser/jest.config.js:12
src/core/packages/ui-settings/browser/tsconfig.json:2
src/core/packages/ui-settings/common/jest.config.js:12
src/core/packages/ui-settings/common/tsconfig.json:2
src/core/packages/ui-settings/server-internal/jest.config.js:12
src/core/packages/ui-settings/server-internal/tsconfig.json:2
src/core/packages/ui-settings/server/jest.config.js:12
src/core/packages/ui-settings/server/tsconfig.json:2
src/core/packages/usage-data/base-server-internal/jest.config.js:12
src/core/packages/usage-data/base-server-internal/tsconfig.json:2
src/core/packages/usage-data/server-internal/jest.config.js:12
src/core/packages/usage-data/server-internal/tsconfig.json:2
src/core/packages/usage-data/server/jest.config.js:12
src/core/packages/usage-data/server/tsconfig.json:2
src/core/packages/user-profile/browser-internal/jest.config.js:12
src/core/packages/user-profile/browser-internal/tsconfig.json:2
src/core/packages/user-profile/browser-mocks/jest.config.js:12
src/core/packages/user-profile/browser-mocks/tsconfig.json:2
src/core/packages/user-profile/browser/jest.config.js:12
src/core/packages/user-profile/browser/tsconfig.json:2
src/core/packages/user-profile/common/jest.config.js:12
src/core/packages/user-profile/common/tsconfig.json:2
src/core/packages/user-profile/server-internal/jest.config.js:12
src/core/packages/user-profile/server-internal/tsconfig.json:2
src/core/packages/user-profile/server-mocks/jest.config.js:12
src/core/packages/user-profile/server-mocks/tsconfig.json:2
src/core/packages/user-profile/server/jest.config.js:12
src/core/packages/user-profile/server/tsconfig.json:2
src/core/packages/user-settings/server-internal/jest.config.js:12
src/core/packages/user-settings/server-internal/tsconfig.json:2
src/core/packages/user-settings/server-mocks/jest.config.js:12
src/core/packages/user-settings/server-mocks/tsconfig.json:2
src/core/packages/user-settings/server/tsconfig.json:2

@github-actions GitHub Actions
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) plugin groups Relocate all plugins and packages under their respective platform/solution groups labels Dec 18, 2024
@gsoldevila gsoldevila marked this pull request as ready for review December 18, 2024 20:17
@gsoldevila gsoldevila requested review from a team as code owners December 18, 2024 20:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@gsoldevila gsoldevila requested review from a team as code owners December 18, 2024 20:17
@gsoldevila gsoldevila requested review from jpdjere and rylnd December 18, 2024 20:17
ryankeairns
ryankeairns approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCSS only

azasypkin
azasypkin approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, GitHub doesn’t allow me to see which files are owned by our team, but I’ve reviewed the following locations, and everything looks correct:

  • @kbn/core-security-*
  • @kbn/core-user-profile-*
  • @kbn/core-user-settings-*

@gsoldevila
Relocating module @kbn/core-ui-settings-browser
992ce91
@gsoldevila
Relocating module @kbn/core-ui-settings-browser-internal
cdbe16f
@gsoldevila
Relocating module @kbn/core-ui-settings-common
646ab25
@gsoldevila
Relocating module @kbn/core-ui-settings-server
1862710
@gsoldevila
Relocating module @kbn/core-ui-settings-server-internal
c772efc
@gsoldevila
Relocating module @kbn/core-usage-data-base-server-internal
16f0e60
@gsoldevila
Relocating module @kbn/core-usage-data-server
537c0ee
@gsoldevila
Relocating module @kbn/core-usage-data-server-internal
7683f57
@gsoldevila
Relocating module @kbn/core-user-profile-browser
178f02b
@gsoldevila
Relocating module @kbn/core-user-profile-browser-internal
e792636
@gsoldevila
Relocating module @kbn/core-user-profile-browser-mocks
43c791c
@gsoldevila
Relocating module @kbn/core-user-profile-common
936e340
@gsoldevila
Relocating module @kbn/core-user-profile-server
419332f
@gsoldevila
Relocating module @kbn/core-user-profile-server-internal
759930b
@gsoldevila
Relocating module @kbn/core-user-profile-server-mocks
b356312
@gsoldevila
Relocating module @kbn/core-user-settings-server
fb3a76d
@gsoldevila
Relocating module @kbn/core-user-settings-server-internal
dbea7ba
@gsoldevila
Relocating module @kbn/core-user-settings-server-mocks
9356ef6
@gsoldevila gsoldevila force-pushed the kbn-team-1309-relocate-20241218165017 branch from 0fac98e to 9356ef6 Compare December 24, 2024 06:51
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/core 38 825 +787
@kbn/core-base-server-internal 2 0 -2
@kbn/core-capabilities-browser-internal 2 0 -2
@kbn/core-chrome-browser-internal 1 0 -1
@kbn/core-custom-branding-server-internal 1 0 -1
@kbn/core-elasticsearch-client-server-internal 1 0 -1
@kbn/core-elasticsearch-server-internal 3 0 -3
@kbn/core-environment-server-internal 1 0 -1
@kbn/core-execution-context-browser 1 0 -1
@kbn/core-execution-context-browser-internal 2 0 -2
@kbn/core-execution-context-server-internal 1 0 -1
@kbn/core-http-browser-internal 2 0 -2
@kbn/core-http-context-server-internal 1 0 -1
@kbn/core-http-resources-server-internal 3 0 -3
@kbn/core-http-router-server-internal 6 0 -6
@kbn/core-http-server-internal 10 0 -10
@kbn/core-i18n-server-internal 2 0 -2
@kbn/core-injected-metadata-browser-internal 1 0 -1
@kbn/core-injected-metadata-common-internal 4 0 -4
@kbn/core-lifecycle-server-internal 3 0 -3
@kbn/core-logging-browser-internal 1 0 -1
@kbn/core-logging-server-internal 2 0 -2
@kbn/core-node-server-internal 1 0 -1
@kbn/core-notifications-browser-internal 2 0 -2
@kbn/core-overlays-browser-internal 1 0 -1
@kbn/core-plugins-browser-internal 1 0 -1
@kbn/core-plugins-server-internal 2 0 -2
@kbn/core-preboot-server-internal 1 0 -1
@kbn/core-rendering-server-internal 1 0 -1
@kbn/core-saved-objects-api-server 2 0 -2
@kbn/core-saved-objects-api-server-internal 1 0 -1
@kbn/core-saved-objects-base-server-internal 11 0 -11
@kbn/core-saved-objects-migration-server-internal 44 0 -44
@kbn/core-saved-objects-server 4 0 -4
@kbn/core-saved-objects-server-internal 5 0 -5
@kbn/core-security-common 1 0 -1
@kbn/core-security-server-mocks 2 0 -2
@kbn/core-status-server-internal 3 0 -3
@kbn/core-test-helpers-so-type-serializer 1 0 -1
@kbn/core-ui-settings-browser 1 0 -1
@kbn/core-ui-settings-browser-internal 3 0 -3
@kbn/core-ui-settings-server-internal 3 0 -3
@kbn/core-usage-data-base-server-internal 6 0 -6
@kbn/core-usage-data-server-internal 2 0 -2
@kbn/core-user-settings-server-internal 2 0 -2
total +637
Unknown metric groups

References to deprecated APIs

id before after diff
@kbn/core 35 619 +584
@kbn/core-capabilities-server-internal 1 0 -1
@kbn/core-elasticsearch-server-internal 2 0 -2
@kbn/core-http-router-server-internal 13 0 -13
@kbn/core-http-server-internal 4 0 -4
@kbn/core-i18n-server-internal 1 0 -1
@kbn/core-lifecycle-browser 3 0 -3
@kbn/core-logging-server-internal 6 0 -6
@kbn/core-metrics-server-internal 1 0 -1
@kbn/core-plugins-browser-internal 5 0 -5
@kbn/core-plugins-server-internal 8 0 -8
@kbn/core-rendering-server-internal 1 0 -1
@kbn/core-root-browser-internal 4 0 -4
@kbn/core-saved-objects-api-browser 27 0 -27
@kbn/core-saved-objects-api-server 5 0 -5
@kbn/core-saved-objects-api-server-internal 25 0 -25
@kbn/core-saved-objects-base-server-internal 23 0 -23
@kbn/core-saved-objects-browser 3 0 -3
@kbn/core-saved-objects-browser-internal 175 0 -175
@kbn/core-saved-objects-common 6 0 -6
@kbn/core-saved-objects-import-export-server-internal 19 0 -19
@kbn/core-saved-objects-migration-server-internal 107 0 -107
@kbn/core-saved-objects-server 1 0 -1
@kbn/core-saved-objects-server-internal 10 0 -10
@kbn/core-status-server-internal 2 0 -2
@kbn/core-test-helpers-so-type-serializer 33 0 -33
@kbn/core-ui-settings-server-internal 4 0 -4
@kbn/core-usage-data-server-internal 1 0 -1
total +94

Unreferenced deprecated APIs

id before after diff
@kbn/core-saved-objects-api-browser 2 0 -2

History

@Dosant Dosant mentioned this pull request Jan 2, 2025
Closed
9 tasks
@banderror banderror requested review from jkelas and removed request for jpdjere January 2, 2025 16:19
rylnd
rylnd approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection Engine changes LGTM: there's a single file changed (x-pack/solutions/security/plugins/security_solution/docs/rfcs/detection_response/prebuilt_rules_customization.md).

@jkelas
Copy link
Contributor

jkelas commented Jan 3, 2025

I confirm that from the perspective of security-detection-rule-management team, the changes are fine.
There was only 1 file changed that we own (together with the detection-engine team), the
pack/solutions/security/plugins/security_solution/docs/rfcs/detection_response/prebuilt_rules_customization.md. It looks good.

jkelas
jkelas approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@jkelas jkelas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On behalf of the security-detection-rule-management team I approve these changes.

@eokoneyo eokoneyo mentioned this pull request Jan 6, 2025
Closed
@Dosant
Copy link
Contributor

Dosant commented Jan 6, 2025

Can be closed because most of the modules were moved in #201653, For other modules easier to create new PRs then merge

@Dosant Dosant closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkelas jkelas jkelas approved these changes

@azasypkin azasypkin azasypkin approved these changes

@rylnd rylnd rylnd approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) plugin groups Relocate all plugins and packages under their respective platform/solution groups release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gsoldevila @elasticmachine @jkelas @Dosant @ryankeairns @rylnd @azasypkin @kibanamachine