Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UA] kibana-core ownership #203410

Merged
merged 2 commits into from
Dec 9, 2024
Merged

[UA] kibana-core ownership #203410

merged 2 commits into from
Dec 9, 2024

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Dec 9, 2024 •
edited by kibanamachine
Loading

Summary

As Core will be driving a lot of the development for UA for 8->9 this PR makes kibana-core the temporary code owners for UA until we've completed the 9.0 release.

@jloleysens jloleysens added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant backport:version Backport to applied version labels v8.18.0 v8.17.1 labels Dec 9, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@jloleysens jloleysens changed the title [UA] Add kibana-core to all UA ownership entries [UA] kibana-core ownership Dec 9, 2024
alisonelizabeth
alisonelizabeth approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thank you!

@jloleysens jloleysens enabled auto-merge (squash) December 9, 2024 13:14
@jloleysens jloleysens merged commit 55d5c7a into elastic:main Dec 9, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12238062260

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.17 Backport failed because of merge conflicts
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 203410

Questions ?

Please refer to the Backport tool documentation

@jloleysens jloleysens deleted the ua/core-ownership branch December 9, 2024 15:09
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 9, 2024
@jloleysens
[UA] kibana-core ownership (elastic#203410)
672e1c2 
## Summary

As Core will be driving a lot of the development for UA for 8->9 this PR
makes `kibana-core` the temporary code owners for UA until we've
completed the 9.0 release.

(cherry picked from commit 55d5c7a)

# Conflicts:
#	.github/CODEOWNERS
@jloleysens jloleysens mentioned this pull request Dec 9, 2024
Closed
@jloleysens
Copy link
Contributor Author

💔 Some backports could not be created

Status Branch Result
✅ 8.x
❌ 8.17 Could not create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between elastic:8.17 and jloleysens:backport/8.17/pr-203410"}

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 203410

Questions ?

Please refer to the Backport tool documentation

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@jloleysens @CAWilson94
[UA] kibana-core ownership (elastic#203410)
2ecf7b4 
## Summary

As Core will be driving a lot of the development for UA for 8->9 this PR
makes `kibana-core` the temporary code owners for UA until we've
completed the 9.0 release.
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
@jloleysens @Samiul-TheSoccerFan
[UA] kibana-core ownership (elastic#203410)
103f42b 
## Summary

As Core will be driving a lot of the development for UA for 8->9 this PR
makes `kibana-core` the temporary code owners for UA until we've
completed the 9.0 release.
This was referenced Dec 10, 2024
Merged
Merged
This was referenced Dec 10, 2024
Merged
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 11, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

This was referenced Dec 11, 2024
Merged
Merged
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@jloleysens @CAWilson94
[UA] kibana-core ownership (elastic#203410)
fcf0aea 
## Summary

As Core will be driving a lot of the development for UA for 8->9 this PR
makes `kibana-core` the temporary code owners for UA until we've
completed the 9.0 release.
This was referenced Dec 12, 2024
Merged
Merged
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203410 locally

This was referenced Dec 12, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203410 locally

@jloleysens jloleysens added the backport:skip This commit does not require backporting label Dec 16, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 16, 2024
@jloleysens jloleysens removed backport:version Backport to applied version labels v8.18.0 v8.17.1 labels Dec 16, 2024
@jloleysens jloleysens mentioned this pull request Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bamieh Bamieh Bamieh approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@rudolf rudolf rudolf approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jloleysens @elasticmachine @kibanamachine @rudolf @alisonelizabeth @Bamieh