[Cloud Security] Update graph appearance #204610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfirpeled
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
opauloh
approved these changes
Dec 18, 2024
...solutions/security/packages/kbn-cloud-security-posture/graph/src/components/edge/markers.tsx
Outdated
Show resolved
Hide resolved
3 tasks
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12415059159 |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12415059159 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 19, 2024
## Summary - [x] Remove the unknown or question symbols for entities who's type we don't know - [x] Replace edges to be sharp path instead of a smooth one - [x] Changed background of alerted node from `danger` to `primary` - [x] Fix arrow popover color not in sync with background color - [x] Handles should be visible as a small dot - [x] Expand button's color should be similar to the nodes color - [x] Main alert path should be a solid line Before:  After:  https://github.com/user-attachments/assets/4253ec83-19da-4c34-bb80-cb4ca900672d **How to test** To test this PR you can run ``` yarn storybook cloud_security_posture_packages ``` To test e2e - Enable the feature flag `kibana.dev.yml`: ```yaml uiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true xpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled'] ``` - Load mocked data: ```bash node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 ``` - Make sure you include data from Oct 13 2024. (in the video I use Last year) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Sean Rathier <[email protected]> Co-authored-by: Brad White <[email protected]> Co-authored-by: seanrathier <[email protected]> (cherry picked from commit 576f3c5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
## Summary - [x] Remove the unknown or question symbols for entities who's type we don't know - [x] Replace edges to be sharp path instead of a smooth one - [x] Changed background of alerted node from `danger` to `primary` - [x] Fix arrow popover color not in sync with background color - [x] Handles should be visible as a small dot - [x] Expand button's color should be similar to the nodes color - [x] Main alert path should be a solid line Before:  After:  https://github.com/user-attachments/assets/4253ec83-19da-4c34-bb80-cb4ca900672d **How to test** To test this PR you can run ``` yarn storybook cloud_security_posture_packages ``` To test e2e - Enable the feature flag `kibana.dev.yml`: ```yaml uiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true xpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled'] ``` - Load mocked data: ```bash node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 ``` - Make sure you include data from Oct 13 2024. (in the video I use Last year) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Sean Rathier <[email protected]> Co-authored-by: Brad White <[email protected]> Co-authored-by: seanrathier <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 19, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Update graph appearance (#204610)](#204610) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kfir Peled","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T14:50:39Z","message":"[Cloud Security] Update graph appearance (#204610)\n\n## Summary\r\n\r\n- [x] Remove the unknown or question symbols for entities who's type we\r\ndon't know\r\n- [x] Replace edges to be sharp path instead of a smooth one \r\n- [x] Changed background of alerted node from `danger` to `primary`\r\n- [x] Fix arrow popover color not in sync with background color \r\n- [x] Handles should be visible as a small dot\r\n- [x] Expand button's color should be similar to the nodes color\r\n- [x] Main alert path should be a solid line\r\n\r\nBefore:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4253ec83-19da-4c34-bb80-cb4ca900672d\r\n\r\n\r\n**How to test**\r\n\r\nTo test this PR you can run\r\n\r\n```\r\nyarn storybook cloud_security_posture_packages\r\n```\r\n\r\nTo test e2e\r\n\r\n- Enable the feature flag \r\n\r\n`kibana.dev.yml`:\r\n\r\n```yaml\r\nuiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true\r\nxpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled']\r\n```\r\n\r\n- Load mocked data:\r\n\r\n```bash\r\nnode scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \\ \r\n --es-url http://elastic:changeme@localhost:9200 \\\r\n --kibana-url http://elastic:changeme@localhost:5601\r\n\r\nnode scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \\\r\n --es-url http://elastic:changeme@localhost:9200 \\\r\n --kibana-url http://elastic:changeme@localhost:5601\r\n```\r\n\r\n- Make sure you include data from Oct 13 2024. (in the video I use Last\r\nyear)\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Sean Rathier <[email protected]>\r\nCo-authored-by: Brad White <[email protected]>\r\nCo-authored-by: seanrathier <[email protected]>","sha":"576f3c5e81fee12cf1146b8d25b25e5ec865ea48","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","ci:build-storybooks"],"title":"[Cloud Security] Update graph appearance","number":204610,"url":"https://github.com/elastic/kibana/pull/204610","mergeCommit":{"message":"[Cloud Security] Update graph appearance (#204610)\n\n## Summary\r\n\r\n- [x] Remove the unknown or question symbols for entities who's type we\r\ndon't know\r\n- [x] Replace edges to be sharp path instead of a smooth one \r\n- [x] Changed background of alerted node from `danger` to `primary`\r\n- [x] Fix arrow popover color not in sync with background color \r\n- [x] Handles should be visible as a small dot\r\n- [x] Expand button's color should be similar to the nodes color\r\n- [x] Main alert path should be a solid line\r\n\r\nBefore:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4253ec83-19da-4c34-bb80-cb4ca900672d\r\n\r\n\r\n**How to test**\r\n\r\nTo test this PR you can run\r\n\r\n```\r\nyarn storybook cloud_security_posture_packages\r\n```\r\n\r\nTo test e2e\r\n\r\n- Enable the feature flag \r\n\r\n`kibana.dev.yml`:\r\n\r\n```yaml\r\nuiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true\r\nxpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled']\r\n```\r\n\r\n- Load mocked data:\r\n\r\n```bash\r\nnode scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \\ \r\n --es-url http://elastic:changeme@localhost:9200 \\\r\n --kibana-url http://elastic:changeme@localhost:5601\r\n\r\nnode scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \\\r\n --es-url http://elastic:changeme@localhost:9200 \\\r\n --kibana-url http://elastic:changeme@localhost:5601\r\n```\r\n\r\n- Make sure you include data from Oct 13 2024. (in the video I use Last\r\nyear)\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Sean Rathier <[email protected]>\r\nCo-authored-by: Brad White <[email protected]>\r\nCo-authored-by: seanrathier <[email protected]>","sha":"576f3c5e81fee12cf1146b8d25b25e5ec865ea48"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204610","number":204610,"mergeCommit":{"message":"[Cloud Security] Update graph appearance (#204610)\n\n## Summary\r\n\r\n- [x] Remove the unknown or question symbols for entities who's type we\r\ndon't know\r\n- [x] Replace edges to be sharp path instead of a smooth one \r\n- [x] Changed background of alerted node from `danger` to `primary`\r\n- [x] Fix arrow popover color not in sync with background color \r\n- [x] Handles should be visible as a small dot\r\n- [x] Expand button's color should be similar to the nodes color\r\n- [x] Main alert path should be a solid line\r\n\r\nBefore:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4253ec83-19da-4c34-bb80-cb4ca900672d\r\n\r\n\r\n**How to test**\r\n\r\nTo test this PR you can run\r\n\r\n```\r\nyarn storybook cloud_security_posture_packages\r\n```\r\n\r\nTo test e2e\r\n\r\n- Enable the feature flag \r\n\r\n`kibana.dev.yml`:\r\n\r\n```yaml\r\nuiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true\r\nxpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled']\r\n```\r\n\r\n- Load mocked data:\r\n\r\n```bash\r\nnode scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \\ \r\n --es-url http://elastic:changeme@localhost:9200 \\\r\n --kibana-url http://elastic:changeme@localhost:5601\r\n\r\nnode scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \\\r\n --es-url http://elastic:changeme@localhost:9200 \\\r\n --kibana-url http://elastic:changeme@localhost:5601\r\n```\r\n\r\n- Make sure you include data from Oct 13 2024. (in the video I use Last\r\nyear)\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Sean Rathier <[email protected]>\r\nCo-authored-by: Brad White <[email protected]>\r\nCo-authored-by: seanrathier <[email protected]>","sha":"576f3c5e81fee12cf1146b8d25b25e5ec865ea48"}}]}] BACKPORT--> Co-authored-by: Kfir Peled <[email protected]>
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
## Summary - [x] Remove the unknown or question symbols for entities who's type we don't know - [x] Replace edges to be sharp path instead of a smooth one - [x] Changed background of alerted node from `danger` to `primary` - [x] Fix arrow popover color not in sync with background color - [x] Handles should be visible as a small dot - [x] Expand button's color should be similar to the nodes color - [x] Main alert path should be a solid line Before:  After:  https://github.com/user-attachments/assets/4253ec83-19da-4c34-bb80-cb4ca900672d **How to test** To test this PR you can run ``` yarn storybook cloud_security_posture_packages ``` To test e2e - Enable the feature flag `kibana.dev.yml`: ```yaml uiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true xpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled'] ``` - Load mocked data: ```bash node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 ``` - Make sure you include data from Oct 13 2024. (in the video I use Last year) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Sean Rathier <[email protected]> Co-authored-by: Brad White <[email protected]> Co-authored-by: seanrathier <[email protected]>
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
## Summary - [x] Remove the unknown or question symbols for entities who's type we don't know - [x] Replace edges to be sharp path instead of a smooth one - [x] Changed background of alerted node from `danger` to `primary` - [x] Fix arrow popover color not in sync with background color - [x] Handles should be visible as a small dot - [x] Expand button's color should be similar to the nodes color - [x] Main alert path should be a solid line Before:  After:  https://github.com/user-attachments/assets/4253ec83-19da-4c34-bb80-cb4ca900672d **How to test** To test this PR you can run ``` yarn storybook cloud_security_posture_packages ``` To test e2e - Enable the feature flag `kibana.dev.yml`: ```yaml uiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true xpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled'] ``` - Load mocked data: ```bash node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 ``` - Make sure you include data from Oct 13 2024. (in the video I use Last year) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Sean Rathier <[email protected]> Co-authored-by: Brad White <[email protected]> Co-authored-by: seanrathier <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
## Summary - [x] Remove the unknown or question symbols for entities who's type we don't know - [x] Replace edges to be sharp path instead of a smooth one - [x] Changed background of alerted node from `danger` to `primary` - [x] Fix arrow popover color not in sync with background color - [x] Handles should be visible as a small dot - [x] Expand button's color should be similar to the nodes color - [x] Main alert path should be a solid line Before:  After:  https://github.com/user-attachments/assets/4253ec83-19da-4c34-bb80-cb4ca900672d **How to test** To test this PR you can run ``` yarn storybook cloud_security_posture_packages ``` To test e2e - Enable the feature flag `kibana.dev.yml`: ```yaml uiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true xpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled'] ``` - Load mocked data: ```bash node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 ``` - Make sure you include data from Oct 13 2024. (in the video I use Last year) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Sean Rathier <[email protected]> Co-authored-by: Brad White <[email protected]> Co-authored-by: seanrathier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dangertoprimaryBefore:
After:
Screen.Recording.2024-12-18.at.19.11.08.mov
How to test
To test this PR you can run
To test e2e
kibana.dev.yml:node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601Checklist