Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[embeddable] remove legacy embeddable compatibility layer #204642

Merged
merged 6 commits into from
Dec 18, 2024
Merged

[embeddable] remove legacy embeddable compatibility layer #204642

merged 6 commits into from
Dec 18, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 17, 2024 •
edited by kibanamachine
Loading

null

@nreese
Copy link
Contributor Author

nreese commented Dec 17, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 17, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 17, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 17, 2024

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Dec 18, 2024

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Dec 18, 2024

/ci

@nreese nreese marked this pull request as ready for review December 18, 2024 04:13
@nreese nreese requested a review from a team as a code owner December 18, 2024 04:13
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v9.0.0 project:embeddableRebuild backport:version Backport to applied version labels v8.18.0 labels Dec 18, 2024
@nreese
Copy link
Contributor Author

nreese commented Dec 18, 2024

@elasticmachine merge upstream

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Dec 18, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #73 / Visualizations - Group 3 lens app - TSVB Open in Lens Table should convert last value mode to reduced time range

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 144 142 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 338 291 -47

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
embeddable 5 4 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 56.1KB 49.5KB -6.5KB
Unknown metric groups

API count

id before after diff
embeddable 424 377 -47

References to deprecated APIs

id before after diff
embeddable 11 9 -2

History

ThomThomson
ThomThomson approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compatibility layer removal LGTM!

x-pack/platform/plugins/private/translations/translations/fr-FR.json
@@ -7261,6 +7260,14 @@
"securitySolutionPackages.alertSuppressionRuleDetails.upsell": "La suppression d'alertes est configurée mais elle ne sera pas appliquée en raison d'une licence insuffisante",
"securitySolutionPackages.alertSuppressionRuleForm.upsell": "La suppression d'alertes est activée avec la licence {requiredLicense} ou supérieure",
"securitySolutionPackages.beta.label": "Bêta",
"securitySolutionPackages.csp.cspEvaluationBadge.failLabel": "Échec",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the order of all of these translations change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. Just the output of running i18n script. It looks like they just moved in the file and are not new.

@nreese nreese merged commit e1b17d0 into elastic:main Dec 18, 2024
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12398412274

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 18, 2024
@nreese
[embeddable] remove legacy embeddable compatibility layer (elastic#20…
48c1d31 
…4642)

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit e1b17d0)
@kibanamachine kibanamachine mentioned this pull request Dec 18, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 18, 2024
@kibanamachine @nreese
[8.x] [embeddable] remove legacy embeddable compatibility layer (#204642
446ce03 
) (#204815)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[embeddable] remove legacy embeddable compatibility layer
(#204642)](#204642)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-18T17:43:21Z","message":"[embeddable]
remove legacy embeddable compatibility layer
(#204642)\n\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"e1b17d0707ca81e72d5a1f33f8d7693a7d25cacd","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0"],"title":"[embeddable]
remove legacy embeddable compatibility
layer","number":204642,"url":"https://github.com/elastic/kibana/pull/204642","mergeCommit":{"message":"[embeddable]
remove legacy embeddable compatibility layer
(#204642)\n\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"e1b17d0707ca81e72d5a1f33f8d7693a7d25cacd"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204642","number":204642,"mergeCommit":{"message":"[embeddable]
remove legacy embeddable compatibility layer
(#204642)\n\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"e1b17d0707ca81e72d5a1f33f8d7693a7d25cacd"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@nreese @kibanamachine
@elasticmachine @JoseLuisGJ
[embeddable] remove legacy embeddable compatibility layer (elastic#20…
04534b9 
…4642)

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@nreese @kibanamachine
@elasticmachine @benakansara
[embeddable] remove legacy embeddable compatibility layer (elastic#20…
726dc2a 
…4642)

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@nreese @kibanamachine
@elasticmachine @CAWilson94
[embeddable] remove legacy embeddable compatibility layer (elastic#20…
37e7f77 
…4642)

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@nreese @kibanamachine
@elasticmachine @viduni94
[embeddable] remove legacy embeddable compatibility layer (elastic#20…
9307fb1 
…4642)

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:Embedding Embedding content via iFrame project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @kibanamachine @ThomThomson