-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Fixing issue with EUI table filtering in monitoring UI #27504
Changes from 5 commits
087afc6
234ca48
f027450
173c79b
bc8fc42
1284478
e135f87
87526da
98dba3b
520a4f6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,10 @@ export class EuiMonitoringTable extends React.PureComponent { | |
search.box['data-test-subj'] = 'monitoringTableToolBar'; | ||
} | ||
|
||
if (search.box && !search.box.schema) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't find any issues related to this but I'm curious about what it's accomplishing. It doesn't conform to the proptypes specified in the docs, so for my own purposes I'm wondering what it does. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, so I'm just allowing any future monitoring tables to specify a schema manually, but if they didn't, set the |
||
search.box.schema = true; | ||
} | ||
|
||
const columns = _columns.map(column => { | ||
if (!column['data-test-subj']) { | ||
column['data-test-subj'] = 'monitoringTableHasData'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tangential to this PR, but should these column names be translated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, great catch