Data plugin: Expose setup apis also on start #44903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
v8.0.0
Team:AppArch
release_note:skip
|
Pinging @elastic/kibana-app-arch |
flash1293
changed the title
lizozom
reviewed
Sep 5, 2019
lizozom
reviewed
Sep 5, 2019
| expressions: this.expressions.start({ inspector: plugins.inspector }), | ||
| ...this.setupApi!, | ||
| expressions: { | ||
| ...this.setupApi!, |
There was a problem hiding this comment.
Why are you destructuring setupApi into expressions?
Looking at the API, I don't think you need this.
There was a problem hiding this comment.
My bad, I meant to spread ...this.setupApi!.expressions
There was a problem hiding this comment.
I don't think you should.
They have different APIs ATM.
If you need the same functionality in start, that should be a change in the expressions sub-service.
There was a problem hiding this comment.
I don't need it, just thought I put it in there for completeness sake. I will remove it for now.
💚 Build Succeeded |
💚 Build Succeeded |
|
@lizozom You can check the PR again. |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Sep 9, 2019
flash1293
added a commit
that referenced
this pull request
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed offline, expose all of the
setupapis of thedataplugin also in start phase.Inspired by
src/legacy/core_plugins/embeddable_api/public/np_ready/public/plugin.ts.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers