[Maps] use EuiPopover instead of mapbox tooltip #45938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
💔 Build Failed |
nreese
added
release_note:enhancement
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
💔 Build Failed |
nickpeihl
approved these changes
Sep 18, 2019
| <EuiPopover | ||
| id="mapTooltip" | ||
| button={tooltipAnchor} | ||
| anchorPosition="upCenter" |
There was a problem hiding this comment.
another slight behavior change is that the anchorPosition no longer changes to leftCenter or rightCenter as the tooltip approaches the left or right edge of the map. If this is not a simple fix I would not worry about it.
There was a problem hiding this comment.
ya, not much we can do about that without lots of extra logic.
💔 Build Failed |
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Sep 19, 2019
* [Maps] use EuiPopover instead of mapbox tooltip * update draw tooltip to use EuiPopover, remove mapbox popup css hacks * use anchor size of 26px to fix positioning calculations * close tooltip when position is no longer visible * remove reevaluateTooltipPosition, its no longer needed * fix problem with map move and hover tooltip location not also moving
nreese
added a commit
that referenced
this pull request
Sep 19, 2019
* [Maps] use EuiPopover instead of mapbox tooltip * update draw tooltip to use EuiPopover, remove mapbox popup css hacks * use anchor size of 26px to fix positioning calculations * close tooltip when position is no longer visible * remove reevaluateTooltipPosition, its no longer needed * fix problem with map move and hover tooltip location not also moving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43694 because now all the tooltip styling is done be EUI component instead of hacky mapbox CSS overrides
Implement Map tooltips with EuiPopover instead of map box tooltip. This provides the benefit that tooltips can now expand beyond the map container border, making tooltips much more usable when the map is embedded in a Dashboard and the map container is small.
There is one new behavior change in this PR. When a locked tooltip location is moved off screen by map moves, the tooltip is automatically closed.