-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Add tests to create transforms #49760
Conversation
💔 Build Failed |
Pinging @elastic/ml-ui (:ml) |
💔 Build Failed |
@elasticmachine merge upstream |
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💔 Build Failed |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡️
@elasticmachine merge upstream |
💔 Build Failed |
retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is great! Just added two minor suggestions.
@@ -34,40 +34,42 @@ export const StepDetailsSummary: SFC<StepDetailsExposedState> = React.memo( | |||
|
|||
return ( | |||
<Fragment> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there's now a wrapping div
element, you can remove the Fragment
tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Removed in 9e4e6c8
@@ -372,25 +376,34 @@ export const TransformList: FC<Props> = ({ | |||
|
|||
return ( | |||
<Fragment> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there's now a wrapping div
element, you can remove the Fragment
tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Removed in 9e4e6c8
💚 Build Succeeded |
💔 Build Failed |
💚 Build Succeeded |
Summary
This PR add tests to create transforms.
High level test steps
Note: The transform suite has the
transform
label attached, so transform only tests can be executed via--include-tag transform