Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add tests to create transforms #49760

Merged
merged 14 commits into from
Nov 18, 2019
Merged

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Oct 30, 2019

Summary

This PR add tests to create transforms.

High level test steps

  • Navigate to transform UI
  • Use the wizard to create a new batch transform
  • Run the transform and wait for processing to finish
  • Validate transform creation in the transform management list

Note: The transform suite has the transform label attached, so transform only tests can be executed via --include-tag transform

@pheyos pheyos self-assigned this Oct 30, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos pheyos marked this pull request as ready for review November 13, 2019 09:07
@pheyos pheyos requested a review from a team as a code owner November 13, 2019 09:07
@elasticmachine
Copy link
Contributor

💔 Build Failed

@pheyos
Copy link
Member Author

pheyos commented Nov 13, 2019

@elasticmachine merge upstream

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos
Copy link
Member Author

pheyos commented Nov 14, 2019

@elasticmachine merge upstream

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@pheyos
Copy link
Member Author

pheyos commented Nov 18, 2019

@elasticmachine merge upstream

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@elasticmachine
Copy link
Contributor

💔 Build Failed

@pheyos
Copy link
Member Author

pheyos commented Nov 18, 2019

retest

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is great! Just added two minor suggestions.

@@ -34,40 +34,42 @@ export const StepDetailsSummary: SFC<StepDetailsExposedState> = React.memo(

return (
<Fragment>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's now a wrapping div element, you can remove the Fragment tag.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Removed in 9e4e6c8

@@ -372,25 +376,34 @@ export const TransformList: FC<Props> = ({

return (
<Fragment>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's now a wrapping div element, you can remove the Fragment tag.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Removed in 9e4e6c8

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@pheyos pheyos merged commit dca8c24 into elastic:master Nov 18, 2019
@pheyos pheyos deleted the transform_tests branch November 18, 2019 11:54
pheyos added a commit to pheyos/kibana that referenced this pull request Nov 18, 2019
pheyos added a commit that referenced this pull request Nov 18, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
pheyos added a commit to pheyos/kibana that referenced this pull request Dec 3, 2019
pheyos added a commit that referenced this pull request Dec 4, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* [ML] Add tests to create transforms (#49760)

* Apply #51066 to backport

* Adjust eui switch handling for 7.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants