Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTR] expose new es client service #51066

Merged
merged 3 commits into from
Nov 20, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Nov 19, 2019

In order to make the new es client available in the functional tests this migrates the existing es service and all usage to legacyEs, and creates a new es service which exposes the new client.

@spalger spalger added Team:Operations Team label for Operations Team test_ui_functional test_xpack_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.6.0 labels Nov 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Member

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger
Copy link
Contributor Author

spalger commented Nov 19, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger marked this pull request as ready for review November 20, 2019 15:51
@spalger spalger requested review from a team as code owners November 20, 2019 15:51
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security/Spaces changes LGTM

@spalger spalger merged commit 1814957 into elastic:master Nov 20, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 20, 2019
* always extend all common config and expose new es client service

* replace `es` service with `legacyEs`
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 20, 2019
* always extend all common config and expose new es client service

* replace `es` service with `legacyEs`

# Conflicts:
#	test/api_integration/apis/saved_objects/bulk_update.js
#	x-pack/test/functional/apps/rollup_job/hybrid_index_pattern.js
#	x-pack/test/functional/apps/rollup_job/rollup_jobs.js
#	x-pack/test/functional/services/transform_ui/api.ts
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already merged, but still:
ML and transform test changes LGTM

spalger pushed a commit that referenced this pull request Nov 20, 2019
* always extend all common config and expose new es client service

* replace `es` service with `legacyEs`

# Conflicts:
#	test/api_integration/apis/saved_objects/bulk_update.js
#	x-pack/test/functional/apps/rollup_job/hybrid_index_pattern.js
#	x-pack/test/functional/apps/rollup_job/rollup_jobs.js
#	x-pack/test/functional/services/transform_ui/api.ts
@spalger
Copy link
Contributor Author

spalger commented Nov 20, 2019

7.x/7.6: 4763198
7.5: cfa8232

spalger pushed a commit that referenced this pull request Nov 21, 2019
* [FTR] expose new es client service (#51066)

* always extend all common config and expose new es client service

* replace `es` service with `legacyEs`

* fix one refernce that's unique to 7.x
@spalger spalger deleted the implement/new-client-ftr-service branch November 21, 2019 02:12
pheyos added a commit to pheyos/kibana that referenced this pull request Dec 3, 2019
pheyos added a commit that referenced this pull request Dec 4, 2019
* [ML] Add tests to create transforms (#49760)

* Apply #51066 to backport

* Adjust eui switch handling for 7.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team test_ui_functional test_xpack_functional v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants