-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FTR] expose new es client service #51066
[FTR] expose new es client service #51066
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💔 Build Failed |
@elasticmachine merge upstream |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security/Spaces changes LGTM
* always extend all common config and expose new es client service * replace `es` service with `legacyEs`
* always extend all common config and expose new es client service * replace `es` service with `legacyEs` # Conflicts: # test/api_integration/apis/saved_objects/bulk_update.js # x-pack/test/functional/apps/rollup_job/hybrid_index_pattern.js # x-pack/test/functional/apps/rollup_job/rollup_jobs.js # x-pack/test/functional/services/transform_ui/api.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already merged, but still:
ML and transform test changes LGTM
* always extend all common config and expose new es client service * replace `es` service with `legacyEs` # Conflicts: # test/api_integration/apis/saved_objects/bulk_update.js # x-pack/test/functional/apps/rollup_job/hybrid_index_pattern.js # x-pack/test/functional/apps/rollup_job/rollup_jobs.js # x-pack/test/functional/services/transform_ui/api.ts
In order to make the new es client available in the functional tests this migrates the existing es service and all usage to
legacyEs
, and creates a newes
service which exposes the new client.