-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph: Add sample data #54558
Graph: Add sample data #54558
Conversation
💚 Build SucceededTo update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Tested locally with no issues with and without trial license. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, great that there are now examples in Graph, this is very useful for demoing and new users 👍
I've noticed one more minor limitation, when you've got already installed demo data, the links to graph workspaces from home don't work, however, in that case it's easy to fix by the user by reinstalling the demo data
attributes: { | ||
title: 'Kibana Sample Data - eCommerce', | ||
description: | ||
'This is a sample graph based on an eCommerce data set. It shows the gender, continent, and product category of purchases. The thicker the line is, there are more correlated documents between the vertices.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure, but "The thicker the line is, there are more correlated documents between the vertices." sounds a bit like german (also like austriakisch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hehe, ping @shaunmcgough - these are your German roots shining through.
This PR adds sample Graph workspaces to the existing sample data sets.
If the license level is sufficient, a Graph link also shows up in the sample data panel:
Known limitations: As the current API of the
home
plugin does not allow de-registering a link from the sample dataset panel, the following (unlikely) scenario exists:I think this is OK, as the user had platinum at one point and this can be seen as an additional way of advertising the feature.
Alternatively the
home
API can be extended to also be able to remove links from the sample data panels, but that felt like over-engineering.cc @shaunmcgough