Using re2 for Timelion regular expressions #55208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobelb
changed the title
kobelb
added
v8.0.0
v7.6.0
release_note:skip
|
@elasticmachine merge upstream |
watson
reviewed
Jan 20, 2020
|
@elasticmachine merge upstream |
|
This might be the reason why using native modules becomes a non-starter... Compiling portable binaries sucks...
|
|
@kobelb 👀 , ready for review? |
|
@jbudz not yet... working on getting the actually portable binaries ready, and automating their creation using Travis |
|
@elasticmachine merge upstream |
flash1293
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
LGTM besides the failing type check, regexes are still applied correctly.
@sulemanof Could you check whether this works on Windows due to the native extension?
This theoretically breaks existing timelion visualizations because backtracking doesn't work anymore, right? I don't think it's a big deal because it's just an edge case in a small feature, but it's worth a release note IMHO
This was referenced Mar 12, 2020
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Mar 12, 2020
* Using re2 for Timelion's regexs * Patching native modules * Restructuring to be more generic * Fixing download_node_builds_task tests * Updating linux sha after properly gzipping the archive * Using a Centos7 machine with devtoolset-6. That's what node does * Using new archives which Travis built for us * Not using a standard import to prevent Kibana from not starting up If the "portable" version of RE2 for some reason isn't truly portable and can't load, we don't want to prevent the rest of Kibana from working properly. This will only prevent Timelion from working, which isn't great, but is less worse * Isolating the require even further * Detecting the package version mismatches, thanks Larry! Co-authored-by: Elastic Machine <[email protected]>
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Mar 12, 2020
* Using re2 for Timelion's regexs * Patching native modules * Restructuring to be more generic * Fixing download_node_builds_task tests * Updating linux sha after properly gzipping the archive * Using a Centos7 machine with devtoolset-6. That's what node does * Using new archives which Travis built for us * Not using a standard import to prevent Kibana from not starting up If the "portable" version of RE2 for some reason isn't truly portable and can't load, we don't want to prevent the rest of Kibana from working properly. This will only prevent Timelion from working, which isn't great, but is less worse * Isolating the require even further * Detecting the package version mismatches, thanks Larry! Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 12, 2020
* master: Endpoint: Change the input type for @kbn/config-schema to work with more schemas (elastic#60007) Using re2 for Timelion regular expressions (elastic#55208) [Monitoring] Re-enable logstash tests (elastic#59815) fix karma debug typo (elastic#60029) Adds telemetry support to alerting and actions plugins (elastic#58081)
kobelb
added a commit
that referenced
this pull request
Mar 12, 2020
* Using re2 for Timelion's regexs * Patching native modules * Restructuring to be more generic * Fixing download_node_builds_task tests * Updating linux sha after properly gzipping the archive * Using a Centos7 machine with devtoolset-6. That's what node does * Using new archives which Travis built for us * Not using a standard import to prevent Kibana from not starting up If the "portable" version of RE2 for some reason isn't truly portable and can't load, we don't want to prevent the rest of Kibana from working properly. This will only prevent Timelion from working, which isn't great, but is less worse * Isolating the require even further * Detecting the package version mismatches, thanks Larry! Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kobelb
added a commit
that referenced
this pull request
Mar 12, 2020
* Using re2 for Timelion's regexs * Patching native modules * Restructuring to be more generic * Fixing download_node_builds_task tests * Updating linux sha after properly gzipping the archive * Using a Centos7 machine with devtoolset-6. That's what node does * Using new archives which Travis built for us * Not using a standard import to prevent Kibana from not starting up If the "portable" version of RE2 for some reason isn't truly portable and can't load, we don't want to prevent the rest of Kibana from working properly. This will only prevent Timelion from working, which isn't great, but is less worse * Isolating the require even further * Detecting the package version mismatches, thanks Larry! Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kobelb
added a commit
that referenced
this pull request
Mar 12, 2020
* Using re2 for Timelion's regexs * Patching native modules * Restructuring to be more generic * Fixing download_node_builds_task tests * Updating linux sha after properly gzipping the archive * Using a Centos7 machine with devtoolset-6. That's what node does * Using new archives which Travis built for us * Not using a standard import to prevent Kibana from not starting up If the "portable" version of RE2 for some reason isn't truly portable and can't load, we don't want to prevent the rest of Kibana from working properly. This will only prevent Timelion from working, which isn't great, but is less worse * Isolating the require even further * Detecting the package version mismatches, thanks Larry! Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
spalger
added a commit
that referenced
this pull request
Mar 13, 2020
spalger
added a commit
that referenced
this pull request
Mar 13, 2020
spalger
added a commit
that referenced
this pull request
Mar 13, 2020
|
Reverted as this causes compilation errors locally in certain python environments, which aren't documented or validated and don't have any suggested way methods for being fixed. It seems like we should be using the prebuilt versions of re2 unless otherwise instructed from an environment variable or something. Macos Version: 10.15.3 The errors I'm getting locally when I try to bootstrap: |
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
May 8, 2020
…5208) (elastic#60055)"" This reverts commit 7fd86d6.
kobelb
added a commit
that referenced
this pull request
Jun 10, 2020
* Revert "Revert "Using re2 for Timelion regular expressions (#55208)"" This reverts commit c90293d. * Updating re2 to 1.14.0. Still need to update build patching * Extract the gzip to the destination, supporting multiple extract methods * Adding 'node' to jest's moduleFileExtensions 'node' is in the defaults, not sure why we aren't using the defaults... https://jestjs.io/docs/en/configuration#modulefileextensions-arraystring Co-authored-by: Elastic Machine <[email protected]>
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Jun 10, 2020
* Revert "Revert "Using re2 for Timelion regular expressions (elastic#55208)"" This reverts commit c90293d. * Updating re2 to 1.14.0. Still need to update build patching * Extract the gzip to the destination, supporting multiple extract methods * Adding 'node' to jest's moduleFileExtensions 'node' is in the defaults, not sure why we aren't using the defaults... https://jestjs.io/docs/en/configuration#modulefileextensions-arraystring Co-authored-by: Elastic Machine <[email protected]>
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Jun 11, 2020
* Revert "Revert "Using re2 for Timelion regular expressions (elastic#55208)"" This reverts commit c90293d. * Updating re2 to 1.14.0. Still need to update build patching * Extract the gzip to the destination, supporting multiple extract methods * Adding 'node' to jest's moduleFileExtensions 'node' is in the defaults, not sure why we aren't using the defaults... https://jestjs.io/docs/en/configuration#modulefileextensions-arraystring Co-authored-by: Elastic Machine <[email protected]>
kobelb
added a commit
that referenced
this pull request
Jun 11, 2020
* Revert "Revert "Using re2 for Timelion regular expressions (#55208)"" This reverts commit c90293d. * Updating re2 to 1.14.0. Still need to update build patching * Extract the gzip to the destination, supporting multiple extract methods * Adding 'node' to jest's moduleFileExtensions 'node' is in the defaults, not sure why we aren't using the defaults... https://jestjs.io/docs/en/configuration#modulefileextensions-arraystring Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kobelb
added a commit
that referenced
this pull request
Jun 18, 2020
* Revert "Revert "Using re2 for Timelion regular expressions (#55208)"" This reverts commit c90293d. * Updating re2 to 1.14.0. Still need to update build patching * Extract the gzip to the destination, supporting multiple extract methods * Adding 'node' to jest's moduleFileExtensions 'node' is in the defaults, not sure why we aren't using the defaults... https://jestjs.io/docs/en/configuration#modulefileextensions-arraystring Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kobelb
added a commit
that referenced
this pull request
Jun 18, 2020
* Revert "Revert "Using re2 for Timelion regular expressions (#55208)"" This reverts commit c90293d. * Updating re2 to 1.14.0. Still need to update build patching * Extract the gzip to the destination, supporting multiple extract methods * Adding 'node' to jest's moduleFileExtensions 'node' is in the defaults, not sure why we aren't using the defaults... https://jestjs.io/docs/en/configuration#modulefileextensions-arraystring Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.