[6.8] Using re2 for Timelion regular expressions (#55208) #60059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Using re2 for Timelion's regexs * Patching native modules * Restructuring to be more generic * Fixing download_node_builds_task tests * Updating linux sha after properly gzipping the archive * Using a Centos7 machine with devtoolset-6. That's what node does * Using new archives which Travis built for us * Not using a standard import to prevent Kibana from not starting up If the "portable" version of RE2 for some reason isn't truly portable and can't load, we don't want to prevent the rest of Kibana from working properly. This will only prevent Timelion from working, which isn't great, but is less worse * Isolating the require even further * Detecting the package version mismatches, thanks Larry! Co-authored-by: Elastic Machine <[email protected]>
💚 Build SucceededTo update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.8: