[Drilldowns] Simpler url parsing in sub url hooks #61245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don’t use url.parse to extract hash
7 tasks
|
@elasticmachine merge upstream |
Dosant
commented
Mar 25, 2020
| */ | ||
|
|
||
| export function areDecodedHashesEqual(urlA: string, urlB: string): boolean { | ||
| const getHash = (url: string) => url.split('#')[1] ?? ''; |
There was a problem hiding this comment.
This is the change in a nutshell. instead of using url.parse(url).hash use this simpler method.
The problem with url.parse that it encodes ' -> %27.
This test would fail with original functionality: https://github.com/elastic/kibana/pull/61245/files#diff-58b12ddd89613d7380892977f494f217R47
Dosant
added
v7.8.0
Feature:Drilldowns
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
…rl-parsing-in-sub-url-hooks
…:Dosant/kibana into dev/simpler-url-parsing-in-sub-url-hooks
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Mar 31, 2020
* Simpler url parsing in sub url hooks don’t use url.parse to extract hash * review improvements Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # src/legacy/ui/public/chrome/api/sub_url_hooks.js
Dosant
added a commit
that referenced
this pull request
Mar 31, 2020
* Simpler url parsing in sub url hooks don’t use url.parse to extract hash * review improvements Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # src/legacy/ui/public/chrome/api/sub_url_hooks.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #61230
Addresses one of the issues when navigating within different dashboards.
The fix is as simple as removing
url.parsewhen extracting hash from the url, but I moved the logic into separate function to be able to add a unit test for an edge case I wanted to fix.This is the unit test which is fixed by this pr:
https://github.com/elastic/kibana/pull/61245/files#diff-58b12ddd89613d7380892977f494f217R47
I bumped into it in #60087 when trying to navigate from 1 dashboard to another using core's navigateToApp using:
Internally core is using url.parse which converts
'->%27. Performs the navigation. And then angular maps it back causing 2 history records for one navigation.Change to our existing has encoding workarounds logic makes sure angular does it's update with
replaceTesting
I don't know how to test it in current master. The real use case this is needed for will be introduced later in #60087 (comment) and will be covered by functional test