-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dashboard drilldown - select dashboard via filtering combo box and navigate to dashboarrd #60087
Closed
mattkime
wants to merge
50
commits into
elastic:drilldowns
from
mattkime:drilldowns_load_dashboard_list
Closed
Create dashboard drilldown - select dashboard via filtering combo box and navigate to dashboarrd #60087
mattkime
wants to merge
50
commits into
elastic:drilldowns
from
mattkime:drilldowns_load_dashboard_list
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
reviewed
Mar 13, 2020
...oard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/collect_config.tsx
Outdated
Show resolved
Hide resolved
7 tasks
…kibana into drilldowns_load_dashboard_list
7 tasks
mattkime
changed the title
partial progress on async loading / searching of dashboard titles
Create dashboard drilldown - select dashboard via filtering combo box
Mar 17, 2020
…ad_dashboard_list
mattkime
commented
Mar 18, 2020
...dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.tsx
Outdated
Show resolved
Hide resolved
except for back button - that would be addressed separatly
7 tasks
streamich
reviewed
Mar 18, 2020
x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_drilldowns_services.ts
Outdated
Show resolved
Hide resolved
7 tasks
Dosant
reviewed
Mar 24, 2020
src/plugins/data/common/query/filter_manager/compare_filters.ts
Outdated
Show resolved
Hide resolved
Dosant
reviewed
Mar 24, 2020
src/legacy/core_plugins/kibana/public/dashboard/np_ready/dashboard_app_controller.tsx
Outdated
Show resolved
Hide resolved
Dosant
reviewed
Mar 24, 2020
src/legacy/core_plugins/kibana/public/dashboard/np_ready/dashboard_app_controller.tsx
Outdated
Show resolved
Hide resolved
Dosant
reviewed
Mar 24, 2020
This was referenced Mar 25, 2020
…s_load_dashboard_list # Conflicts: # src/legacy/core_plugins/kibana/public/dashboard/np_ready/dashboard_app_controller.tsx # src/legacy/core_plugins/kibana/public/dashboard/np_ready/dashboard_state_manager.ts # src/legacy/core_plugins/kibana/public/dashboard/np_ready/url_helper.test.ts # src/legacy/core_plugins/kibana/public/dashboard/np_ready/url_helper.ts # src/legacy/ui/public/chrome/api/sub_url_hooks.js # src/plugins/dashboard/public/url_generator.test.ts # src/plugins/dashboard/public/url_generator.ts # src/plugins/data/common/query/filter_manager/compare_filters.ts
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/feature_controls/ml_security·ts.machine learning feature controls security machine_learning_user and global all shows ML navlinkStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/feature_controls/ml_security·ts.machine learning feature controls security machine_learning_user and global all shows ML navlinkStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/management/index_lifecycle_management/policies·js.apis management index lifecycle management policies list should have a default policy to manage the Watcher history indicesStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
Decided with @mattkime to close this for now and reopen cleaned up and with clean history to make it easier to review |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Drilldowns
Embeddable panel Drilldowns
Feature:Embedding
Embedding content via iFrame
v7.7.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #55322
Use EuiComboBox to select dashboard. Loads up to 100 dashboards into list which can be filtered by phrase. Ensures selected item is properly displayed even if not in initial set. List should not display the current dashboard.
Ensure that the back button works after using a drilldown.
Implements drilldown
execute
function which navigates to dashboard with correct time range and filters.Checklist
Delete any items that are not applicable to this PR.
[ ] Documentation was added for features that require explanation or tutorialsFor maintainers