Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [EPM] Share package icon location hook (#62072) #62983

Merged
merged 1 commit into from
Apr 8, 2020
Merged

[7.x] [EPM] Share package icon location hook (#62072) #62983

merged 1 commit into from
Apr 8, 2020

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Apr 8, 2020

Backports the following commits to 7.x:

[EPM] Share package icon location hook (#62072)
676d037 
* EPM detail page now uses same icon as list page.
* Moved hook from ./components to ./hooks
* Add optional `tryApi` param to `<PackageIcon>`

Trusts given values by default but can opt-in to side-effects like calling API. Prevents trying API when we know none are present (api explicitly returns none).

This also fixes the issue in master where the API was called several times for each item in the datasources list.
@jfsiii jfsiii added the backport label Apr 8, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii merged commit 2ae38b7 into elastic:7.x Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfsiii @kibanamachine