-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook up the Add Data UI Save Button #6447
Conversation
@stormpython note I just pushed one more small commit to fix a race condition I found. |
@Bargs, I get hung up on the This is what I am pasting in to the text box:
Am I doing something wrong here? |
The textbox doesn't actually affect anything since the pipeline creation screen (step 2) doesn't exist yet, the save button just sends test data at the moment. Based on the error in your screenshot it looks like you may not be running a recent enough version of ES 5.0. It's complaining that the grok processor doesn't exist, but grok is shipped out of the box in ES master. How are you running ES at the moment? |
I cloned the elasticsearch repo. I ran |
…and provide a central place to send ingest data change events from
I'm testing this theory right now, but I don't think Install the ingest-geoip plugin you built locally, run it, and try the add data UI again. I just tested this method, so it should definitely work. Also, note that I just pulled the most recent changes from Kibana master into this branch, so you'll want to pull down those changes before you keep testing. Sorry this is such a pain to set up for testing, it's tough since ES 5.0 is a moving target right now. |
This PR makes the save button at the end of the Add Data wizard (#5974) actually save the index pattern and pipeline that the user builds in the previous steps. Note that this PR targets the feature/ingest branch and not master. The scope of the PR is only this small piece, the entire wizard isn't expected to be fully functioning.
After working through the wizard and finally clicking the save button, 3 things should get created in elasticsearch:
kibana-<pattern name>
kibana-<pattern name>
Also, the index pattern list on the left hand side of the page should get updated, and if there was previously no default index pattern, the new pattern should be made default.
Testing this PR requires an instance of ES 5.0 with the ingest-geoip plugin installed. ingest-geoip isn't published yet so you can achieve this with the following steps:
gradle assemble
<your es repo>/plugins/ingest-geoip/build/distributions/ingest-geoip-5.0.0-SNAPSHOT.zip