Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up the Add Data UI Save Button #6447

Merged
merged 5 commits into from
Mar 9, 2016

Conversation

Bargs
Copy link
Contributor

@Bargs Bargs commented Mar 7, 2016

This PR makes the save button at the end of the Add Data wizard (#5974) actually save the index pattern and pipeline that the user builds in the previous steps. Note that this PR targets the feature/ingest branch and not master. The scope of the PR is only this small piece, the entire wizard isn't expected to be fully functioning.

After working through the wizard and finally clicking the save button, 3 things should get created in elasticsearch:

  1. An index-pattern with the name the user picked
  2. An index template with the name kibana-<pattern name>
  3. A pipeline with the name kibana-<pattern name>

Also, the index pattern list on the left hand side of the page should get updated, and if there was previously no default index pattern, the new pattern should be made default.

Testing this PR requires an instance of ES 5.0 with the ingest-geoip plugin installed. ingest-geoip isn't published yet so you can achieve this with the following steps:

  • Clone the elasticsearch repo
  • Run gradle assemble
  • Find the ingest-geoip distributable in <your es repo>/plugins/ingest-geoip/build/distributions/ingest-geoip-5.0.0-SNAPSHOT.zip
  • Install that zip into your local ES installation

@Bargs Bargs mentioned this pull request Mar 7, 2016
15 tasks
@Bargs
Copy link
Contributor Author

Bargs commented Mar 8, 2016

@stormpython note I just pushed one more small commit to fix a race condition I found.

@stormpython
Copy link
Contributor

@Bargs, I get hung up on the Parse step, where I am getting a 404 Error.

screen shot 2016-03-08 at 5 30 30 pm

This is what I am pasting in to the text box:

{ "message": "You know, for search" }

Am I doing something wrong here?

@Bargs
Copy link
Contributor Author

Bargs commented Mar 9, 2016

The textbox doesn't actually affect anything since the pipeline creation screen (step 2) doesn't exist yet, the save button just sends test data at the moment. Based on the error in your screenshot it looks like you may not be running a recent enough version of ES 5.0. It's complaining that the grok processor doesn't exist, but grok is shipped out of the box in ES master. How are you running ES at the moment?

@stormpython
Copy link
Contributor

I cloned the elasticsearch repo. I ran gradle assemble and then gradle run.

@Bargs Bargs force-pushed the ingest/saveButton branch from ca99104 to ea3418c Compare March 9, 2016 14:50
@Bargs
Copy link
Contributor Author

Bargs commented Mar 9, 2016

I'm testing this theory right now, but I don't think gradle run enables ingest by default. I usually run the distributable created by gradle assemble under /Users/matt/Code/elasticsearch/distribution/zip/build/distributions/elasticsearch-5.0.0-SNAPSHOT.zip but I'm getting weird errors about snapshot versions with the most recent updates from ES master. If you run into the same issue, you could try downloading the most recent snapshot build of master here:

http://s3-eu-west-1.amazonaws.com/build.eu-west-1.elastic.co/origin/master/elasticsearch-latest-SNAPSHOT.zip

Install the ingest-geoip plugin you built locally, run it, and try the add data UI again. I just tested this method, so it should definitely work.

Also, note that I just pulled the most recent changes from Kibana master into this branch, so you'll want to pull down those changes before you keep testing.

Sorry this is such a pain to set up for testing, it's tough since ES 5.0 is a moving target right now.

@Bargs Bargs assigned rashidkpc and unassigned stormpython Mar 9, 2016
@rashidkpc rashidkpc merged commit ea3418c into elastic:feature/ingest Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants