Use ingest API to delete index patterns #6457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and provide a central place to send ingest data change events from
…templates also get deleted if they exist
Bargs
force-pushed
the
ingest/deletePattern
branch
from
b35284a to
f7b1d77
Compare
|
No complaints from me, this is fairly straight forward and works with existing index patterns. |
rashidkpc
pushed a commit
that referenced
this pull request
Mar 9, 2016
Use ingest API to delete index patterns
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Sep 20, 2016
This commit reverts a change to use the ingest API when deleting index patterns via the Kibana UI. Back when I was building the Filebeat wizard it made sense to try to delete any index templates or pipelines that may have been created along with an index pattern. But now that we're only shipping with CSV Upload, and we don't delete the actual indices that CSV upload creates, it doesn't make much sense to delete the template. Now we'll treate the indices and templates consistently. This also fixes an issue where users would get a fatal error if they were using Security and they didn't have permissions to delete templates. Every index pattern deletion would also attempt to delete an associated template, so if the user didn't have the correct permissions they would get a 403. Related: elastic#6457
elastic-jasper
added a commit
that referenced
this pull request
Sep 22, 2016
--------- **Commit 1:** Don't try to delete index template along with pattern This commit reverts a change to use the ingest API when deleting index patterns via the Kibana UI. Back when I was building the Filebeat wizard it made sense to try to delete any index templates or pipelines that may have been created along with an index pattern. But now that we're only shipping with CSV Upload, and we don't delete the actual indices that CSV upload creates, it doesn't make much sense to delete the template. Now we'll treate the indices and templates consistently. This also fixes an issue where users would get a fatal error if they were using Security and they didn't have permissions to delete templates. Every index pattern deletion would also attempt to delete an associated template, so if the user didn't have the correct permissions they would get a 403. Related: #6457 * Original sha: daa5b3b * Authored by Matthew Bargar <[email protected]> on 2016-09-20T22:43:03Z
elastic-jasper
added a commit
that referenced
this pull request
Sep 22, 2016
--------- **Commit 1:** Don't try to delete index template along with pattern This commit reverts a change to use the ingest API when deleting index patterns via the Kibana UI. Back when I was building the Filebeat wizard it made sense to try to delete any index templates or pipelines that may have been created along with an index pattern. But now that we're only shipping with CSV Upload, and we don't delete the actual indices that CSV upload creates, it doesn't make much sense to delete the template. Now we'll treate the indices and templates consistently. This also fixes an issue where users would get a fatal error if they were using Security and they didn't have permissions to delete templates. Every index pattern deletion would also attempt to delete an associated template, so if the user didn't have the correct permissions they would get a 403. Related: #6457 * Original sha: daa5b3b * Authored by Matthew Bargar <[email protected]> on 2016-09-20T22:43:03Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** Don't try to delete index template along with pattern This commit reverts a change to use the ingest API when deleting index patterns via the Kibana UI. Back when I was building the Filebeat wizard it made sense to try to delete any index templates or pipelines that may have been created along with an index pattern. But now that we're only shipping with CSV Upload, and we don't delete the actual indices that CSV upload creates, it doesn't make much sense to delete the template. Now we'll treate the indices and templates consistently. This also fixes an issue where users would get a fatal error if they were using Security and they didn't have permissions to delete templates. Every index pattern deletion would also attempt to delete an associated template, so if the user didn't have the correct permissions they would get a 403. Related: elastic#6457 * Original sha: bd504da3ffb4d15882c41506f7419e7827c7818e [formerly daa5b3b] * Authored by Matthew Bargar <[email protected]> on 2016-09-20T22:43:03Z Former-commit-id: bc7b8d3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #6447
When a user completes the Add Data wizard they'll be left with 3 new items in elasticsearch:
When the user deletes a pattern from the "pattern edit" screen we need to clean up all 3 of these records if they exist. Using the DELETE endpoint of the ingest API will achieve this while maintaining backwards compatibility with plain old index patterns.