[alerting] migrates the old `alerting` consumer to be `alerts` #69555

gmmorris · 2020-06-18T17:52:22Z

Summary

This PR migrates all old alerts with the alerting consumer to have alerts instead.
This is because in 7.9 we changed the feature ID and we need these to remain in sync otherwise the RBAC work (#67157) will break old alerts.

Checklist

Delete any items that are not applicable to this PR.

~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~
~~This renders correctly on smaller devices using a responsive layout. (You can test this in your browser~~
~~This was checked for cross-browser compatibility, including a check against IE11~~

For maintainers

This was checked for breaking API changes and was labeled appropriately

* master: (82 commits) Drilldown docs 2 (elastic#69375) [APM] Replace ML index queries with searching via mlAnomalySearch API (elastic#69099) [Ingest Manager][Endpoint] Add Endpoint Create Policy flow with Ingest (elastic#68955) [DOCS] Updates titles in Maps docs (elastic#68703) [SIEM][Timeline] Minor timeline improvement (elastic#69386) Update dependency @elastic/charts to v19.5.2 (elastic#69126) [ML] Functional tests - Reduce DFA job model memory (elastic#69295) [ML] Functional tests - add more recognize and setup module API tests (elastic#69251) feat: 🎸 don't show drilldown action in "edit" mode (elastic#69371) [SIEM][Timeline] Persist timeline to localStorage (elastic#67156) Replaces the Custom Color Picker on TSVB with the EuiColorPicker (elastic#68888) [APM] Only add decimals for numbers below 10 (elastic#69334) Explore underlying data (elastic#68496) [SIEM] Adds example unit test to convert KQL using a nested query [Component template] Details flyout (elastic#68732) [DOCS] Fixes license management links (elastic#69347) [BundleRefPlugin] resolve imports to files too (elastic#69241) [APM] Fix service maps not loading when there are no APM ML jobs (elastic#69240) [Reporting] Prepare export type definitions for Task Manager (elastic#65213) [kbn/pm] only count cached project (elastic#69113) ...

This reverts commit 1c205c6.

This reverts commit 7c14ed2.

elasticmachine · 2020-06-18T17:52:43Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

…migrate-old-alerting-consumer * alerting/migrate-old-alerting-consumere: fixed incorrect typing

* master: (63 commits) Bump jest related packages (elastic#58095) [SECURITY] Introduce kibana nav (elastic#68862) disable pageLoadMetrics job, it's gotten really flaky [Endpoint] Fix flaky endpoints list unit test (elastic#69591) skip failing suite (elastic#69595) [Security_Solution][Endpoint] Resolver leverage ancestry array for queries (elastic#69264) Fixing resolver alert generation (elastic#69587) [Endpoint] add policy empty state (elastic#69449) [APM] Add support for dark mode (elastic#69362) [ML] Data Grid Histograms (elastic#68359) Resolving conflicts (elastic#69597) [DOCS] Add related link to the ingest management docs (elastic#69467) Remove endpoint alert fields from signal mapping (elastic#68934) [ftr] add support for docker servers (elastic#68173) Merge/restyle nodes table (elastic#69098) skip tests using hostDetailsPolicyResponseActionBadge [DOCS] Adds kibana-pull attribute for release docs (elastic#69554) [SIEM][Detection Engine] Fixes 7.8 and 7.9 upgrade issue within rules where you can get the error "params invalid: [lists]: definition for this key is missing" Document authentication settings. (elastic#69284) [CCR] Fix follower indices table not updating after pausing (elastic#69228) ...

…migrate-old-alerting-consumer * alerting/migrate-old-alerting-consumere: (63 commits) Bump jest related packages (elastic#58095) [SECURITY] Introduce kibana nav (elastic#68862) disable pageLoadMetrics job, it's gotten really flaky [Endpoint] Fix flaky endpoints list unit test (elastic#69591) skip failing suite (elastic#69595) [Security_Solution][Endpoint] Resolver leverage ancestry array for queries (elastic#69264) Fixing resolver alert generation (elastic#69587) [Endpoint] add policy empty state (elastic#69449) [APM] Add support for dark mode (elastic#69362) [ML] Data Grid Histograms (elastic#68359) Resolving conflicts (elastic#69597) [DOCS] Add related link to the ingest management docs (elastic#69467) Remove endpoint alert fields from signal mapping (elastic#68934) [ftr] add support for docker servers (elastic#68173) Merge/restyle nodes table (elastic#69098) skip tests using hostDetailsPolicyResponseActionBadge [DOCS] Adds kibana-pull attribute for release docs (elastic#69554) [SIEM][Detection Engine] Fixes 7.8 and 7.9 upgrade issue within rules where you can get the error "params invalid: [lists]: definition for this key is missing" Document authentication settings. (elastic#69284) [CCR] Fix follower indices table not updating after pausing (elastic#69228) ...

…migrate-old-alerting-consumer * alerting/migrate-old-alerting-consumere: cleaned up platform code

* master: (90 commits) [Encrypted Saved Objects] Adds support for migrations in ESO (elastic#69513) [SIEM] Replace WithSource with useWithSource hook (elastic#68722) [Endpoint]EMT-451: add ability to filter endpoint metadata based on presence of unenrolled events (elastic#69708) rename old siem kibana config to securitySolution (elastic#69874) Remove unused Resolver code (elastic#69914) [Observability] Fixing dynamic return type based on the appName (elastic#69894) [SECURITY SOLUTION][INGEST] Task/endpoint list tests (elastic#69419) Fixes special clicks and 3rd party icon sizes in nav (elastic#69767) [APM] Catch annotations index permission error and log warning (elastic#69881) [Endpoint][Ingest Manager] minor code cleanup (elastic#69844) [Logs UI] Logs ui context menu (elastic#69915) Index pattern serialize and de-serialize (elastic#68844) [QA] Unskip functional tests (elastic#69760) [SIEM][Detection Engine] - Update DE to work with new exceptions schema (elastic#69715) Fixes elastic#69639: Ignore url.url fields above 2048 characters (elastic#69863) PR: Provide limit warnings to user when API limits are reached. (elastic#69590) [Maps] Remove broken button (elastic#69853) Makes usage collection methods available on start (elastic#69836) [SIEM][CASE] Improve Jira's labelling (elastic#69892) [Logs UI] Access ML via the programmatic plugin API (elastic#68905) ...

gmmorris · 2020-06-25T17:00:39Z

This PR got a bit messy, making a fresh one to make it easier to review

kibanamachine · 2020-06-25T17:49:29Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 045c68e
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/encrypted_saved_objects/server/crypto.#encryptAttributes does not encrypt attributes that are not supposed to be encrypted

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Cannot read property 'create' of undefined
    at Object.<anonymous>.beforeEach (/dev/shm/workspace/kibana/x-pack/plugins/encrypted_saved_objects/server/crypto/encrypted_saved_objects_migration_service.test.ts:28:24)
    at Promise (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:198:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:162:10)
    at _callCircusHook (/dev/shm/workspace/kibana/node_modules/jest-circus/build/run.js:168:40)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/encrypted_saved_objects/server/crypto.#encryptAttributes encrypts only attributes that are supposed to be encrypted

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Cannot read property 'create' of undefined
    at Object.<anonymous>.beforeEach (/dev/shm/workspace/kibana/x-pack/plugins/encrypted_saved_objects/server/crypto/encrypted_saved_objects_migration_service.test.ts:28:24)
    at Promise (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:198:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:162:10)
    at _callCircusHook (/dev/shm/workspace/kibana/node_modules/jest-circus/build/run.js:168:40)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/encrypted_saved_objects/server/crypto.#encryptAttributes encrypts only attributes that are supposed to be encrypted even if not all provided

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Cannot read property 'create' of undefined
    at Object.<anonymous>.beforeEach (/dev/shm/workspace/kibana/x-pack/plugins/encrypted_saved_objects/server/crypto/encrypted_saved_objects_migration_service.test.ts:28:24)
    at Promise (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:198:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:162:10)
    at _callCircusHook (/dev/shm/workspace/kibana/node_modules/jest-circus/build/run.js:168:40)
    at process._tickCallback (internal/process/next_tick.js:68:7)

and 29 more failures, only showing the first 3.

Build metrics

✅ unchanged

History

💚 Build #55502 succeeded 6b32148
💚 Build #55465 succeeded 8964fea
💚 Build #55265 succeeded 925ba5e
💔 Build #55149 failed 848c96e
💔 Build #55138 failed 609b82a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris added 11 commits June 17, 2020 14:13

added migration via EOS plugin

6ded0a8

added end-to-end test of the ESO migration

c3e94b5

moved crypto to top level

57ea89e

removed alerts migration

7c14ed2

reverted change in alerting

1c205c6

improved documentation

aac18a6

ensure migrations dont block the event loop

5655085

Revert "reverted change in alerting"

c32cedf

This reverts commit 1c205c6.

Revert "removed alerts migration"

cdbf672

This reverts commit 7c14ed2.

added migration test for alerting

609b82a

gmmorris requested review from a team as code owners June 18, 2020 17:52

gmmorris added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.9.0 v8.0.0 labels Jun 18, 2020

gmmorris added the release_note:skip Skip the PR/issue when compiling release notes label Jun 18, 2020

gmmorris added 9 commits June 18, 2020 19:06

fixed incorrect typing

bda02bd

Merge branch 'alerting/migrate-old-alerting-consumere' into alerting/…

848c96e

…migrate-old-alerting-consumer * alerting/migrate-old-alerting-consumere: fixed incorrect typing

removed unused imports

a9ee1c4

removed metric migration from test

925ba5e

cleaned up platform code

998d0d4

Merge branch 'alerting/migrate-old-alerting-consumere' into alerting/…

6b32148

…migrate-old-alerting-consumer * alerting/migrate-old-alerting-consumere: cleaned up platform code

gmmorris closed this Jun 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[alerting] migrates the old `alerting` consumer to be `alerts` #69555

[alerting] migrates the old `alerting` consumer to be `alerts` #69555

gmmorris commented Jun 18, 2020 •

edited

Loading

elasticmachine commented Jun 18, 2020

gmmorris commented Jun 25, 2020

kibanamachine commented Jun 25, 2020

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

[alerting] migrates the old alerting consumer to be alerts #69555

[alerting] migrates the old alerting consumer to be alerts #69555

Conversation

gmmorris commented Jun 18, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Jun 18, 2020

gmmorris commented Jun 25, 2020

kibanamachine commented Jun 25, 2020

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Build metrics

History

[alerting] migrates the old `alerting` consumer to be `alerts` #69555

[alerting] migrates the old `alerting` consumer to be `alerts` #69555

gmmorris commented Jun 18, 2020 •

edited

Loading