Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Persist time range across apps #79258

Merged
merged 6 commits into from
Oct 6, 2020

Conversation

cauemarcondes
Copy link
Contributor

Uses kibana data plugin to get the date time and set on the date picker when the values are not set in the URL, otherwise falls back to use kibana default settings.

persist-time

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-255463778

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
observability 166.8KB 167.0KB +224.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit d8b4472 into elastic:master Oct 6, 2020
@cauemarcondes cauemarcondes deleted the obs-persit-time-range branch October 6, 2020 11:29
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Oct 6, 2020
* using kibana persisted date when available to set the date time

* fixing types

* adding setTime when changin the dates in the url

* renaming

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/observability/public/context/plugin_context.tsx
#	x-pack/plugins/observability/public/pages/overview/index.tsx
#	x-pack/plugins/observability/public/pages/overview/overview.stories.tsx
#	x-pack/plugins/observability/public/utils/test_helper.tsx
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Oct 6, 2020
* using kibana persisted date when available to set the date time

* fixing types

* adding setTime when changin the dates in the url

* renaming

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/observability/public/context/plugin_context.tsx
#	x-pack/plugins/observability/public/pages/overview/index.tsx
#	x-pack/plugins/observability/public/pages/overview/overview.stories.tsx
#	x-pack/plugins/observability/public/utils/test_helper.tsx
cauemarcondes added a commit that referenced this pull request Oct 6, 2020
* using kibana persisted date when available to set the date time

* fixing types

* adding setTime when changin the dates in the url

* renaming

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/observability/public/context/plugin_context.tsx
#	x-pack/plugins/observability/public/pages/overview/index.tsx
#	x-pack/plugins/observability/public/pages/overview/overview.stories.tsx
#	x-pack/plugins/observability/public/utils/test_helper.tsx
gmmorris added a commit that referenced this pull request Oct 8, 2020
…into feature/task_manager_429

* 'feature/task_manager_429' of github.com:elastic/kibana: (158 commits)
  Add license check to direct package upload handler. (#79653)
  [Ingest Manager] Rename API /api/ingest_manager => /api/fleet (#79193)
  [Security Solution][Resolver] Simplify CopyableField styling and add comments (#79594)
  Fine-tunes ML related text on Metrics UI (#79425)
  [ML] DF Analytics creation wizard: ensure job creation possible when model memory lower than estimate (#79229)
  Add new "Add Data" tutorials (#77237)
  Update APM telemetry docs (#79583)
  Revert "Add support for runtime field types to mappings editor. (#77420)" (#79611)
  Kibana request headers (#79218)
  ensure missing indexPattern error is bubbled up to error callout (#79378)
  Missing space fix (#79585)
  remove duplicate tab states (#79501)
  [data.ui] Lazy load UI components in data plugin. (#78889)
  Add generic type params to search dependency. (#79608)
  [Ingest Manager] Internal action for policy reassign (#78493)
  [ILM] Add index_codec to forcemerge action in hot and warm phases (#78175)
  [Ingest Manager] Update open API spec and add condition to agent upgrade endpoint (#79579)
  [ML] Hide Data Grid column options when histogram charts are enabled. (#79459)
  [Telemetry] Synchronous `setup` and `start` methods (#79457)
  [Observability] Persist time range across apps (#79258)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants