Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Missing Margin on Panel Header #79585

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

ThomThomson
Copy link
Contributor

Summary

One liner fix to address a missing margin on the embeddable panel title.

Before:
Screen Shot 2020-10-05 at 6 11 28 PM

After
Screen Shot 2020-10-05 at 6 11 38 PM

For maintainers

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 5, 2020
@ThomThomson ThomThomson requested a review from a team as a code owner October 5, 2020 22:14
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Oct 5, 2020
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
embeddable 290.7KB 290.8KB +96.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson changed the title Fix Missing Margin on Fix Missing Margin on Panel Header Oct 5, 2020
@ThomThomson ThomThomson merged commit 1e36e27 into elastic:master Oct 6, 2020
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Oct 6, 2020
ThomThomson added a commit that referenced this pull request Oct 6, 2020
gmmorris added a commit that referenced this pull request Oct 8, 2020
…into feature/task_manager_429

* 'feature/task_manager_429' of github.com:elastic/kibana: (158 commits)
  Add license check to direct package upload handler. (#79653)
  [Ingest Manager] Rename API /api/ingest_manager => /api/fleet (#79193)
  [Security Solution][Resolver] Simplify CopyableField styling and add comments (#79594)
  Fine-tunes ML related text on Metrics UI (#79425)
  [ML] DF Analytics creation wizard: ensure job creation possible when model memory lower than estimate (#79229)
  Add new "Add Data" tutorials (#77237)
  Update APM telemetry docs (#79583)
  Revert "Add support for runtime field types to mappings editor. (#77420)" (#79611)
  Kibana request headers (#79218)
  ensure missing indexPattern error is bubbled up to error callout (#79378)
  Missing space fix (#79585)
  remove duplicate tab states (#79501)
  [data.ui] Lazy load UI components in data plugin. (#78889)
  Add generic type params to search dependency. (#79608)
  [Ingest Manager] Internal action for policy reassign (#78493)
  [ILM] Add index_codec to forcemerge action in hot and warm phases (#78175)
  [Ingest Manager] Update open API spec and add condition to agent upgrade endpoint (#79579)
  [ML] Hide Data Grid column options when histogram charts are enabled. (#79459)
  [Telemetry] Synchronous `setup` and `start` methods (#79457)
  [Observability] Persist time range across apps (#79258)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants