Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to delete index template along with pattern #8391

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

Bargs
Copy link
Contributor

@Bargs Bargs commented Sep 20, 2016

This commit reverts a change to use the ingest API when deleting index
patterns via the Kibana UI. Back when I was building the Filebeat wizard
it made sense to try to delete any index templates or pipelines that may
have been created along with an index pattern. But now that we're only
shipping with CSV Upload, and we don't delete the actual indices that
CSV upload creates, it doesn't make much sense to delete the template.
Now we'll treate the indices and templates consistently.

This also fixes an issue where users would get a fatal error if they
were using Security and they didn't have permissions to delete
templates. Every index pattern deletion would also attempt to delete an
associated template, so if the user didn't have the correct permissions
they would get a 403.

Related: #6457

This commit reverts a change to use the ingest API when deleting index
patterns via the Kibana UI. Back when I was building the Filebeat wizard
it made sense to try to delete any index templates or pipelines that may
have been created along with an index pattern. But now that we're only
shipping with CSV Upload, and we don't delete the actual indices that
CSV upload creates, it doesn't make much sense to delete the template.
Now we'll treate the indices and templates consistently.

This also fixes an issue where users would get a fatal error if they
were using Security and they didn't have permissions to delete
templates. Every index pattern deletion would also attempt to delete an
associated template, so if the user didn't have the correct permissions
they would get a 403.

Related: elastic#6457
@ycombinator
Copy link
Contributor

LLLLLLLLLLL                    GGGGGGGGGGGGGTTTTTTTTTTTTTTTTTTTTTTTMMMMMMMM               MMMMMMMM
L:::::::::L                 GGG::::::::::::GT:::::::::::::::::::::TM:::::::M             M:::::::M
L:::::::::L               GG:::::::::::::::GT:::::::::::::::::::::TM::::::::M           M::::::::M
LL:::::::LL              G:::::GGGGGGGG::::GT:::::TT:::::::TT:::::TM:::::::::M         M:::::::::M
  L:::::L               G:::::G       GGGGGGTTTTTT  T:::::T  TTTTTTM::::::::::M       M::::::::::M
  L:::::L              G:::::G                      T:::::T        M:::::::::::M     M:::::::::::M
  L:::::L              G:::::G                      T:::::T        M:::::::M::::M   M::::M:::::::M
  L:::::L              G:::::G    GGGGGGGGGG        T:::::T        M::::::M M::::M M::::M M::::::M
  L:::::L              G:::::G    G::::::::G        T:::::T        M::::::M  M::::M::::M  M::::::M
  L:::::L              G:::::G    GGGGG::::G        T:::::T        M::::::M   M:::::::M   M::::::M
  L:::::L              G:::::G        G::::G        T:::::T        M::::::M    M:::::M    M::::::M
  L:::::L         LLLLLLG:::::G       G::::G        T:::::T        M::::::M     MMMMM     M::::::M
LL:::::::LLLLLLLLL:::::L G:::::GGGGGGGG::::G      TT:::::::TT      M::::::M               M::::::M
L::::::::::::::::::::::L  GG:::::::::::::::G      T:::::::::T      M::::::M               M::::::M
L::::::::::::::::::::::L    GGG::::::GGG:::G      T:::::::::T      M::::::M               M::::::M
LLLLLLLLLLLLLLLLLLLLLLLL       GGGGGG   GGGG      TTTTTTTTTTT      MMMMMMMM               MMMMMMMM

@Bargs Bargs merged commit 7463cd4 into elastic:master Sep 22, 2016
elastic-jasper added a commit that referenced this pull request Sep 22, 2016
---------

**Commit 1:**
Don't try to delete index template along with pattern

This commit reverts a change to use the ingest API when deleting index
patterns via the Kibana UI. Back when I was building the Filebeat wizard
it made sense to try to delete any index templates or pipelines that may
have been created along with an index pattern. But now that we're only
shipping with CSV Upload, and we don't delete the actual indices that
CSV upload creates, it doesn't make much sense to delete the template.
Now we'll treate the indices and templates consistently.

This also fixes an issue where users would get a fatal error if they
were using Security and they didn't have permissions to delete
templates. Every index pattern deletion would also attempt to delete an
associated template, so if the user didn't have the correct permissions
they would get a 403.

Related: #6457

* Original sha: daa5b3b
* Authored by Matthew Bargar <[email protected]> on 2016-09-20T22:43:03Z
elastic-jasper added a commit that referenced this pull request Sep 22, 2016
---------

**Commit 1:**
Don't try to delete index template along with pattern

This commit reverts a change to use the ingest API when deleting index
patterns via the Kibana UI. Back when I was building the Filebeat wizard
it made sense to try to delete any index templates or pipelines that may
have been created along with an index pattern. But now that we're only
shipping with CSV Upload, and we don't delete the actual indices that
CSV upload creates, it doesn't make much sense to delete the template.
Now we'll treate the indices and templates consistently.

This also fixes an issue where users would get a fatal error if they
were using Security and they didn't have permissions to delete
templates. Every index pattern deletion would also attempt to delete an
associated template, so if the user didn't have the correct permissions
they would get a 403.

Related: #6457

* Original sha: daa5b3b
* Authored by Matthew Bargar <[email protected]> on 2016-09-20T22:43:03Z
Bargs pushed a commit that referenced this pull request Sep 22, 2016
Bargs pushed a commit that referenced this pull request Sep 22, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
---------

**Commit 1:**
Don't try to delete index template along with pattern

This commit reverts a change to use the ingest API when deleting index
patterns via the Kibana UI. Back when I was building the Filebeat wizard
it made sense to try to delete any index templates or pipelines that may
have been created along with an index pattern. But now that we're only
shipping with CSV Upload, and we don't delete the actual indices that
CSV upload creates, it doesn't make much sense to delete the template.
Now we'll treate the indices and templates consistently.

This also fixes an issue where users would get a fatal error if they
were using Security and they didn't have permissions to delete
templates. Every index pattern deletion would also attempt to delete an
associated template, so if the user didn't have the correct permissions
they would get a 403.

Related: elastic#6457

* Original sha: bd504da3ffb4d15882c41506f7419e7827c7818e [formerly daa5b3b]
* Authored by Matthew Bargar <[email protected]> on 2016-09-20T22:43:03Z


Former-commit-id: bc7b8d3
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants