[Security Solution][Detections] Alert table status update bug #87243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dplumlee
added
bug
dplumlee
commented
Jan 5, 2021
| @@ -60,9 +60,6 @@ const AlertContextMenuComponent: React.FC<AlertContextMenuProps> = ({ | |||
| const dispatch = useDispatch(); | |||
| const [, dispatchToaster] = useStateToaster(); | |||
| const [isPopoverOpen, setPopover] = useState(false); | |||
| const [alertStatus, setAlertStatus] = useState<Status | undefined>( | |||
There was a problem hiding this comment.
This useState was causing the render bug, and since we aren't actually utilizing the setAlertStatus to do anything functional outside this component, I've changed it to always getting the alert status directly from the ECS data as it'll always be correct when rendered.
|
@elasticmachine merge upstream |
yctercero
reviewed
Jan 6, 2021
| @@ -90,6 +87,10 @@ const AlertContextMenuComponent: React.FC<AlertContextMenuProps> = ({ | |||
|
|
|||
| const { addWarning } = useAppToasts(); | |||
|
|
|||
| const getAlertStatus = useCallback(() => { | |||
There was a problem hiding this comment.
Could this just be a useMemo?
yctercero
approved these changes
Jan 6, 2021
banderror
approved these changes
Jan 6, 2021
| @@ -90,6 +87,10 @@ const AlertContextMenuComponent: React.FC<AlertContextMenuProps> = ({ | |||
|
|
|||
| const { addWarning } = useAppToasts(); | |||
|
|
|||
| const getAlertStatus = useCallback(() => { | |||
dplumlee
force-pushed
the
alert-status-update-bug
branch
from
e6bbf82 to
bfe9bca
Compare
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
This was referenced Jan 7, 2021
dplumlee
added a commit
to dplumlee/kibana
that referenced
this pull request
Jan 7, 2021
dplumlee
added a commit
that referenced
this pull request
Jan 8, 2021
dplumlee
added a commit
that referenced
this pull request
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #85748
Fixes the case where alert status wouldn't get immediately updated (Opened, Closed, Made in-progress) when changed in the alerts table.
Video
alertStatusUpdateBug.mov
Checklist
Delete any items that are not applicable to this PR.
For maintainers