Skip to content

Commit

Permalink
fix: Version 6.3.5 makes build pass even when it fails
Browse files Browse the repository at this point in the history
Closes #721
develar committed Sep 8, 2016
1 parent 63ee4cf commit a1b2b0e
Showing 1 changed file with 12 additions and 13 deletions.
25 changes: 12 additions & 13 deletions src/targets/dmg.ts
Original file line number Diff line number Diff line change
@@ -33,21 +33,20 @@ export class DmgTarget extends Target {
async build(appOutDir: string) {
const appInfo = this.packager.appInfo
const artifactPath = path.join(appOutDir, `${appInfo.productFilename}-${appInfo.version}.dmg`)
await new BluebirdPromise<any>(async(resolve, reject) => {
log("Creating DMG")
const dmgOptions = {
target: artifactPath,
basepath: this.packager.projectDir,
specification: await this.computeDmgOptions(appOutDir),
}

if (debug.enabled) {
debug(`appdmg: ${JSON.stringify(dmgOptions, <any>null, 2)}`)
}
log("Creating DMG")
const dmgOptions = {
target: artifactPath,
basepath: this.packager.projectDir,
specification: await this.computeDmgOptions(appOutDir),
}
if (debug.enabled) {
debug(`appdmg: ${JSON.stringify(dmgOptions, <any>null, 2)}`)
}

const emitter = require("appdmg")(dmgOptions)
const emitter = require("appdmg")(dmgOptions)
await new BluebirdPromise((resolve, reject) => {
emitter.on("error", reject)
emitter.on("finish", () => resolve())
emitter.on("finish", resolve)
if (debug.enabled) {
emitter.on("progress", (info: any) => {
if (info.type === "step-begin") {

0 comments on commit a1b2b0e

Please sign in to comment.