Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] loadingGif Initialization Time #374

Closed
daviseford opened this issue May 2, 2016 · 10 comments · May be fixed by qcif/data-curator#563
Closed

[Feature Request] loadingGif Initialization Time #374

daviseford opened this issue May 2, 2016 · 10 comments · May be fixed by qcif/data-curator#563

Comments

@daviseford
Copy link

Hey folks, I have a feature request for you.

I read somewhere a couple days ago (can't find it now) that the build.win.loadingGif is only called after x number of seconds - it's only supposed to show for "big" installations.

I'd like to make sure that the loadingGif shows immediately to our users - I'd like to bypass the 3-4 second delay before the loadingGif shows.

Reason: On Windows, we have a lot of users complaining about the setup process.

They doubleclick setup.exe, and there's no indication of activity from the OS - it just looks like it's hanging, or waiting on the user. A lot of users end up clicking the setup again and occasionally creating errors.

Solution: I'd like to be able to specify an option in my package.sjon underneath "loadingGif"

ex.

"win":{
"loadingGif": "/path/to/gif/",
"gif_delay": 100 // 100 milliseconds
}

@chriswetterman
Copy link

+1
I'd like to be able to show a custom image on screen during the installation process so users know that something is going on.

@develar
Copy link
Member

develar commented May 3, 2016

I'd like to be able to show a custom image on screen during the installation process

See https://github.com/electron-userland/electron-builder/wiki/Options#WinBuildOptions-loadingGif

AnimatedGifWindow.ShowWindow(TimeSpan.FromSeconds(4), animatedGifWindowToken.Token, progressSource);

Yes. 4 seconds. Please see Squirrel/Squirrel.Windows#77 and comment there.

"I'll probably lower this to maybe 2sec, but I don't really want it to be configurable, if people want a non-custom number, they can use their fork"

It means that: please double check that you handle Squirrel events correctly — "either Squirrel events are being handled incorrectly".

If it will be still actual for you, I will make PR to Squirrel.Windows. But please note — author of Squirrel.Windows doesn't want to accept such PR.

@daviseford
Copy link
Author

Thanks develar! I commented on the issue. Really hope this feature can work

@develar
Copy link
Member

develar commented May 4, 2016

@daviseford Did you check — do you handle Squirrel.Windows events correctly? If so and if you still has this issue, I will fix it. But please note — I don't want to do if just because issue is opened — please ensure that it is really needed and no error on your side.

@daviseford
Copy link
Author

I did check, and Squirrel.Windows events are handled correctly. I'd just like to be able to reduce the 4 second loading time :)

Thanks so much!

@develar
Copy link
Member

develar commented May 24, 2016

Delay is removed. It is not possible to fix it correctly — currently, Squirrel.Windows bootstrap (pure C++) extract animation gif, update.exe and package and only then starts update.exe (net45). Well, if some user doesn't like it — just use OS X.

develar added a commit to develar/electron-builder that referenced this issue May 24, 2016

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* no more lib/net45 anymore - as in previous versions of electron-builder
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — *osx* for OS X instead of appName-darwin-arch, *linux* for Linux instead of appName-linux-arch

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit that referenced this issue May 25, 2016

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for #434.

Closes #374, #416
@ghost
Copy link

ghost commented Jun 13, 2016

Is the animation delay removed on windows 32 bit too? I tried it there and it takes quite a while for that loading gif to show up, in fact, it shows up AFTER the app is installed and RUNNING! (And then quickly disappears again) Annoying!

@develar
Copy link
Member

develar commented Jun 13, 2016

@kunkinkan Don't forget about the rest of my comment — It is not possible to fix it correctly — currently, Squirrel.Windows bootstrap (pure C++) extract animation gif, update.exe and package and only then starts update.exe (net45). You can expect true progress bar in the upcoming NSIS installer.

@develar develar mentioned this issue Jun 13, 2016
@abuhenasobuj
Copy link

It's will be very good feature.
We can this feature to introducing our apps by GIF Animation.
Eg:
First I want to show an splash screen that took nearly 10 sec then installation will start & finished in few sec.

@develar
Copy link
Member

develar commented Dec 20, 2016

@abuhenasobuj Just use NSIS target (default now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants