-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] loadingGif Initialization Time #374
Comments
+1 |
See https://github.com/electron-userland/electron-builder/wiki/Options#WinBuildOptions-loadingGif
Yes. 4 seconds. Please see Squirrel/Squirrel.Windows#77 and comment there. "I'll probably lower this to maybe 2sec, but I don't really want it to be configurable, if people want a non-custom number, they can use their fork" It means that: please double check that you handle Squirrel events correctly — "either Squirrel events are being handled incorrectly". If it will be still actual for you, I will make PR to Squirrel.Windows. But please note — author of Squirrel.Windows doesn't want to accept such PR. |
Thanks develar! I commented on the issue. Really hope this feature can work |
@daviseford Did you check — do you handle Squirrel.Windows events correctly? If so and if you still has this issue, I will fix it. But please note — I don't want to do if just because issue is opened — please ensure that it is really needed and no error on your side. |
I did check, and Squirrel.Windows events are handled correctly. I'd just like to be able to reduce the 4 second loading time :) Thanks so much! |
Delay is removed. It is not possible to fix it correctly — currently, Squirrel.Windows bootstrap (pure C++) extract animation gif, update.exe and package and only then starts update.exe (net45). Well, if some user doesn't like it — just use OS X. |
Under the hood a lot of changes: * electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized) * no more lib/net45 anymore - as in previous versions of electron-builder * windows bootstrap loadingGif delay removed * windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9) * app out dir changed — *osx* for OS X instead of appName-darwin-arch, *linux* for Linux instead of appName-linux-arch Closes electron-userland#374, electron-userland#416
Under the hood a lot of changes: * electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized) * windows bootstrap loadingGif delay removed * windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9) * app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch * **Windows Code Signing on Linux** @heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434. Closes electron-userland#374, electron-userland#416
Under the hood a lot of changes: * electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized) * windows bootstrap loadingGif delay removed * windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9) * app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch * **Windows Code Signing on Linux** @heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434. Closes electron-userland#374, electron-userland#416
Under the hood a lot of changes: * electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized) * windows bootstrap loadingGif delay removed * windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9) * app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch * **Windows Code Signing on Linux** @heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434. Closes electron-userland#374, electron-userland#416
Under the hood a lot of changes: * electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized) * windows bootstrap loadingGif delay removed * windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9) * app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch * **Windows Code Signing on Linux** @heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434. Closes electron-userland#374, electron-userland#416
Under the hood a lot of changes: * electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized) * windows bootstrap loadingGif delay removed * windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9) * app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch * **Windows Code Signing on Linux** @heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434. Closes electron-userland#374, electron-userland#416
Under the hood a lot of changes: * electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized) * windows bootstrap loadingGif delay removed * windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9) * app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch * **Windows Code Signing on Linux** @heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434. Closes electron-userland#374, electron-userland#416
Under the hood a lot of changes: * electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized) * windows bootstrap loadingGif delay removed * windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9) * app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch * **Windows Code Signing on Linux** @heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434. Closes electron-userland#374, electron-userland#416
Under the hood a lot of changes: * electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized) * windows bootstrap loadingGif delay removed * windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9) * app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch * **Windows Code Signing on Linux** @heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434. Closes electron-userland#374, electron-userland#416
Under the hood a lot of changes: * electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized) * windows bootstrap loadingGif delay removed * windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9) * app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch * **Windows Code Signing on Linux** @heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for #434. Closes #374, #416
Is the animation delay removed on windows 32 bit too? I tried it there and it takes quite a while for that loading gif to show up, in fact, it shows up AFTER the app is installed and RUNNING! (And then quickly disappears again) Annoying! |
@kunkinkan Don't forget about the rest of my comment — It is not possible to fix it correctly — currently, Squirrel.Windows bootstrap (pure C++) extract animation gif, update.exe and package and only then starts update.exe (net45). You can expect true progress bar in the upcoming NSIS installer. |
It's will be very good feature. |
@abuhenasobuj Just use NSIS target (default now). |
Hey folks, I have a feature request for you.
I read somewhere a couple days ago (can't find it now) that the build.win.loadingGif is only called after x number of seconds - it's only supposed to show for "big" installations.
I'd like to make sure that the loadingGif shows immediately to our users - I'd like to bypass the 3-4 second delay before the loadingGif shows.
Reason: On Windows, we have a lot of users complaining about the setup process.
They doubleclick setup.exe, and there's no indication of activity from the OS - it just looks like it's hanging, or waiting on the user. A lot of users end up clicking the setup again and occasionally creating errors.
Solution: I'd like to be able to specify an option in my package.sjon underneath "loadingGif"
ex.
"win":{
"loadingGif": "/path/to/gif/",
"gif_delay": 100 // 100 milliseconds
}
The text was updated successfully, but these errors were encountered: