Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Signing Issue on Server 2008 R2 #416

Closed
dennyferra opened this issue May 19, 2016 · 2 comments
Closed

Code Signing Issue on Server 2008 R2 #416

dennyferra opened this issue May 19, 2016 · 2 comments

Comments

@dennyferra
Copy link

node version 5.9.0
npm version 3.7.3
electron 0.38.9
electron-builder 3.23.0

I'm having trouble code-signing my app with electron-builder. This issue is happening on our Team City build server which is running Server 2008 R2.

The error that is being generated is:

Done Adding Additional Store
SignTool Error: An unexpected internal error has occurred.
Error information: "Error: SignerSign() failed." (-2147024846/0x80070032)

I'm not able to find much information on the error code given above. I extracted the complete SignTool command that is being used (and pointed to the certificate locally), this gives the error mentioned above:

signtool sign /tr http://timestamp.comodoca.com/rfc3161 /f C:\certificate.p12 /fd sha256 /td sha256 /d Downloader /as /p ***** D:\TeamCity\buildAgent\work\3cb96f5abb9e4582\release\downloader-win32-x64\Downloader.exe

Interestingly code signing works fine on my development machine which is running Windows 10.
@develar
Copy link
Member

develar commented May 19, 2016

We must sign using dual-code sign — sha1 for old windows versions and sha256 for new windows 10 (required by Microsoft). So, bundled signtool requires windows 10 to be run. I assume, Server 2008 R2 is too old. Is it possible to upgrade to Windows Server 2012 & 2012 R2? In any case I am not yet sure that Server 2008 R2 is not possible to support but... I doesn't have it to test.

@develar
Copy link
Member

develar commented May 20, 2016

@dennyferra BTW, please update to 3.25 because 3.23 has critical regression if you build win on win.

@develar develar mentioned this issue May 24, 2016
Closed
develar added a commit to develar/electron-builder that referenced this issue May 24, 2016
@develar
feat(windows): specification of signing algorithms
fbeb150 
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* no more lib/net45 anymore - as in previous versions of electron-builder
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — *osx* for OS X instead of appName-darwin-arch, *linux* for Linux instead of appName-linux-arch

Closes electron-userland#374, electron-userland#416
@develar develar mentioned this issue May 24, 2016
Merged
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016
@develar
feat(windows): specification of signing algorithms
3f06fd5 
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016
@develar
feat(windows): specification of signing algorithms
4d37f37 
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016
@develar
feat(windows): specification of signing algorithms
a783312 
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016
@develar
feat(windows): specification of signing algorithms
5c08d78 
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016
@develar
feat(windows): specification of signing algorithms
421efe9 
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016
@develar
feat(windows): specification of signing algorithms
68c648e 
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016
@develar
feat(windows): specification of signing algorithms
e81dd52 
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit to develar/electron-builder that referenced this issue May 25, 2016
@develar
feat(windows): specification of signing algorithms
fa826cc 
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for electron-userland#434.

Closes electron-userland#374, electron-userland#416
develar added a commit that referenced this issue May 25, 2016
@develar
feat(windows): specification of signing algorithms (#435)
73e7c14 
Under the hood a lot of changes:
* electron-packages fork use promises, option added to avoid move on electron-builder side (generated app out dir customized)
* windows bootstrap loadingGif delay removed
* windows bootstrap zip uses default compression level to speedup decompression (package is still compressed using -9)
* app out dir changed — **osx** for OS X instead of appName-darwin-arch, **linux** for Linux instead of appName-linux-arch
* **Windows Code Signing on Linux**

@heinzbeinz added `signingHashAlgorithms` and code signing on windows 2008 r2, thanks for #434.

Closes #374, #416
@develar develar closed this as completed May 26, 2016
@dependabot-preview dependabot-preview bot mentioned this issue Mar 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dennyferra @develar