Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename vmRequired variable to useVmIfNotOnWin #8727

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

ItsHarper
Copy link
Contributor

While working on learning how to set up code signing customization, the name vmRequired confused me a good bit, since it seemed to imply that a VM was required even when running on Windows.

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: 315325a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta mmaietta changed the title Rename vmRequired variable to useVmIfNotOnWin chore: Rename vmRequired variable to useVmIfNotOnWin Dec 6, 2024
@mmaietta mmaietta merged commit 7268c2e into electron-userland:master Dec 6, 2024
9 of 10 checks passed
@ItsHarper ItsHarper deleted the patch-1 branch December 21, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants