Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename vmRequired variable to useVmIfNotOnWin #8727

Merged
merged 3 commits into from
Dec 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shy-pumas-attack.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": patch
---

chore: Rename `vmRequired` variable to `useVmIfNotOnWin`
Original file line number Diff line number Diff line change
Expand Up @@ -438,11 +438,11 @@ export class WindowsSignToolManager implements SignManager {
let args: Array<string>
let env = process.env
let vm: VmManager
const vmRequired = configuration.path.endsWith(".appx") || !("file" in configuration.cscInfo!) /* certificateSubjectName and other such options */
const isWin = process.platform === "win32" || vmRequired
const useVmIfNotOnWin = configuration.path.endsWith(".appx") || !("file" in configuration.cscInfo!) /* certificateSubjectName and other such options */
const isWin = process.platform === "win32" || useVmIfNotOnWin
const toolInfo = await this.getToolPath(isWin)
const tool = toolInfo.path
if (vmRequired) {
if (useVmIfNotOnWin) {
vm = await packager.vm.value
args = this.computeSignToolArgs(configuration, isWin, vm)
} else {
Expand Down
Loading