Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wine for running on mac and linux #1

Merged
merged 2 commits into from
Apr 19, 2014
Merged

Use wine for running on mac and linux #1

merged 2 commits into from
Apr 19, 2014

Conversation

SamyPesse
Copy link
Contributor

This PR just use wine when not windows to start rcedit. I tested it on my mac and the icon is correctly set (tested on windows).

@SamyPesse
Copy link
Contributor Author

@zcbenz Is there anything you need me to do before merging this PR ?

@zcbenz
Copy link
Contributor

zcbenz commented Apr 19, 2014

This is awesome, thanks!

zcbenz added a commit that referenced this pull request Apr 19, 2014
Use wine for running on mac and linux
@zcbenz zcbenz merged commit cb0ce88 into electron:master Apr 19, 2014
@SamyPesse
Copy link
Contributor Author

You're welcome

@zcbenz
Copy link
Contributor

zcbenz commented Apr 19, 2014

[email protected] has been published to include this.

@SamyPesse
Copy link
Contributor Author

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants