Add option for changing windows icon

[SamyPesse]

This PR add an option winIco for changing the windows executable icon. This is working, I just test it using:

var NwBuilder = require('./');
var nw = new NwBuilder({
    files: '/Users/samypesse/Desktop/Projects/GitBook/editor/**/**', // use the glob format
    platforms: ['win'],
    winIco: '/Users/samypesse/Desktop/Projects/GitBook/editor/src/resources/images/icons/512.ico'
});

// Log stuff you you want
nw.on('log',  console.log);

// Build retruns a promise
nw.build().then(function () {
   console.log('all done!');
}).catch(function (error) {
    console.error(error);
});

I also fix a typo: "platform" instead of "plattform".

I have a PR pending on electron/node-rcedit#1 that adds the support of mac and linux to node-rcedit.

[steffenmllr]

Does that work with relative paths? If not could you add a path.resolve

[SamyPesse]

It should works fine with relative paths but I added a path.resolve just to be sure :)

[steffenmllr]

Thanks for the PR and the the typo fix - in my defense it's spelled like this in German

[steffenmllr]

Could you also pls squash your commits ?

[steffenmllr]

travis also isn't happy: https://travis-ci.org/mllrsohn/node-webkit-builder/builds/23124435

[SamyPesse]

Don't worry, I understand, I'm french ;)

I'll fix the travis issue and then squash my commit, but can I ask why do you want me to squash all my commits?

[SamyPesse]

Ok, for travis, it's because we have to yet for the PR on node-rcedit to be merged since it's coffeescript.

[steffenmllr]

it's just cleaner to have on PR eql one commit - german remember - but since this is alpha do and there is also typo fixing it's fine i'll test and merge it

[SamyPesse]

Ok, I'll keep you update as soon as the other PR is merged.

When do you plan on updating grunt-node-webkit-builder with this module? And by the way: thank you for grunt-node-webkit-builder 👍

[steffenmllr]

Thanks, there is a branch with the new module: https://github.com/mllrsohn/grunt-node-webkit-builder/blob/develp/tasks/node_webkit_builder.js

I want to release it as soon as possible, haven't had to time to test everything under linux + windows.

[steffenmllr]

could you also please add an entry to the readme?

[SamyPesse]

Done!

[ivantodorovich]

Please merge this, I need the winIco feature 👍

Also, It might be good to update the npm package

[SamyPesse]

We have to wait for electron/node-rcedit#1 to be merged.

[ivantodorovich]

We could simply ignore winIco if process.platform !== 'win32', at least until that gets merged.

[steffenmllr]

Going to publish the next version on npm next week - if it is not merged until then I'll consider doing a windows only version

[SamyPesse]

OK, I can make it windows only right now and make another PR if/when electron/node-rcedit#1 is merged by the @atom team (@zcbenz or @kevinsawicki).

Another easy solution could be to use [email protected] dependency which contain the rcedit binary and run the binary from node-webkit-builder using the same code as this: https://github.com/SamyPesse/node-rcedit/blob/feature/maclinux/src/rcedit.coffee

@steffenmllr what do you prefer?

[steffenmllr]

no rush, let's wait until next week. Also want to get the tests working on windows #5 until then.

[SamyPesse]

The PR on node-rcedit has been merged!

[steffenmllr]

@SamyPesse can you pls rebase master?

[SamyPesse]

Done!

[steffenmllr]

Thanks again for you PR

[steffenmllr]

ping: @SamyPesse
#19