Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons from Figma. #95

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Update icons from Figma. #95

merged 4 commits into from
Jul 24, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 24, 2024

@Velin92 noticed that the unpin icon was missing, so I decided to do a complete sync with Figma. This has resulted in calendar and room also being added and a handful of seemingly minor tweaks to existing icons - the export was done with the usual Monochrome preset and only about 30% of the icons have changes so may just be refinements to the path algorithm in the plugin.

The second commit tweaks the generation script as (possibly following the style dictionary update?) we weren't generating the icons for Swift or Kotlin. I have zero idea why editing getIOSConfig fixed Kotlin, but it did 🤷‍♂️.

pixlwave added 3 commits July 24, 2024 14:30
Neither Kotlin nor Swift were being updated. But the fix was in getIOSConfig 🤷‍♂️
@pixlwave pixlwave requested a review from a team as a code owner July 24, 2024 13:42
@pixlwave pixlwave requested review from jmartinesp and robintown July 24, 2024 13:47
@jmartinesp
Copy link
Member

The second commit tweaks the generation script as (possibly following the style dictionary update?) we weren't generating the icons for Swift or Kotlin. I have zero idea why editing getIOSConfig fixed Kotlin, but it did 🤷‍♂️.

That's not scary at all 🫠 .

@robintown
Copy link
Member

Uh oh. We could make our CI wipe the assets folder clean before running the generation step to catch those kinds of things.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the icons were imported fine in Compound Android locally, LGTM!

@pixlwave
Copy link
Member Author

Uh oh. We could make our CI wipe the assets folder clean before running the generation step to catch those kinds of things.

Yeah sounds reasonable to me.

@pixlwave pixlwave merged commit b972318 into main Jul 24, 2024
3 checks passed
@pixlwave pixlwave deleted the doug/icons branch July 24, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants