-
-
Notifications
You must be signed in to change notification settings - Fork 827
Update @vector-im/compound-design-tokens #12876
Conversation
@@ -6946,14 +6946,6 @@ matrix-widget-api@^1.8.2: | |||
"@types/events" "^3.0.0" | |||
events "^3.2.0" | |||
|
|||
matrix-widget-api@^1.8.2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate. Already present line 6941.
379c836
to
843e097
Compare
playwright/snapshots/spaces/spaces.spec.ts/space-panel-expanded-linux.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking visual nit
...ouncement/releaseAnnouncement.spec.ts/release-announcement-Threads-Activity-Centre-linux.png
Outdated
Show resolved
Hide resolved
@robintown also the I wonder what is the best approach:
|
I think the current pattern in which h1, h2, h3, h4 map directly to our heading/xl, heading/lg, heading/md, heading/sm design tokens is pretty nice. If we keep wanting to use body/* tokens as headers, that's an indication that we should change something about our design system IMO. Germain noticed this too: element-hq/compound#154 |
Hmmm you're right. I have the feeling that we are missing smaller tokens for heading. Maybe that's why designers are using body token for small headers. Let's keep it in this state in this PR and we will have the conversation and update it if theses changes are not welcomed. |
4a460f9
to
a905c04
Compare
...oarding-new.spec.ts/User-Onboarding-new-user-page-is-shown-and-preference-exists-1-linux.png
Outdated
Show resolved
Hide resolved
playwright/snapshots/user-view/user-view.spec.ts/user-info-linux.png
Outdated
Show resolved
Hide resolved
3634f46
to
eed95c2
Compare
eed95c2
to
33c718e
Compare
Checklist
public
/exported
symbols have accurate TSDoc documentation.The changes:
The playwright snapshots are updated to use the correct heading.
The jest snapshots are updated for theses icons