Handle case when device cannot be verified #6475
Conversation
BillCarsonFr
requested review from
a team and
onurays
and removed request for
a team and
onurays
| // secure backup is setup | ||
| val hasTargetDeviceToVerifyAgainst = session | ||
| .cryptoService() | ||
| .getUserDevices(session.myUserId) |
There was a problem hiding this comment.
Are we sure that all the user devices are known by the SDK at this point?
There was a problem hiding this comment.
there is a force download call few lines before. But maybe i should switch to crypto context to avoid outof sync db?
| } | ||
| } | ||
| } | ||
| } else if (!isMine) { |
There was a problem hiding this comment.
We are already in a if (isMine) block, so this is strange. Dead code?
Also line 197 could be simplified. No need to test if (!isMine)
There was a problem hiding this comment.
yeah strange I used the editor split condition and it did that, will review the logic
In this case you have no recovery method, nor other device to verify against. So reset is your only choice, there is nothing to destruct and that's what you hsould do. |
BillCarsonFr
force-pushed
the
feature/bca/crypto_unable_self_verify
branch
from
9be5f91 to
ed46ce6
Compare
BillCarsonFr
force-pushed
the
feature/bca/crypto_unable_self_verify
branch
from
ed46ce6 to
ac7b47b
Compare
|
SonarCloud Quality Gate failed. |
Type of change
Content
Fixes #6466
Motivation and context
When there is no way to verify a new device, prompt and propose to reset verifications keys.
Screenshots / GIFs
This can be performed from settings also
A click on the popup will open the 4S setup bottomsheet
Tests
Tested devices
Checklist